[v2,01/10] KEYS: Create static version of public_key_verify_signature

Commit Message

Eric Snowberg Dec. 7, 2022, 5:12 p.m. UTC

The kernel test robot reports undefined reference to
public_key_verify_signature when CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE is
not defined. Create a static version in this case and return -EINVAL.

Reported-by: kernel test robot <[e-mail]>
Signed-off-by: Eric Snowberg <[e-mail]>
Reviewed-by: Mimi Zohar <[e-mail]>
---
 include/crypto/public_key.h | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Petr Vorel Dec. 7, 2022, 5:52 p.m. UTC | #1

Hi Eric,

Reviewed-by: Petr Vorel <[e-mail]>

Kind regards,
Petr

Patch

diff --git a/include/crypto/public_key.h b/include/crypto/public_key.h
index 68f7aa2a7e55..6d61695e1cde 100644
--- a/include/crypto/public_key.h
+++ b/include/crypto/public_key.h
@@ -80,7 +80,16 @@  extern int create_signature(struct kernel_pkey_params *, const void *, void *);
 extern int verify_signature(const struct key *,
 			    const struct public_key_signature *);
 
+#if IS_REACHABLE(CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE)
 int public_key_verify_signature(const struct public_key *pkey,
 				const struct public_key_signature *sig);
+#else
+static inline
+int public_key_verify_signature(const struct public_key *pkey,
+				const struct public_key_signature *sig)
+{
+	return -EINVAL;
+}
+#endif
 
 #endif /* _LINUX_PUBLIC_KEY_H */