| Message ID | 20230529225440.7315-1-minhuadotchen@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | capabilities: use logical OR | expand |
From: Min-Hua Chen <minhuadotchen@gmail.com> > Sent: 29 May 2023 23:55 > > Use logical OR to fix the following sparse warnings: > > security/commoncap.c:1358:41: sparse: warning: dubious: !x | y > > No functional changes intended. Except it will run just that teeny, weeny bit slower. David > Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> > --- > security/commoncap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/commoncap.c b/security/commoncap.c > index 0b3fc2f3afe7..b8e34f6204b2 100644 > --- a/security/commoncap.c > +++ b/security/commoncap.c > @@ -1355,7 +1355,7 @@ int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3, > return commit_creds(new); > } > > - if (((!cap_valid(arg3)) | arg4 | arg5)) > + if (((!cap_valid(arg3)) || arg4 || arg5)) > return -EINVAL; > > if (arg2 == PR_CAP_AMBIENT_IS_SET) { > -- > 2.34.1 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
diff --git a/security/commoncap.c b/security/commoncap.c index 0b3fc2f3afe7..b8e34f6204b2 100644 --- a/security/commoncap.c +++ b/security/commoncap.c @@ -1355,7 +1355,7 @@ int cap_task_prctl(int option, unsigned long arg2, unsigned long arg3, return commit_creds(new); } - if (((!cap_valid(arg3)) | arg4 | arg5)) + if (((!cap_valid(arg3)) || arg4 || arg5)) return -EINVAL; if (arg2 == PR_CAP_AMBIENT_IS_SET) {
Use logical OR to fix the following sparse warnings: security/commoncap.c:1358:41: sparse: warning: dubious: !x | y No functional changes intended. Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com> --- security/commoncap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)