| Message ID | 20231122115611.285625-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | apparmor: make stack_msg static | expand |
On 11/22/23 03:56, Ben Dooks wrote: > The stack_msg is not exported out of security/apparmor/domain.c so > make it static to avoid the following sparse warning: > > security/apparmor/domain.c:1314:12: warning: symbol 'stack_msg' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> thankyou for your contribution, unfortunately an the same patch went into apparmor-next on November 11 > --- > security/apparmor/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c > index 89fbeab4b33b..571158ec6188 100644 > --- a/security/apparmor/domain.c > +++ b/security/apparmor/domain.c > @@ -1311,7 +1311,7 @@ static int change_profile_perms_wrapper(const char *op, const char *name, > return error; > } > > -const char *stack_msg = "change_profile unprivileged unconfined converted to stacking"; > +static const char *stack_msg = "change_profile unprivileged unconfined converted to stacking"; > > /** > * aa_change_profile - perform a one-way profile transition
diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c index 89fbeab4b33b..571158ec6188 100644 --- a/security/apparmor/domain.c +++ b/security/apparmor/domain.c @@ -1311,7 +1311,7 @@ static int change_profile_perms_wrapper(const char *op, const char *name, return error; } -const char *stack_msg = "change_profile unprivileged unconfined converted to stacking"; +static const char *stack_msg = "change_profile unprivileged unconfined converted to stacking"; /** * aa_change_profile - perform a one-way profile transition
The stack_msg is not exported out of security/apparmor/domain.c so make it static to avoid the following sparse warning: security/apparmor/domain.c:1314:12: warning: symbol 'stack_msg' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- security/apparmor/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)