diff mbox series

selftests: remove the LSM_ID_IMA check in lsm/lsm_list_modules_test

Message ID 20231122160742.109270-2-paul@paul-moore.com (mailing list archive)
State Accepted
Delegated to: Paul Moore
Headers show
Series selftests: remove the LSM_ID_IMA check in lsm/lsm_list_modules_test | expand

Commit Message

Paul Moore Nov. 22, 2023, 4:07 p.m. UTC
The IMA LSM ID token was removed as IMA isn't yet a proper LSM, but
we forgot to remove the check from the selftest.

Reported-by: kernel test robot <yujie.liu@intel.com>
Closes: https://lore.kernel.org/r/202311221047.a9Dww3vY-lkp@intel.com/
Signed-off-by: Paul Moore <paul@paul-moore.com>
---
 tools/testing/selftests/lsm/lsm_list_modules_test.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Casey Schaufler Nov. 25, 2023, 4:51 p.m. UTC | #1
On 11/22/2023 8:07 AM, Paul Moore wrote:
> The IMA LSM ID token was removed as IMA isn't yet a proper LSM, but
> we forgot to remove the check from the selftest.
>
> Reported-by: kernel test robot <yujie.liu@intel.com>
> Closes: https://lore.kernel.org/r/202311221047.a9Dww3vY-lkp@intel.com/
> Signed-off-by: Paul Moore <paul@paul-moore.com>

Acked-by: Casey Schaufler <casey@schaufler-ca.com>

> ---
>  tools/testing/selftests/lsm/lsm_list_modules_test.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/lsm/lsm_list_modules_test.c b/tools/testing/selftests/lsm/lsm_list_modules_test.c
> index 445c02f09c74..9df29b1e3497 100644
> --- a/tools/testing/selftests/lsm/lsm_list_modules_test.c
> +++ b/tools/testing/selftests/lsm/lsm_list_modules_test.c
> @@ -101,9 +101,6 @@ TEST(correct_lsm_list_modules)
>  		case LSM_ID_TOMOYO:
>  			name = "tomoyo";
>  			break;
> -		case LSM_ID_IMA:
> -			name = "ima";
> -			break;
>  		case LSM_ID_APPARMOR:
>  			name = "apparmor";
>  			break;
Paul Moore Nov. 27, 2023, 5:07 p.m. UTC | #2
On Sat, Nov 25, 2023 at 11:51 AM Casey Schaufler <casey@schaufler-ca.com> wrote:
> On 11/22/2023 8:07 AM, Paul Moore wrote:
> > The IMA LSM ID token was removed as IMA isn't yet a proper LSM, but
> > we forgot to remove the check from the selftest.
> >
> > Reported-by: kernel test robot <yujie.liu@intel.com>
> > Closes: https://lore.kernel.org/r/202311221047.a9Dww3vY-lkp@intel.com/
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
>
> Acked-by: Casey Schaufler <casey@schaufler-ca.com>
>
> > ---
> >  tools/testing/selftests/lsm/lsm_list_modules_test.c | 3 ---
> >  1 file changed, 3 deletions(-)

Merged into lsm/dev, thanks.

> > diff --git a/tools/testing/selftests/lsm/lsm_list_modules_test.c b/tools/testing/selftests/lsm/lsm_list_modules_test.c
> > index 445c02f09c74..9df29b1e3497 100644
> > --- a/tools/testing/selftests/lsm/lsm_list_modules_test.c
> > +++ b/tools/testing/selftests/lsm/lsm_list_modules_test.c
> > @@ -101,9 +101,6 @@ TEST(correct_lsm_list_modules)
> >               case LSM_ID_TOMOYO:
> >                       name = "tomoyo";
> >                       break;
> > -             case LSM_ID_IMA:
> > -                     name = "ima";
> > -                     break;
> >               case LSM_ID_APPARMOR:
> >                       name = "apparmor";
> >                       break;
diff mbox series

Patch

diff --git a/tools/testing/selftests/lsm/lsm_list_modules_test.c b/tools/testing/selftests/lsm/lsm_list_modules_test.c
index 445c02f09c74..9df29b1e3497 100644
--- a/tools/testing/selftests/lsm/lsm_list_modules_test.c
+++ b/tools/testing/selftests/lsm/lsm_list_modules_test.c
@@ -101,9 +101,6 @@  TEST(correct_lsm_list_modules)
 		case LSM_ID_TOMOYO:
 			name = "tomoyo";
 			break;
-		case LSM_ID_IMA:
-			name = "ima";
-			break;
 		case LSM_ID_APPARMOR:
 			name = "apparmor";
 			break;