[v2,bpf-next,03/30] bpf: introduce BPF token object

Add new kind of BPF kernel object, BPF token. BPF token is meant to
allow delegating privileged BPF functionality, like loading a BPF
program or creating a BPF map, from privileged process to a *trusted*
unprivileged process, all while having a good amount of control over which
privileged operations could be performed using provided BPF token.

This is achieved through mounting BPF FS instance with extra delegation
mount options, which determine what operations are delegatable, and also
constraining it to the owning user namespace (as mentioned in the
previous patch).

BPF token itself is just a derivative from BPF FS and can be created
through a new bpf() syscall command, BPF_TOKEN_CREATE, which accepts BPF
FS FD, which can be attained through open() API by opening BPF FS mount
point. Currently, BPF token "inherits" delegated command, map types,
prog type, and attach type bit sets from BPF FS as is. In the future,
having an BPF token as a separate object with its own FD, we can allow
to further restrict BPF token's allowable set of things either at the
creation time or after the fact, allowing the process to guard itself
further from unintentionally trying to load undesired kind of BPF
programs. But for now we keep things simple and just copy bit sets as is.

When BPF token is created from BPF FS mount, we take reference to the
BPF super block's owning user namespace, and then use that namespace for
checking all the {CAP_BPF, CAP_PERFMON, CAP_NET_ADMIN, CAP_SYS_ADMIN}
capabilities that are normally only checked against init userns (using
capable()), but now we check them using ns_capable() instead (if BPF
token is provided). See bpf_token_capable() for details.

Such setup means that BPF token in itself is not sufficient to grant BPF
functionality. User namespaced process has to *also* have necessary
combination of capabilities inside that user namespace. So while
previously CAP_BPF was useless when granted within user namespace, now
it gains a meaning and allows container managers and sys admins to have
a flexible control over which processes can and need to use BPF
functionality within the user namespace (i.e., container in practice).
And BPF FS delegation mount options and derived BPF tokens serve as
a per-container "flag" to grant overall ability to use bpf() (plus further
restrict on which parts of bpf() syscalls are treated as namespaced).

Note also, BPF_TOKEN_CREATE command itself requires ns_capable(CAP_BPF)
within the BPF FS owning user namespace, rounding up the ns_capable()
story of BPF token. Also creating BPF token in init user namespace is
currently not supported, given BPF token doesn't have any effect in init
user namespace anyways.

Acked-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
 include/linux/bpf.h            |  41 +++++++
 include/uapi/linux/bpf.h       |  37 ++++++
 kernel/bpf/Makefile            |   2 +-
 kernel/bpf/inode.c             |  12 +-
 kernel/bpf/syscall.c           |  17 +++
 kernel/bpf/token.c             | 217 +++++++++++++++++++++++++++++++++
 tools/include/uapi/linux/bpf.h |  37 ++++++
 7 files changed, 357 insertions(+), 6 deletions(-)
 create mode 100644 kernel/bpf/token.c

Message ID	20240124022127.2379740-4-andrii@kernel.org (mailing list archive)
State	Handled Elsewhere
Delegated to:	Paul Moore
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85D2963A8; Wed, 24 Jan 2024 02:21:43 +0000 (UTC) From: Andrii Nakryiko <andrii@kernel.org> To: bpf@vger.kernel.org, netdev@vger.kernel.org, paul@paul-moore.com, brauner@kernel.org Cc: torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, kernel-team@meta.com Subject: [PATCH v2 bpf-next 03/30] bpf: introduce BPF token object Date: Tue, 23 Jan 2024 18:21:00 -0800 Message-Id: <20240124022127.2379740-4-andrii@kernel.org> In-Reply-To: <20240124022127.2379740-1-andrii@kernel.org> References: <20240124022127.2379740-1-andrii@kernel.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	BPF token \| expand [v2,bpf-next,00/30] BPF token [v2,bpf-next,01/30] bpf: align CAP_NET_ADMIN checks with bpf_capable() approach [v2,bpf-next,02/30] bpf: add BPF token delegation mount options to BPF FS [v2,bpf-next,03/30] bpf: introduce BPF token object [v2,bpf-next,04/30] bpf: add BPF token support to BPF_MAP_CREATE command [v2,bpf-next,05/30] bpf: add BPF token support to BPF_BTF_LOAD command [v2,bpf-next,06/30] bpf: add BPF token support to BPF_PROG_LOAD command [v2,bpf-next,07/30] bpf: take into account BPF token when fetching helper protos [v2,bpf-next,08/30] bpf: consistently use BPF token throughout BPF verifier logic [v2,bpf-next,09/30] bpf,lsm: refactor bpf_prog_alloc/bpf_prog_free LSM hooks [v2,bpf-next,10/30] bpf,lsm: refactor bpf_map_alloc/bpf_map_free LSM hooks [v2,bpf-next,11/30] bpf,lsm: add BPF token LSM hooks [v2,bpf-next,12/30] libbpf: add bpf_token_create() API [v2,bpf-next,13/30] libbpf: add BPF token support to bpf_map_create() API [v2,bpf-next,14/30] libbpf: add BPF token support to bpf_btf_load() API [v2,bpf-next,15/30] libbpf: add BPF token support to bpf_prog_load() API [v2,bpf-next,16/30] selftests/bpf: add BPF token-enabled tests [v2,bpf-next,17/30] bpf,selinux: allocate bpf_security_struct per BPF token [v2,bpf-next,18/30] bpf: fail BPF_TOKEN_CREATE if no delegation option was set on BPF FS [v2,bpf-next,19/30] bpf: support symbolic BPF FS delegation mount options [v2,bpf-next,20/30] selftests/bpf: utilize string values for delegate_xxx mount options [v2,bpf-next,21/30] libbpf: split feature detectors definitions from cached results [v2,bpf-next,22/30] libbpf: further decouple feature checking logic from bpf_object [v2,bpf-next,23/30] libbpf: move feature detection code into its own file [v2,bpf-next,24/30] libbpf: wire up token_fd into feature probing logic [v2,bpf-next,25/30] libbpf: wire up BPF token support at BPF object level [v2,bpf-next,26/30] selftests/bpf: add BPF object loading tests with explicit token passing [v2,bpf-next,27/30] selftests/bpf: add tests for BPF object load with implicit token [v2,bpf-next,28/30] libbpf: support BPF token path setting through LIBBPF_BPF_TOKEN_PATH envvar [v2,bpf-next,29/30] selftests/bpf: add tests for LIBBPF_BPF_TOKEN_PATH envvar [v2,bpf-next,30/30] selftests/bpf: incorporate LSM policy to token-based tests

[v2,bpf-next,03/30] bpf: introduce BPF token object

Commit Message

Patch