From patchwork Wed May 22 00:56:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Liaw X-Patchwork-Id: 13669969 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9283C8F6D for ; Wed, 22 May 2024 00:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716339573; cv=none; b=izOAP1gSfJhp5scLP4fm4uAIp0b0XnUl3y9PcEBC3WrwXceCmNrLBdZDP1yS56U2MzYFBcz2A8x3GNUArgGVIGv/KZTYZ6SHZw40vO/ItBHEq5Ak/Qr6dVjr320nctBA1BjcPY+XimKIH9PbqxJOSUZshscprhazDJ4UUTUb8NY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716339573; c=relaxed/simple; bh=x5mppV8WCT2sFoidaes26Q0BjcINGRNEO0wOAYpWIEM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=D5Gl0+AFWa0vn2pTs1mUNq8DrMc9cwS7ScMaU/231oGeX2+UNdpfHwj49Ax4XS3WLqhBzDsaAU2292Gs982C5LHg2wvlRq8xR/G9SZGaD+FC+cxY8grfnByu98Qh4FDIfOjlyjFKHmhD29hKcBo6UVWm3h8wb7c/JIpHpOl+Uis= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--edliaw.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=PqoHaPo2; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--edliaw.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PqoHaPo2" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6f467b9e948so10783532b3a.0 for ; Tue, 21 May 2024 17:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716339571; x=1716944371; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=heKXSaMRYcwqfGx66xXaJ0v1/7TXmPatEe8vgsf1Ibg=; b=PqoHaPo2oFkcy7lLtSyreTK4fnqP1HM/aNZJvCwL8hG+I/+C4y7/txY9TpwFRGIFHK 924PaH2dfP7PcbSslJIu/15uAVhU2y6t6vjR+aDwwr9JYgmVOuSlSLSlV6BvpkebQ/b3 3TFo41UDnURvryKGx8u0y/hsgWOKIERv7QCTJW/zqA+Da4IYb/g9nbPYYyDppvLqc2gM JswhbKfe0Nu6GpAk+1lscOHmugFpOhIMf1zDmRuSPcH9im9ylnkw/yGMReszwG4G8GSo 540TbtAmrIDlHfXRP+tDE/f8Dp+up6MuoRuhWVAkXemVNalJR3LALhqIUJeoLkMSV+0n 3b1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716339571; x=1716944371; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=heKXSaMRYcwqfGx66xXaJ0v1/7TXmPatEe8vgsf1Ibg=; b=iBlL56FlA7iZ1ZIDYUd0gr0rYv4xRIWbJH+zA8Z5D9GXOVzjoLN2X93WNlAdBZLL9l 4tnrh4wjBk1ru46g3E0WltGsnQnQo2bKPKmH7lsPnMBOgNbsvpp/KT5YveVpzKUraPZO XPGbyz9Ax6oNK3pNiHeWqCgH+7C/Vtfjxtk7c8PM9CH00wUyqk7AMzcpVcer2iXC4rxy uN+DPpUH2byndU2bA2Z9Lyt7qG8tiFvZ7WbSxyZLzDdN/BVV35FFfPFAMnUZCKbTPV+P HzPQqYMOm5Xzcatcrq/95CsbkJ08rykJvd9w7QPGK7+0LPlahqcfUB9LzIv0mmsTleK4 UeKQ== X-Forwarded-Encrypted: i=1; AJvYcCXYp+sr9tHYzk/+FfEL4nn+sjZBd2gzSd9/Co13pPYX4xB5K8omheUclhKL7VkIjdEKX11xTeu3HiWwqOyBW8nwJG6+CZL8fPqNmFu8Z04hS5WCkgeR X-Gm-Message-State: AOJu0YxYhEnaizXcA5oq5WLfPfM6L2X7cWrbZydYmiPsXPkNKtku7fSx jrPer1+K5dhjnYUkAC/05+RQLydUx2kwjL6iEBMMQdsQbFCXrVRyTjsibLFE3ugiyfo49Jxwes9 Gdg== X-Google-Smtp-Source: AGHT+IEobdompRA9RjJm2/dX+ug/Gh+Xw1AlGzUbj4XxipP2oWSmXIk82GLItQak2HzxiyPL3MdiyXobY5E= X-Received: from edliaw.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:305d]) (user=edliaw job=sendgmr) by 2002:a05:6a00:2d91:b0:6f4:9fc8:8cb0 with SMTP id d2e1a72fcca58-6f6d6504a94mr20246b3a.5.1716339570837; Tue, 21 May 2024 17:59:30 -0700 (PDT) Date: Wed, 22 May 2024 00:56:48 +0000 In-Reply-To: <20240522005913.3540131-1-edliaw@google.com> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240522005913.3540131-1-edliaw@google.com> X-Mailer: git-send-email 2.45.1.288.g0e0cd299f1-goog Message-ID: <20240522005913.3540131-3-edliaw@google.com> Subject: [PATCH v5 02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE From: Edward Liaw To: shuah@kernel.org, " =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= " , " =?utf-8?q?G?= =?utf-8?q?=C3=BCnther_Noack?= " , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Kees Cook , Andy Lutomirski , Will Drewry Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Edward Liaw , linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, Mark Brown From: Mark Brown Commit daef47b89efd0b7 ("selftests: Compile kselftest headers with -D_GNU_SOURCE") adds a static_assert() which means that things which would be warnings about undeclared functions get escalated into build failures. While we do actually want _GNU_SOURCE to be defined for users of kselftest_harness we haven't actually done that yet and this is causing widespread build breaks which were previously warnings about uses of asprintf() without prototypes, including causing other test programs in the same directory to fail to build. Since the build failures that are introduced cause additional issues due to make stopping builds early replace the static_assert() with a missing without making the error more severe than it already was. This will be moot once the issue is fixed properly but reduces the disruption while that happens. Signed-off-by: Mark Brown Reviewed-by: Kees Cook Signed-off-by: Edward Liaw --- tools/testing/selftests/kselftest_harness.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h index b634969cbb6f..8e53686b71cb 100644 --- a/tools/testing/selftests/kselftest_harness.h +++ b/tools/testing/selftests/kselftest_harness.h @@ -51,7 +51,7 @@ #define __KSELFTEST_HARNESS_H #ifndef _GNU_SOURCE -#define _GNU_SOURCE +#warning kselftest harness requires _GNU_SOURCE to be defined #endif #include #include