diff mbox series

[1/2] lsm: constify function parameters

Message ID 20241125105926.47141-2-cgoettsche@seltendoof.de (mailing list archive)
State New
Delegated to: Paul Moore
Headers show
Series [1/2] lsm: constify function parameters | expand

Commit Message

Christian Göttsche Nov. 25, 2024, 10:59 a.m. UTC 
From: Christian Göttsche <cgzones@googlemail.com>

The functions print_ipv4_addr() and print_ipv6_addr() are called with
string literals and do not modify these parameters internally.

Reported by clang:

    security/lsm_audit.c:324:7: warning: passing 'const char[6]' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
      324 |                                                 "laddr", "lport");
          |                                                 ^~~~~~~
    security/lsm_audit.c:183:27: note: passing argument to parameter 'name1' here
      183 |                                    __be16 port, char *name1, char *name2)
          |                                                       ^

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 security/lsm_audit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/security/lsm_audit.c b/security/lsm_audit.c
index 849e832719e2..f1fe99f2221d 100644
--- a/security/lsm_audit.c
+++ b/security/lsm_audit.c
@@ -171,7 +171,7 @@  int ipv6_skb_to_auditdata(struct sk_buff *skb,
 
 static inline void print_ipv6_addr(struct audit_buffer *ab,
 				   const struct in6_addr *addr, __be16 port,
-				   char *name1, char *name2)
+				   const char *name1, const char *name2)
 {
 	if (!ipv6_addr_any(addr))
 		audit_log_format(ab, " %s=%pI6c", name1, addr);
@@ -180,7 +180,7 @@  static inline void print_ipv6_addr(struct audit_buffer *ab,
 }
 
 static inline void print_ipv4_addr(struct audit_buffer *ab, __be32 addr,
-				   __be16 port, char *name1, char *name2)
+				   __be16 port, const char *name1, const char *name2)
 {
 	if (addr)
 		audit_log_format(ab, " %s=%pI4", name1, &addr);