| Message ID | 8483f2c2-626d-382f-3994-ee29daebff75@i-love.sakura.ne.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL] tomoyo fixes for 5.5 | expand |
On Mon, Dec 30, 2019 at 3:32 AM Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote: > > This is my first time for sending pull requests. It seems that most people > create a tag signed with GPG key but a few people send pull requests on > master branch without signing with GPG key. Did I follow necessary steps? I do require the gpg signed tag for non-kernel.org pull requests like this. I trust the security at kernel.org - it requires 2FA and a gpg key just to even push to a git repo there at all - but even there I _prefer_ tags. But outside of kernel.org I absolutely do want to see a signed tag for a pull request, not just a master branch. Side note: I don't actually require the pgp key to be something I have a direct path to, and if you can't get big set of signatures on yours, that's fine for initial pull requests. The key ends up still being a kind of identity, and we can work on getting the proper web of trust built up over time. Linus
On 2019/12/31 5:14, Linus Torvalds wrote: > On Mon, Dec 30, 2019 at 3:32 AM Tetsuo Handa > <penguin-kernel@i-love.sakura.ne.jp> wrote: >> >> This is my first time for sending pull requests. It seems that most people >> create a tag signed with GPG key but a few people send pull requests on >> master branch without signing with GPG key. Did I follow necessary steps? > > I do require the gpg signed tag for non-kernel.org pull requests like this. > > I trust the security at kernel.org - it requires 2FA and a gpg key > just to even push to a git repo there at all - but even there I > _prefer_ tags. But outside of kernel.org I absolutely do want to see a > signed tag for a pull request, not just a master branch. I see. I did the following and got a tag signed with my GPG key. Did I do what you want? $ git tag -s tomoyo-fixes-for-5.5 $ git push --tags $ git request-pull tomoyo-fixes-for-5.5 git://git.osdn.net/gitroot/tomoyo/tomoyo-test1.git The following changes since commit 6bd5ce6089b561f5392460bfb654dea89356ab1b: tomoyo: Suppress RCU warning at list_for_each_entry_rcu(). (2019-12-16 23:02:27 +0900) are available in the git repository at: git://git.osdn.net/gitroot/tomoyo/tomoyo-test1.git tags/tomoyo-fixes-for-5.5 for you to fetch changes up to 6bd5ce6089b561f5392460bfb654dea89356ab1b: tomoyo: Suppress RCU warning at list_for_each_entry_rcu(). (2019-12-16 23:02:27 +0900) ---------------------------------------------------------------- Two bugfix patches for 5.5. tomoyo: Suppress RCU warning at list_for_each_entry_rcu(). tomoyo: Don't use nifty names on sockets. ---------------------------------------------------------------- > > Side note: I don't actually require the pgp key to be something I have > a direct path to, and if you can't get big set of signatures on yours, > that's fine for initial pull requests. The key ends up still being a > kind of identity, and we can work on getting the proper web of trust > built up over time. > > Linus >
The pull request you sent on Mon, 30 Dec 2019 20:31:40 +0900:
> git://git.osdn.net/gitroot/tomoyo/tomoyo-test1.git master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/c5c928c667cd1e34cbcac6af5b7c2f9f4512d612
Thank you!
Hello Linus, This is my first time for sending pull requests. It seems that most people create a tag signed with GPG key but a few people send pull requests on master branch without signing with GPG key. Did I follow necessary steps? --- The following changes since commit 6794862a16ef41f753abd75c03a152836e4c8028: Merge tag 'for-5.5-rc1-kconfig-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux (2019-12-09 12:14:31 -0800) are available in the git repository at: git://git.osdn.net/gitroot/tomoyo/tomoyo-test1.git master for you to fetch changes up to 6bd5ce6089b561f5392460bfb654dea89356ab1b: tomoyo: Suppress RCU warning at list_for_each_entry_rcu(). (2019-12-16 23:02:27 +0900) ---------------------------------------------------------------- Tetsuo Handa (2): tomoyo: Don't use nifty names on sockets. tomoyo: Suppress RCU warning at list_for_each_entry_rcu(). security/tomoyo/common.c | 9 ++++++--- security/tomoyo/domain.c | 15 ++++++++++----- security/tomoyo/group.c | 9 ++++++--- security/tomoyo/realpath.c | 32 +------------------------------- security/tomoyo/util.c | 6 ++++-- 5 files changed, 27 insertions(+), 44 deletions(-)