From patchwork Wed Apr 5 21:53:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Casey Schaufler X-Patchwork-Id: 9665799 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 06AB8602B5 for ; Wed, 5 Apr 2017 21:53:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA8A828173 for ; Wed, 5 Apr 2017 21:53:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DC80F2856D; Wed, 5 Apr 2017 21:53:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6C78728173 for ; Wed, 5 Apr 2017 21:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933632AbdDEVxi (ORCPT ); Wed, 5 Apr 2017 17:53:38 -0400 Received: from nm18.bullet.mail.ne1.yahoo.com ([98.138.90.81]:45942 "EHLO nm18.bullet.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933475AbdDEVxi (ORCPT ); Wed, 5 Apr 2017 17:53:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1491429217; bh=xWIkdSo25XHn0JLpCgAKuS71XdLPfC7Ed8HocFvJcTY=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=CO9cexwKX9xEShvXAhs7NcgXwwhtiwpX5nFK2tTGBzdg5AQd8pFcf5exYQSLN6qSqH/jw0h0OtF0NWzoHvKr3OzaQXgFFkWGBsph9mestAqWrn5EatqfMvw1UqBqRhMWvFM81YAjgdVomAZlgXEGb5rUieRdozksUIWzUwk2PNEN0B/3U4EXaVGPVuzLCopTnPW9XS6Iydm4O9POlRQHm02Q2sw46mR1mEPoqYyZYd7djHGNxg77fyzolQ19MXecvpV6hFn98AYNyzX18KpJkGSvZSg9zV69Wk0tp/XwQvmdgDaCm4vjxOfLIAEHNE99yM6WhRRQRUWG577VLqIfHg== Received: from [98.138.100.111] by nm18.bullet.mail.ne1.yahoo.com with NNFMP; 05 Apr 2017 21:53:37 -0000 Received: from [98.138.226.126] by tm100.bullet.mail.ne1.yahoo.com with NNFMP; 05 Apr 2017 21:53:37 -0000 Received: from [127.0.0.1] by smtp205.mail.ne1.yahoo.com with NNFMP; 05 Apr 2017 21:53:37 -0000 X-Yahoo-Newman-Id: 656248.21016.bm@smtp205.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 1_aksZEVM1nao.hSWD_hKDGKFKOOQ9EulcodJBbdGtaWGOl W1j5fwTnyDUcDDNh247AkUJgBBGe0DKDf7LrigLEJnes55N.hKtv9fKdWqJd NTbKo4o2aPM7wx7eTdPTdO2DoRXHweSjolOp_8sUY_ekC3_xB8v62hN8DP_A kHMA9mV7zfjePReh.87uG3vohvx6snV2nPBNBPhufn6.vNQg386E8fqNQPWW WFmNlCkRL0vnkMI4gWhKXMxtC.0GW8Ch8dzna_DkG2irgFoSNszC_JHTWI8x q86xtmXIMTUuJI1fkQDfj4Jkp2Ugt1aP6foDtc1yPAb7XgQiBwDCgQSFHkTU 7TVY_kW1Uiim3GxbyGVX3cxmNNRNHChX.utdZditravv78e7oNslRvHFzEKk vzf99OMoB7_Z0u47Hhff_KCRanmakvRnkQJYLi3.kMrQmsZa7tIOkdvl85Ww co8p28pbGh3ji1AMwLl_TXtQTddiXHQiBG0WobOIXhLE.njD3plbebQ.P0do eBxBW46kRog_DWGJvimcu9dQQxv9e0UdF3hCaDkiCQYC2BYmUtRiwDe5gokc npqlUOoN2lQ-- X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- Subject: [PATCH RFC 06/11] Smack: remove socket blob free To: LSM , James Morris References: <509e0281-9f8a-83c2-f9d6-5532903cda46@schaufler-ca.com> Cc: John Johansen , Tetsuo Handa , Paul Moore , Stephen Smalley , Kees Cook , Casey Schaufler From: Casey Schaufler Message-ID: <8bedea9f-5a6c-7ff3-dda8-0ad7415dd39f@schaufler-ca.com> Date: Wed, 5 Apr 2017 14:53:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <509e0281-9f8a-83c2-f9d6-5532903cda46@schaufler-ca.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Subject: [PATCH RFC 06/11] Smack: remove socket blob free. With stacking in place the infrastructure releases the socket blob, so the module shouldn't. Signed-off-by: Casey Schaufler --- security/smack/smack_lsm.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 7c8ffe4..e1264b9 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -2272,7 +2272,6 @@ static void smack_sk_free_security(struct sock *sk) } rcu_read_unlock(); } - kfree(sk->sk_security); } #endif