From patchwork Thu Oct 24 11:28:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 11209049 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3078C1747 for ; Thu, 24 Oct 2019 11:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1819A20856 for ; Thu, 24 Oct 2019 11:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392305AbfJXL2h (ORCPT ); Thu, 24 Oct 2019 07:28:37 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:1820 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390184AbfJXL2h (ORCPT ); Thu, 24 Oct 2019 07:28:37 -0400 X-IronPort-AV: E=Sophos;i="5.68,224,1569276000"; d="scan'208";a="407955595" Received: from portablejulia.rsr.lip6.fr ([132.227.76.63]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 13:28:35 +0200 Date: Thu, 24 Oct 2019 13:28:35 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: Navid Emamdoost cc: john.johansen@canonical.com, emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu Subject: [PATCH] apparmor: fix odd_ptr_err.cocci warnings (fwd) Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Hello, The change suggested by Coccinelle is not correct, but the original code is not correct either because the argument to PTR_ERR should be a pointer, not an integer. julia ---------- Forwarded message ---------- Date: Thu, 24 Oct 2019 18:21:57 +0800 From: kbuild test robot To: kbuild@lists.01.org Cc: Julia Lawall Subject: [PATCH] apparmor: fix odd_ptr_err.cocci warnings CC: kbuild-all@lists.01.org In-Reply-To: <20191021152348.3906-1-navid.emamdoost@gmail.com> References: <20191021152348.3906-1-navid.emamdoost@gmail.com> TO: Navid Emamdoost From: kbuild test robot security/apparmor/audit.c:199:5-11: inconsistent IS_ERR and PTR_ERR on line 202. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 6f939f24599c ("apparmor: Fix use-after-free in aa_audit_rule_init") CC: Navid Emamdoost Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Navid-Emamdoost/apparmor-Fix-use-after-free-in-aa_audit_rule_init/20191024-123239 base: https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-testing :::::: branch date: 6 hours ago :::::: commit date: 6 hours ago Please take the patch only if it's a positive warning. Thanks! audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/security/apparmor/audit.c +++ b/security/apparmor/audit.c @@ -199,7 +199,7 @@ int aa_audit_rule_init(u32 field, u32 op if (IS_ERR(rule->label)) { int err = rule->label; aa_audit_rule_free(rule); - return PTR_ERR(err); + return PTR_ERR(rule->label); } *vrule = rule;