From patchwork Tue Jul 2 19:00:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 11028555 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8C2E4112C for ; Tue, 2 Jul 2019 19:00:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A7B427E71 for ; Tue, 2 Jul 2019 19:00:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5E3CB2842B; Tue, 2 Jul 2019 19:00:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E53327E71 for ; Tue, 2 Jul 2019 19:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbfGBTAs (ORCPT ); Tue, 2 Jul 2019 15:00:48 -0400 Received: from mout.web.de ([212.227.17.11]:35257 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbfGBTAs (ORCPT ); Tue, 2 Jul 2019 15:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1562094041; bh=E3pGj2dkiDZ6+glyTl7AWQYkPf1IakfUILl61N8Rv88=; h=X-UI-Sender-Class:To:Cc:From:Subject:Date; b=C601VR8Hi8PIlCpfgrtCjCTRKfGyRxJdzErAoDbrwZ0oFqTOxcKmJdP9P6N/Of9Y+ BrNi9GpaET/ilru8EB+Lz9f69rbJeNxCCNSrLv7i2PmZZHooGD4jAgaHzlCkGBd2qO +HkL1lQ0VqQwiL4eHik14pyUXJo7I6ncYai4+RrM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.48.11.114]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LZeZU-1iP6hQ2TYC-00lU3l; Tue, 02 Jul 2019 21:00:40 +0200 To: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Dmitry Kasatkin , James Morris , Mimi Zohar , "Serge E. Hallyn" Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Subject: [PATCH] ima: Replace two seq_printf() calls by seq_puts() in ima_show_template_data_ascii() Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Tue, 2 Jul 2019 21:00:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K1:W+irPRfYaDiM6s4DgUlbL87eLZ5kOn9hornFsfCsdVoDDuDdnVV rZNdklXdtiJz1QauxLaTaKLEcV24xIELOjUFMJzkVthFLpGwcfGLGx1gN3vK//XEauzyNPU vwh01qJKjdIT+Ko3L1DWM5pR4/m3N60xQF9fbBRHczLU+mCSU8t3/n1ZK+zfQBYscl2btPt tZLuYxlcaKRPP18OLcP8Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:jmbcbut9EVI=:k1I1FJ40YuUnkMYvzK0n+d eKoCaFBtpdyu+jBbrjsgmW60/4wi97TGE228691vpXEwLLyNCL/NynBvww+BU/ObwizR8VyGu HZJefYsaMmxf5p8HyKgi9azF4ZjNHwQBfcYrI48E0kFa9pGVsHMUWe/1WWtH1aB/6HPVCxIgm +5pGzjOZEL6KUevzRUWuFssSKCZt4/sIrYEpl3PjxXMA8DOBunCh+bO/OHrq4tDBd36NORzBP TNlGtcl67lbE+63kHXoOL40/WO+81NWHdLZyP4q+gLtwFJ9cDLyYon6BOT9AisnbfILvrT0p2 Ytcb8pRwkf4oQmcPPO0ncxa6QJbg1QjU5UgnOB8mvTfFAv0rB+qEFLYn7RJsk9nqS+3viqAwa 5SuV2dm8fxwKCFXLQAo+wVV3DdU0byWlpCXWUrRdSmXpfyrzlBPvuAYZ3oC9lDSqk3xs0rqiY TBTxtIz6/nF8wA0SPGMDC+3f3t5lVU93XkUW4LPMbeLDe6vWt1WvmWC13fVsXu3T6RoyAUN82 bPB6qFf8dcUBrmxzB8b612XeYoLB3zBGd/TFwnJ6jPkaRacjrScFVsDBDTr7nk/DrDEL29W6G J2h+nilmhF8QFVCLkMJSlQPjYGSkTKc2YP0qU28v9rQqWgNywagU8kDcwHXlp8FJKvevRJJuv q9R/5W/Vo/BvhAc8S8JazDvBzBzf2EtRmaz/ULoZUipuTxe1L/jc6FI+FAGu/NPeZ+0JBhHqF 9ZlzetvFPE7ZO9MVSRyPv62cCwloeloOOPR2v3w7RJU1wmi/4rOwDg2iX6fQpynWmOq7Cg0JV xENQVeKe+5eoiPP0ANvGnEnXf66YxW5iZNNr/8YoLiABmREZSeV2ehyCMJv7Ea+kqaeroc8Ne zSAfB1DZRFGQ32mSD4NEROQGCDAh+StxUQCleq2zlMTAhUA2Q860UwkekHFcGKQG7YlIPq0Vn ucioVc/TsWgV8j0ToE5SSqJmZMEHeS9+KLDbBk8rGLZKsNHKee9bH2gxi3OZ4wj2jRcy+Q0wK 9LvjaRFb3sSJVgpT2Hm4cGtRzKSyVMnzg5mj3sTeHgntrXrAW8m1JOi+yt+mtKxde2OzKAwXj P+9ABEEqhtBKv+f0b+ClzFeBsp09kkl6XYB Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 2 Jul 2019 20:52:21 +0200 Two strings which did not contain a data format specification should be put into a sequence. Thus use the corresponding function “seq_puts”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- security/integrity/ima/ima_template_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.22.0 diff --git a/security/integrity/ima/ima_template_lib.c b/security/integrity/ima/ima_template_lib.c index 9fe0ef7f91e2..05636e9b19b1 100644 --- a/security/integrity/ima/ima_template_lib.c +++ b/security/integrity/ima/ima_template_lib.c @@ -74,7 +74,7 @@ static void ima_show_template_data_ascii(struct seq_file *m, case DATA_FMT_DIGEST_WITH_ALGO: buf_ptr = strnchr(field_data->data, buflen, ':'); if (buf_ptr != field_data->data) - seq_printf(m, "%s", field_data->data); + seq_puts(m, field_data->data); /* skip ':' and '\0' */ buf_ptr += 2; @@ -87,7 +87,7 @@ static void ima_show_template_data_ascii(struct seq_file *m, ima_print_digest(m, buf_ptr, buflen); break; case DATA_FMT_STRING: - seq_printf(m, "%s", buf_ptr); + seq_puts(m, buf_ptr); break; default: break;