From patchwork Wed Nov 7 01:00:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10671689 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 06D0613A4 for ; Wed, 7 Nov 2018 01:04:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E01BA2AD57 for ; Wed, 7 Nov 2018 01:04:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2E492AFFE; Wed, 7 Nov 2018 01:04:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 209FA2ADAE for ; Wed, 7 Nov 2018 01:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388065AbeKGKcO (ORCPT ); Wed, 7 Nov 2018 05:32:14 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:39544 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387697AbeKGKcN (ORCPT ); Wed, 7 Nov 2018 05:32:13 -0500 Received: by mail-pl1-f194.google.com with SMTP id b5-v6so7050827pla.6 for ; Tue, 06 Nov 2018 17:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AdAdeS4sZQ8YU1vAJNV5eR8xeGN1ehQuodDt1kCsI6A=; b=W7j4p7n6cVnICxU3fNbrsRLIna/24le2c2DHgzKLMFf5CQnUYOE2mZUtt2Rw7cFgi6 K1v0NjXfenWwuPfGX4TL/6/Henxpcn35IpbF7yXLn6/NLFzfnwdGwXNL7gL4KSJTVfu4 3gwDRe5HZSKr3bULeqf4DdS9aSwrikmCeHVEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AdAdeS4sZQ8YU1vAJNV5eR8xeGN1ehQuodDt1kCsI6A=; b=ukl3SpJ/thAkyFDyQaXfEEnTcfGYmFqhd+1nkfq11q466eV9T9kJRLkelrZXysfcVB gydKbPaUZ86N7joKgB81LUjm2Vnnq3S26Hsx5/Q0B2xphrjP0Erjt45tMFQfCJCl5SLy mg/UP6JuxqpCc9buFjQQCmUMzbNrBHny2MYAQe5aq3+ZSS7WMQf5OuhsPaeWpoxUcTrZ k+lxBNaSdhm4sPsZIdT9ucLbeEk+ILHHH0zyadVndXcwUPBlghKE9oG+fNc/5EspLF6s Tbqmi2N9baRTge1q03QgwelP5+fwIPP4cgOWpBGtM1vcnBbA6vAEld0hVNK6DbJr2mZc n+pA== X-Gm-Message-State: AGRZ1gKSzG3PFGJFeBzGCywhHr4xD67Wrsi5NMPeUHRkQ1nCu15JqL1g d1XtFmSk7Id1KtqqqhDyW5nhFg== X-Google-Smtp-Source: AJdET5fgJULXvtUFPnFq52slokQNN7z81I0D9HZsdKxVHZdxgHrZEi4Cy7djJVVncN5rD1H9qJsdhA== X-Received: by 2002:a17:902:2:: with SMTP id 2-v6mr29324872pla.178.1541552652131; Tue, 06 Nov 2018 17:04:12 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id v37sm30134695pgn.5.2018.11.06.17.04.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 17:04:11 -0800 (PST) From: Douglas Anderson To: Jason Wessel , Daniel Thompson Cc: kgdb-bugreport@lists.sourceforge.net, Peter Zijlstra , Douglas Anderson , linux-mips@linux-mips.org, linux-sh@vger.kernel.org, Borislav Petkov , linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, Catalin Marinas , James Hogan , linux-hexagon@vger.kernel.org, x86@kernel.org, Vineet Gupta , Thomas Gleixner , Michal Hocko , Ralf Baechle , linux-snps-arc@lists.infradead.org, Andrew Morton , "H. Peter Anvin" , Yoshinori Sato , Benjamin Herrenschmidt , Will Deacon , Paul Burton , Ingo Molnar , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Huang Ying , "David S. Miller" , Rich Felker , Michael Ellerman , Mike Rapoport , Paul Mackerras , Richard Kuo , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v3 0/4] kgdb: Fix kgdb_roundup_cpus() Date: Tue, 6 Nov 2018 17:00:24 -0800 Message-Id: <20181107010028.184543-1-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.930.g4563a0d9d0-goog MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This series was originally part of the series ("serial: Finish kgdb on qcom_geni; fix many lockdep splats w/ kgdb") but it made sense to split it up. It's believed that dropping into kgdb should be more robust once these patches are applied. Changes in v3: - No separate init call. - Don't round up the CPU that is doing the rounding up. - Add "#ifdef CONFIG_SMP" to match the rest of the file. - Updated desc saying we don't solve the "failed to roundup" case. - Document the ignored parameter. - Patch #3 and #4 are new. Changes in v2: - Removing irq flags separated from fixing lockdep splat. - Removing irq flags separated from fixing lockdep splat. - Don't use smp_call_function (Daniel). Douglas Anderson (4): kgdb: Remove irq flags from roundup kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function() kgdb: Don't round up a CPU that failed rounding up before kdb: Don't back trace on a cpu that didn't round up arch/arc/kernel/kgdb.c | 10 ++----- arch/arm/kernel/kgdb.c | 12 --------- arch/arm64/kernel/kgdb.c | 12 --------- arch/hexagon/kernel/kgdb.c | 32 ---------------------- arch/mips/kernel/kgdb.c | 9 +------ arch/powerpc/kernel/kgdb.c | 6 ++--- arch/sh/kernel/kgdb.c | 12 --------- arch/sparc/kernel/smp_64.c | 2 +- arch/x86/kernel/kgdb.c | 9 ++----- include/linux/kgdb.h | 22 +++++++++------ kernel/debug/debug_core.c | 55 +++++++++++++++++++++++++++++++++++++- kernel/debug/debug_core.h | 1 + kernel/debug/kdb/kdb_bt.c | 11 +++++++- 13 files changed, 88 insertions(+), 105 deletions(-)