| Message ID | 1355225657-18731-1-git-send-email-phil.edworthy@renesas.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote: > The INDTx register addresses were wrong. > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> You can add Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> :-) > --- > v2: > Included SoB line this time - doh! > > arch/arm/mach-shmobile/pfc-r8a7779.c | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c > b/arch/arm/mach-shmobile/pfc-r8a7779.c index 15f6a48..717e058 100644 > --- a/arch/arm/mach-shmobile/pfc-r8a7779.c > +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c > @@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = > { }; > > static struct pinmux_data_reg pinmux_data_regs[] = { > - { PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } }, > - { PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } }, > - { PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } }, > - { PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } }, > - { PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } }, > - { PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } }, > - { PINMUX_DATA_REG("INDT6", 0xffc46008, 32) { > + { PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } }, > + { PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } }, > + { PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } }, > + { PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } }, > + { PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } }, > + { PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } }, > + { PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) { > 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, > 0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA, > GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
Hi Simon, Laurent, (resend as plain text) > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > To: Phil Edworthy <phil.edworthy@renesas.com>, > Cc: Simon <horms@verge.net.au>, linux-sh@vger.kernel.org, linux-arm- > kernel@lists.infradead.org, Magnus <magnus.damm@gmail.com>, Laurent > Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Date: 11/12/2012 11:39 > Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses > > On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote: > > The INDTx register addresses were wrong. > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > You can add > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Please scrap this patch. I just found out that it screws up the GPIO outputs. The current code assumes the same register is used for both input and output, which is not the case. It needs a bit of work to fix this. Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 12, 2012 at 10:12:27AM +0000, phil.edworthy@renesas.com wrote: > Hi Simon, Laurent, > > (resend as plain text) > > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > To: Phil Edworthy <phil.edworthy@renesas.com>, > > Cc: Simon <horms@verge.net.au>, linux-sh@vger.kernel.org, linux-arm- > > kernel@lists.infradead.org, Magnus <magnus.damm@gmail.com>, Laurent > > Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Date: 11/12/2012 11:39 > > Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg > addresses > > > > On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote: > > > The INDTx register addresses were wrong. > > > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> > > > > You can add > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Please scrap this patch. I just found out that it screws up the GPIO > outputs. The current code assumes the same register is used for both input > and output, which is not the case. It needs a bit of work to fix this. Thanks, I have marked v1 and v2 as Rejected in patchwork. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c b/arch/arm/mach-shmobile/pfc-r8a7779.c index 15f6a48..717e058 100644 --- a/arch/arm/mach-shmobile/pfc-r8a7779.c +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c @@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = { }; static struct pinmux_data_reg pinmux_data_regs[] = { - { PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } }, - { PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } }, - { PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } }, - { PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } }, - { PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } }, - { PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } }, - { PINMUX_DATA_REG("INDT6", 0xffc46008, 32) { + { PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } }, + { PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } }, + { PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } }, + { PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } }, + { PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } }, + { PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } }, + { PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA, GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
The INDTx register addresses were wrong. Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> --- v2: Included SoB line this time - doh! arch/arm/mach-shmobile/pfc-r8a7779.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)