From patchwork Wed May 29 08:48:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Hecht X-Patchwork-Id: 2628241 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 489AB3FC23 for ; Wed, 29 May 2013 08:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965144Ab3E2ItF (ORCPT ); Wed, 29 May 2013 04:49:05 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:63683 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965080Ab3E2ItB (ORCPT ); Wed, 29 May 2013 04:49:01 -0400 Received: by mail-bk0-f46.google.com with SMTP id my13so4758312bkb.33 for ; Wed, 29 May 2013 01:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=Z9h88nmT0j0XIzZw+XrzXJDj+2hZeyKebxTxwqiowj4=; b=PM91arHMMKkuQ/1wt02lZfWXU6stBbiANoOK5YZ1jPrYg7bPSPR+g8Oo0dcGjVhjGd 1NGMb68SsGW2HxY847ZpRThjf+neAm3i7jlaF2pXiH1xAyG4cagRhgYQ58+506gfWtXx MKcVWPEUKNtagtIx35hDRlZbwWaykLAEU6sthEyb8XXBL+9TeXMm5DgxPYhp602pKSGQ cQTAXXebifdcR/JMxQC7AXwhvdN0HflVuoK7n8C9CkqorhMXHTyTXxz0vRmHwxZmY3XE gdNuM/C4Exq6loW5VIiMjPsr/XF/kJijmvKuAKBJEgaZZHzbECm2pvsONiG2km/HcL6u fLXA== X-Received: by 10.204.109.200 with SMTP id k8mr521170bkp.82.1369817340012; Wed, 29 May 2013 01:49:00 -0700 (PDT) Received: from groucho.site (188-194-147-14-dynip.superkabel.de. [188.194.147.14]) by mx.google.com with ESMTPSA id cm9sm11423638bkb.4.2013.05.29.01.48.58 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 May 2013 01:48:59 -0700 (PDT) From: Ulrich Hecht To: linux-sh@vger.kernel.org, kuninori.morimoto.gx@renesas.com, magnus.damm@gmail.com Cc: Ulrich Hecht Subject: [PATCH] thermal: rcar: set up I/O base before requesting IRQ Date: Wed, 29 May 2013 10:48:56 +0200 Message-Id: <1369817336-1953-1-git-send-email-ulrich.hecht@gmail.com> X-Mailer: git-send-email 1.7.10.4 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org It is used by the interrupt handler. Fixes crash when booting via kexec on APE6 board. Signed-off-by: Ulrich Hecht Acked-by: Kuninori Morimoto --- drivers/thermal/rcar_thermal.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index 8d7edd4..7641dcc 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -395,13 +395,6 @@ static int rcar_thermal_probe(struct platform_device *pdev) return -ENODEV; } - ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0, - dev_name(dev), common); - if (ret) { - dev_err(dev, "irq request failed\n "); - return ret; - } - /* * rcar_has_irq_support() will be enabled */ @@ -409,6 +402,13 @@ static int rcar_thermal_probe(struct platform_device *pdev) if (IS_ERR(common->base)) return PTR_ERR(common->base); + ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0, + dev_name(dev), common); + if (ret) { + dev_err(dev, "irq request failed\n "); + return ret; + } + /* enable temperature comparation */ rcar_thermal_common_write(common, ENR, 0x00030303);