| Message ID | 1370015825-29383-6-git-send-email-ulrich.hecht@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Commit | 9b1b3666d7f0bfbc724913fed1ae1d86aee42be3 |
| Headers | show |
On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote: > These pins are not actually connected on the board, but at least they > don't conflict with anything else. I am holding off on queueing-up this patch pending a review of [PATCH v3 3/5] sh-pfc: r8a7790: add HSCIF pin groups > > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> > --- > arch/arm/mach-shmobile/board-lager.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c > index 1e99b17..d8bd237 100644 > --- a/arch/arm/mach-shmobile/board-lager.c > +++ b/arch/arm/mach-shmobile/board-lager.c > @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = { > /* SCIF1 (CN20: DEBUG SERIAL1) */ > PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790", > "scif1_data", "scif1"), > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790", > + "hscif0_data", "hscif0"), > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790", > + "hscif1_data_b", "hscif1"), > }; > > static void __init lager_add_standard_devices(void) > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote: > These pins are not actually connected on the board, but at least they > don't conflict with anything else. > > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> Thanks, I have queued this up in the pinmux branch. > --- > arch/arm/mach-shmobile/board-lager.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c > index 1e99b17..d8bd237 100644 > --- a/arch/arm/mach-shmobile/board-lager.c > +++ b/arch/arm/mach-shmobile/board-lager.c > @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = { > /* SCIF1 (CN20: DEBUG SERIAL1) */ > PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790", > "scif1_data", "scif1"), > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790", > + "hscif0_data", "hscif0"), > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790", > + "hscif1_data_b", "hscif1"), > }; > > static void __init lager_add_standard_devices(void) > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ulrich ans Simon, On Wednesday 12 June 2013 23:08:47 Simon Horman wrote: > On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote: > > These pins are not actually connected on the board, but at least they > > don't conflict with anything else. That's actually not true, the hscif0_data pins are used by the DU RGB output. If the HSCIF0 and HSCIF1 are not wired on the board I don't think they should be added to the pinctrl maps. Simon, should we revert this patch now or later when I'll submit DU patches for Lager ? > > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> > > Thanks, I have queued this up in the pinmux branch. > > > --- > > > > arch/arm/mach-shmobile/board-lager.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/mach-shmobile/board-lager.c > > b/arch/arm/mach-shmobile/board-lager.c index 1e99b17..d8bd237 100644 > > --- a/arch/arm/mach-shmobile/board-lager.c > > +++ b/arch/arm/mach-shmobile/board-lager.c > > @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = { > > > > /* SCIF1 (CN20: DEBUG SERIAL1) */ > > PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790", > > > > "scif1_data", "scif1"), > > > > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790", > > + "hscif0_data", "hscif0"), > > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790", > > + "hscif1_data_b", "hscif1"), > > > > }; > > > > static void __init lager_add_standard_devices(void)
On Fri, Jun 14, 2013 at 06:51:38PM +0200, Laurent Pinchart wrote: > Hi Ulrich ans Simon, > > On Wednesday 12 June 2013 23:08:47 Simon Horman wrote: > > On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote: > > > These pins are not actually connected on the board, but at least they > > > don't conflict with anything else. > > That's actually not true, the hscif0_data pins are used by the DU RGB output. > > If the HSCIF0 and HSCIF1 are not wired on the board I don't think they should > be added to the pinctrl maps. > > Simon, should we revert this patch now or later when I'll submit DU patches > for Lager ? I will simply drop this patch for now. I can pick it up again if you and Ulrich decide that is the best course of action. > > > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> > > > > Thanks, I have queued this up in the pinmux branch. > > > > > --- > > > > > > arch/arm/mach-shmobile/board-lager.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm/mach-shmobile/board-lager.c > > > b/arch/arm/mach-shmobile/board-lager.c index 1e99b17..d8bd237 100644 > > > --- a/arch/arm/mach-shmobile/board-lager.c > > > +++ b/arch/arm/mach-shmobile/board-lager.c > > > @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = { > > > > > > /* SCIF1 (CN20: DEBUG SERIAL1) */ > > > PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790", > > > > > > "scif1_data", "scif1"), > > > > > > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790", > > > + "hscif0_data", "hscif0"), > > > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790", > > > + "hscif1_data_b", "hscif1"), > > > > > > }; > > > > > > static void __init lager_add_standard_devices(void) > > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c index 1e99b17..d8bd237 100644 --- a/arch/arm/mach-shmobile/board-lager.c +++ b/arch/arm/mach-shmobile/board-lager.c @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = { /* SCIF1 (CN20: DEBUG SERIAL1) */ PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790", "scif1_data", "scif1"), + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790", + "hscif0_data", "hscif0"), + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790", + "hscif1_data_b", "hscif1"), }; static void __init lager_add_standard_devices(void)
These pins are not actually connected on the board, but at least they don't conflict with anything else. Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> --- arch/arm/mach-shmobile/board-lager.c | 4 ++++ 1 file changed, 4 insertions(+)