From patchwork Sun Jan 12 11:13:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 3471541 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 18AA99F2ED for ; Sun, 12 Jan 2014 11:14:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3F58920121 for ; Sun, 12 Jan 2014 11:14:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E1F9200DF for ; Sun, 12 Jan 2014 11:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbaALLOD (ORCPT ); Sun, 12 Jan 2014 06:14:03 -0500 Received: from jacques.telenet-ops.be ([195.130.132.50]:53953 "EHLO jacques.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbaALLNx (ORCPT ); Sun, 12 Jan 2014 06:13:53 -0500 Received: from ayla.of.borg ([84.193.72.141]) by jacques.telenet-ops.be with bizsmtp id CzDp1n00d32ts5g0JzDpUa; Sun, 12 Jan 2014 12:13:50 +0100 Received: from geert by ayla.of.borg with local (Exim 4.76) (envelope-from ) id 1W2IzF-0000ux-51; Sun, 12 Jan 2014 12:13:49 +0100 From: Geert Uytterhoeven To: Mark Brown , Simon Horman , Magnus Damm Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven Subject: [PATCH 1/9] spi: rspi: Add missing clk_disable() calls in error and cleanup paths Date: Sun, 12 Jan 2014 12:13:34 +0100 Message-Id: <1389525222-3482-2-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1389525222-3482-1-git-send-email-geert@linux-m68k.org> References: <1389525222-3482-1-git-send-email-geert@linux-m68k.org> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Geert Uytterhoeven Signed-off-by: Geert Uytterhoeven --- drivers/spi/spi-rspi.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c index 04d512e1e894..5ce2127b2b43 100644 --- a/drivers/spi/spi-rspi.c +++ b/drivers/spi/spi-rspi.c @@ -1066,6 +1066,7 @@ static int rspi_remove(struct platform_device *pdev) struct rspi_data *rspi = platform_get_drvdata(pdev); rspi_release_dma(rspi); + clk_disable(rspi->clk); return 0; } @@ -1135,7 +1136,7 @@ static int rspi_probe(struct platform_device *pdev) ret = ops->parse_platform_data(rspi, rspi_pd); if (ret < 0) { dev_err(&pdev->dev, "rspi invalid platform data.\n"); - goto error1; + goto error2; } for (i = 0; i < MAX_NUM_IRQ; i++) { @@ -1145,13 +1146,13 @@ static int rspi_probe(struct platform_device *pdev) break; dev_err(&pdev->dev, "platform_get_irq error\n"); ret = -ENODEV; - goto error1; + goto error2; } ret = devm_request_irq(&pdev->dev, irq, rspi_irq, 0, dev_name(&pdev->dev), rspi); if (ret < 0) { dev_err(&pdev->dev, "request_irq %d error\n", irq); - goto error1; + goto error2; } rspi->irqs[i] = irq; rspi->num_irqs++; @@ -1160,21 +1161,23 @@ static int rspi_probe(struct platform_device *pdev) ret = rspi_request_dma(rspi, pdev); if (ret < 0) { dev_err(&pdev->dev, "rspi_request_dma failed.\n"); - goto error2; + goto error3; } ret = devm_spi_register_master(&pdev->dev, master); if (ret < 0) { dev_err(&pdev->dev, "spi_register_master error.\n"); - goto error2; + goto error3; } dev_info(&pdev->dev, "probed\n"); return 0; -error2: +error3: rspi_release_dma(rspi); +error2: + clk_disable(rspi->clk); error1: spi_master_put(master);