| Message ID | 1393450621-5089-1-git-send-email-bcousson@baylibre.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Benoit, Thank you for the patch. On Wednesday 26 February 2014 22:37:01 Benoit Cousson wrote: > The Z clock frequency change is effective only after setting the kick > bit located in the FRQCRB register. > Without that, the CA15 CPUs clock rate will never change. > > Fix that by checking if the kick bit is cleared and enable it to make > the clock rate change effective. The bit is cleared automatically upon > completion. > > Note: The kick bit is used as well to change 3 other emulation clocks: > Debug Trace port clock (ZTR), Debug Trace bus clock (ZT), and Debug > clock (ZTRD2). It is not clear from the spec [1] if there > is any relation between the CPU clock rate and these emulation clocks. > Moreover, these clocks are probably supposed to be controled by an > external debugger / tracer like Lauterbach PowerTrace. > For all these reasons, the current implementation does not expose these > clock nodes and thus does not have to consider the multiple accesses > to the kick bit. > > Signed-off-by: Benoit Cousson <bcousson+renesas@baylibre.com> > Cc: Mike Turquette <mturquette@linaro.org> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > [1] R-Car-H2-v0.6-en.pdf - page 186 > --- > v2: Add more comments about worst case latency and fix some minors nits. > > --- > drivers/clk/shmobile/clk-rcar-gen2.c | 41 +++++++++++++++++++++++++++++++-- > 1 file changed, 39 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/shmobile/clk-rcar-gen2.c > b/drivers/clk/shmobile/clk-rcar-gen2.c index a59ec21..0246251 100644 > --- a/drivers/clk/shmobile/clk-rcar-gen2.c > +++ b/drivers/clk/shmobile/clk-rcar-gen2.c > @@ -26,6 +26,8 @@ struct rcar_gen2_cpg { > void __iomem *reg; > }; > > +#define CPG_FRQCRB 0x00000004 > +#define CPG_FRQCRB_KICK BIT(31) > #define CPG_SDCKCR 0x00000074 > #define CPG_PLL0CR 0x000000d8 > #define CPG_FRQCRC 0x000000e0 > @@ -45,6 +47,7 @@ struct rcar_gen2_cpg { > struct cpg_z_clk { > struct clk_hw hw; > void __iomem *reg; > + void __iomem *kick_reg; > }; > > #define to_z_clk(_hw) container_of(_hw, struct cpg_z_clk, hw) > @@ -83,17 +86,50 @@ static int cpg_z_clk_set_rate(struct clk_hw *hw, > unsigned long rate, { > struct cpg_z_clk *zclk = to_z_clk(hw); > unsigned int mult; > - u32 val; > + u32 val, kick; > + unsigned int i; > > mult = div_u64((u64)rate * 32, parent_rate); > mult = clamp(mult, 1U, 32U); > > + if (clk_readl(zclk->kick_reg) & CPG_FRQCRB_KICK) > + return -EBUSY; > + > val = clk_readl(zclk->reg); > val &= ~CPG_FRQCRC_ZFC_MASK; > val |= (32 - mult) << CPG_FRQCRC_ZFC_SHIFT; > clk_writel(val, zclk->reg); > > - return 0; > + /* > + * Set KICK bit in FRQCRB to update hardware setting and wait for > + * clock change completion. > + * > + * Note: The KICK bit is used as well to change the emulation clocks: > + * Debug Trace port (ZTR), Debug Trace bus (ZT) and Debug (ZTRD2). > + * Since the current implementation does not expose these clock nodes, > + * it does not protect the register access using a lock. Mike nicely explained that CCF will handle the locking for us in this case, so I think you can remove the note here (and from the commit message as well). Sorry for the false alarm. > + */ > + kick = clk_readl(zclk->kick_reg); > + kick |= CPG_FRQCRB_KICK; > + clk_writel(kick, zclk->kick_reg); > + > + /* > + * Note: There is no HW information about the worst case latency. > + * > + * Using experimental measurements, it seems that no more than > + * ~10 iterations are needed, independently of the CPU rate. > + * Since this value might be dependant of external xtal rate, pll1 > + * rate or even the other emulation clocks rate, use 1000 as a > + * "super" safe value. Thank you for testing this. It looks good to me. With the note about locking removed, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + */ > + for (i = 1000; i; i--) { > + if (clk_readl(zclk->kick_reg) & CPG_FRQCRB_KICK) > + cpu_relax(); > + else > + return 0; > + } > + > + return -ETIMEDOUT; > } > > static const struct clk_ops cpg_z_clk_ops = { > @@ -120,6 +156,7 @@ static struct clk * __init cpg_z_clk_register(struct > rcar_gen2_cpg *cpg) init.num_parents = 1; > > zclk->reg = cpg->reg + CPG_FRQCRC; > + zclk->kick_reg = cpg->reg + CPG_FRQCRB; > zclk->hw.init = &init; > > clk = clk_register(NULL, &zclk->hw);
Hi Laurent, On 26/02/2014 22:55, Laurent Pinchart wrote: > Hi Benoit, > > Thank you for the patch. > > On Wednesday 26 February 2014 22:37:01 Benoit Cousson wrote: >> The Z clock frequency change is effective only after setting the kick >> bit located in the FRQCRB register. >> Without that, the CA15 CPUs clock rate will never change. >> >> Fix that by checking if the kick bit is cleared and enable it to make >> the clock rate change effective. The bit is cleared automatically upon >> completion. >> >> Note: The kick bit is used as well to change 3 other emulation clocks: >> Debug Trace port clock (ZTR), Debug Trace bus clock (ZT), and Debug >> clock (ZTRD2). It is not clear from the spec [1] if there >> is any relation between the CPU clock rate and these emulation clocks. >> Moreover, these clocks are probably supposed to be controled by an >> external debugger / tracer like Lauterbach PowerTrace. >> For all these reasons, the current implementation does not expose these >> clock nodes and thus does not have to consider the multiple accesses >> to the kick bit. >> >> Signed-off-by: Benoit Cousson <bcousson+renesas@baylibre.com> >> Cc: Mike Turquette <mturquette@linaro.org> >> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> >> >> [1] R-Car-H2-v0.6-en.pdf - page 186 >> --- >> v2: Add more comments about worst case latency and fix some minors nits. >> >> --- >> drivers/clk/shmobile/clk-rcar-gen2.c | 41 +++++++++++++++++++++++++++++++-- >> 1 file changed, 39 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/shmobile/clk-rcar-gen2.c >> b/drivers/clk/shmobile/clk-rcar-gen2.c index a59ec21..0246251 100644 >> --- a/drivers/clk/shmobile/clk-rcar-gen2.c >> +++ b/drivers/clk/shmobile/clk-rcar-gen2.c >> @@ -26,6 +26,8 @@ struct rcar_gen2_cpg { >> void __iomem *reg; >> }; >> >> +#define CPG_FRQCRB 0x00000004 >> +#define CPG_FRQCRB_KICK BIT(31) >> #define CPG_SDCKCR 0x00000074 >> #define CPG_PLL0CR 0x000000d8 >> #define CPG_FRQCRC 0x000000e0 >> @@ -45,6 +47,7 @@ struct rcar_gen2_cpg { >> struct cpg_z_clk { >> struct clk_hw hw; >> void __iomem *reg; >> + void __iomem *kick_reg; >> }; >> >> #define to_z_clk(_hw) container_of(_hw, struct cpg_z_clk, hw) >> @@ -83,17 +86,50 @@ static int cpg_z_clk_set_rate(struct clk_hw *hw, >> unsigned long rate, { >> struct cpg_z_clk *zclk = to_z_clk(hw); >> unsigned int mult; >> - u32 val; >> + u32 val, kick; >> + unsigned int i; >> >> mult = div_u64((u64)rate * 32, parent_rate); >> mult = clamp(mult, 1U, 32U); >> >> + if (clk_readl(zclk->kick_reg) & CPG_FRQCRB_KICK) >> + return -EBUSY; >> + >> val = clk_readl(zclk->reg); >> val &= ~CPG_FRQCRC_ZFC_MASK; >> val |= (32 - mult) << CPG_FRQCRC_ZFC_SHIFT; >> clk_writel(val, zclk->reg); >> >> - return 0; >> + /* >> + * Set KICK bit in FRQCRB to update hardware setting and wait for >> + * clock change completion. >> + * >> + * Note: The KICK bit is used as well to change the emulation clocks: >> + * Debug Trace port (ZTR), Debug Trace bus (ZT) and Debug (ZTRD2). >> + * Since the current implementation does not expose these clock nodes, >> + * it does not protect the register access using a lock. > > Mike nicely explained that CCF will handle the locking for us in this case, so > I think you can remove the note here (and from the commit message as well). > Sorry for the false alarm. Yep, I saw that as well. CCF is so powerful, that it can even protect us for our own good :-) Well done Mike! >> + */ >> + kick = clk_readl(zclk->kick_reg); >> + kick |= CPG_FRQCRB_KICK; >> + clk_writel(kick, zclk->kick_reg); >> + >> + /* >> + * Note: There is no HW information about the worst case latency. >> + * >> + * Using experimental measurements, it seems that no more than >> + * ~10 iterations are needed, independently of the CPU rate. >> + * Since this value might be dependant of external xtal rate, pll1 >> + * rate or even the other emulation clocks rate, use 1000 as a >> + * "super" safe value. > > Thank you for testing this. It looks good to me. > > With the note about locking removed, OK, I'll remove that and repost. > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks for the review and the acked-by Laurent. Regards, Benoit
diff --git a/drivers/clk/shmobile/clk-rcar-gen2.c b/drivers/clk/shmobile/clk-rcar-gen2.c index a59ec21..0246251 100644 --- a/drivers/clk/shmobile/clk-rcar-gen2.c +++ b/drivers/clk/shmobile/clk-rcar-gen2.c @@ -26,6 +26,8 @@ struct rcar_gen2_cpg { void __iomem *reg; }; +#define CPG_FRQCRB 0x00000004 +#define CPG_FRQCRB_KICK BIT(31) #define CPG_SDCKCR 0x00000074 #define CPG_PLL0CR 0x000000d8 #define CPG_FRQCRC 0x000000e0 @@ -45,6 +47,7 @@ struct rcar_gen2_cpg { struct cpg_z_clk { struct clk_hw hw; void __iomem *reg; + void __iomem *kick_reg; }; #define to_z_clk(_hw) container_of(_hw, struct cpg_z_clk, hw) @@ -83,17 +86,50 @@ static int cpg_z_clk_set_rate(struct clk_hw *hw, unsigned long rate, { struct cpg_z_clk *zclk = to_z_clk(hw); unsigned int mult; - u32 val; + u32 val, kick; + unsigned int i; mult = div_u64((u64)rate * 32, parent_rate); mult = clamp(mult, 1U, 32U); + if (clk_readl(zclk->kick_reg) & CPG_FRQCRB_KICK) + return -EBUSY; + val = clk_readl(zclk->reg); val &= ~CPG_FRQCRC_ZFC_MASK; val |= (32 - mult) << CPG_FRQCRC_ZFC_SHIFT; clk_writel(val, zclk->reg); - return 0; + /* + * Set KICK bit in FRQCRB to update hardware setting and wait for + * clock change completion. + * + * Note: The KICK bit is used as well to change the emulation clocks: + * Debug Trace port (ZTR), Debug Trace bus (ZT) and Debug (ZTRD2). + * Since the current implementation does not expose these clock nodes, + * it does not protect the register access using a lock. + */ + kick = clk_readl(zclk->kick_reg); + kick |= CPG_FRQCRB_KICK; + clk_writel(kick, zclk->kick_reg); + + /* + * Note: There is no HW information about the worst case latency. + * + * Using experimental measurements, it seems that no more than + * ~10 iterations are needed, independently of the CPU rate. + * Since this value might be dependant of external xtal rate, pll1 + * rate or even the other emulation clocks rate, use 1000 as a + * "super" safe value. + */ + for (i = 1000; i; i--) { + if (clk_readl(zclk->kick_reg) & CPG_FRQCRB_KICK) + cpu_relax(); + else + return 0; + } + + return -ETIMEDOUT; } static const struct clk_ops cpg_z_clk_ops = { @@ -120,6 +156,7 @@ static struct clk * __init cpg_z_clk_register(struct rcar_gen2_cpg *cpg) init.num_parents = 1; zclk->reg = cpg->reg + CPG_FRQCRC; + zclk->kick_reg = cpg->reg + CPG_FRQCRB; zclk->hw.init = &init; clk = clk_register(NULL, &zclk->hw);
The Z clock frequency change is effective only after setting the kick bit located in the FRQCRB register. Without that, the CA15 CPUs clock rate will never change. Fix that by checking if the kick bit is cleared and enable it to make the clock rate change effective. The bit is cleared automatically upon completion. Note: The kick bit is used as well to change 3 other emulation clocks: Debug Trace port clock (ZTR), Debug Trace bus clock (ZT), and Debug clock (ZTRD2). It is not clear from the spec [1] if there is any relation between the CPU clock rate and these emulation clocks. Moreover, these clocks are probably supposed to be controled by an external debugger / tracer like Lauterbach PowerTrace. For all these reasons, the current implementation does not expose these clock nodes and thus does not have to consider the multiple accesses to the kick bit. Signed-off-by: Benoit Cousson <bcousson+renesas@baylibre.com> Cc: Mike Turquette <mturquette@linaro.org> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> [1] R-Car-H2-v0.6-en.pdf - page 186 --- v2: Add more comments about worst case latency and fix some minors nits. --- drivers/clk/shmobile/clk-rcar-gen2.c | 41 ++++++++++++++++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-)