| Message ID | 1396280300-7016-1-git-send-email-ulrich.hecht@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 584b23db5beb3bd3a3c0767248a4843cac848a58 |
| Headers | show |
On Mon, Mar 31, 2014 at 05:38:20PM +0200, Ulrich Hecht wrote: > This enables the Seiko real-time clock that is attached to a couple of > GPIO pins. Hi Ulrich, I am a little confused about i2c2 appearing below as the documentation that I have only seems to refer to the presence of i2c0 and i2c1. > > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> > --- > .../arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > index b79ea51..ac352ef 100644 > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > @@ -118,6 +118,16 @@ > }; > }; > > + i2c2: i2c@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "i2c-gpio"; > + gpios = <&pfc 208 GPIO_ACTIVE_HIGH /* sda */ > + &pfc 91 GPIO_ACTIVE_HIGH /* scl */ > + >; > + i2c-gpio,delay-us = <5>; > + }; > + > backlight { > compatible = "pwm-backlight"; > pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>; > @@ -178,6 +188,14 @@ > }; > }; > > +&i2c2 { > + status = "okay"; > + rtc@30 { > + compatible = "seiko,s35390a"; > + reg = <0x30>; > + }; > +}; > + > &pfc { > pinctrl-0 = <&scifa1_pins>; > pinctrl-names = "default"; > -- > 1.8.4.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi! On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote: > I am a little confused about i2c2 appearing below as > the documentation that I have only seems to refer to > the presence of i2c0 and i2c1. This thing doesn't use any of the SoC I2C controllers, it's just hooked up to two GPIO pins. The board docs don't give much detail, but I found the relevant info in the Android vendor kernel, which is where this "bus" is called i2c2. The name is arbitrary, though. CU Uli -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 3, 2014 at 10:30 AM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote: > On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote: >> I am a little confused about i2c2 appearing below as >> the documentation that I have only seems to refer to >> the presence of i2c0 and i2c1. > > This thing doesn't use any of the SoC I2C controllers, it's just > hooked up to two GPIO pins. The board docs don't give much detail, but > I found the relevant info in the Android vendor kernel, which is where > this "bus" is called i2c2. The name is arbitrary, though. Table 3.1 does mention "I2C2 (GPIO) For RTC only", and the docs also mention it's a s35390a. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
(cc devicetree) On Mon, Mar 31, 2014 at 5:38 PM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote: > This enables the Seiko real-time clock that is attached to a couple of > GPIO pins. > > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> > --- > .../arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > index b79ea51..ac352ef 100644 > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > @@ -118,6 +118,16 @@ > }; > }; > > + i2c2: i2c@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "i2c-gpio"; > + gpios = <&pfc 208 GPIO_ACTIVE_HIGH /* sda */ > + &pfc 91 GPIO_ACTIVE_HIGH /* scl */ > + >; > + i2c-gpio,delay-us = <5>; > + }; > + > backlight { > compatible = "pwm-backlight"; > pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>; > @@ -178,6 +188,14 @@ > }; > }; > > +&i2c2 { > + status = "okay"; > + rtc@30 { > + compatible = "seiko,s35390a"; I think this should be "sii,s35390a", for Seiko Instruments Inc. > + reg = <0x30>; > + }; > +}; > + > &pfc { > pinctrl-0 = <&scifa1_pins>; > pinctrl-names = "default"; > -- > 1.8.4.5 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 3, 2014 at 11:40 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, Apr 3, 2014 at 10:30 AM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote: >> On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote: >>> I am a little confused about i2c2 appearing below as >>> the documentation that I have only seems to refer to >>> the presence of i2c0 and i2c1. >> >> This thing doesn't use any of the SoC I2C controllers, it's just >> hooked up to two GPIO pins. The board docs don't give much detail, but >> I found the relevant info in the Android vendor kernel, which is where >> this "bus" is called i2c2. The name is arbitrary, though. > > Table 3.1 does mention "I2C2 (GPIO) For RTC only", and the docs also > mention it's a s35390a. And board-armadillo800eva.c also contains support for it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 04, 2014 at 12:06:12PM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 3, 2014 at 11:40 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > On Thu, Apr 3, 2014 at 10:30 AM, Ulrich Hecht <ulrich.hecht@gmail.com> wrote: > >> On Thu, Apr 3, 2014 at 2:11 AM, Simon Horman <horms@verge.net.au> wrote: > >>> I am a little confused about i2c2 appearing below as > >>> the documentation that I have only seems to refer to > >>> the presence of i2c0 and i2c1. > >> > >> This thing doesn't use any of the SoC I2C controllers, it's just > >> hooked up to two GPIO pins. The board docs don't give much detail, but > >> I found the relevant info in the Android vendor kernel, which is where > >> this "bus" is called i2c2. The name is arbitrary, though. > > > > Table 3.1 does mention "I2C2 (GPIO) For RTC only", and the docs also > > mention it's a s35390a. I think you may have a different version of the documentation to me. But in any case I trust the combined judgement of you and Ulrich. > And board-armadillo800eva.c also contains support for it. That I see :) I will queue up this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index b79ea51..ac352ef 100644 --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts @@ -118,6 +118,16 @@ }; }; + i2c2: i2c@2 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "i2c-gpio"; + gpios = <&pfc 208 GPIO_ACTIVE_HIGH /* sda */ + &pfc 91 GPIO_ACTIVE_HIGH /* scl */ + >; + i2c-gpio,delay-us = <5>; + }; + backlight { compatible = "pwm-backlight"; pwms = <&tpu 2 33333 PWM_POLARITY_INVERTED>; @@ -178,6 +188,14 @@ }; }; +&i2c2 { + status = "okay"; + rtc@30 { + compatible = "seiko,s35390a"; + reg = <0x30>; + }; +}; + &pfc { pinctrl-0 = <&scifa1_pins>; pinctrl-names = "default";
This enables the Seiko real-time clock that is attached to a couple of GPIO pins. Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com> --- .../arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)