From patchwork Thu May 1 23:18:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yinghai Lu X-Patchwork-Id: 4100711 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E788B9F169 for ; Thu, 1 May 2014 23:19:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 15E8320380 for ; Thu, 1 May 2014 23:19:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37FA22037F for ; Thu, 1 May 2014 23:19:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695AbaEAXTB (ORCPT ); Thu, 1 May 2014 19:19:01 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:29848 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752766AbaEAXTA (ORCPT ); Thu, 1 May 2014 19:19:00 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s41NIYV1026705 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 May 2014 23:18:35 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s41NIXtF012225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 May 2014 23:18:33 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s41NIXcj012213; Thu, 1 May 2014 23:18:33 GMT Received: from linux-siqj.site (/10.132.126.31) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 01 May 2014 16:18:32 -0700 From: Yinghai Lu To: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck Cc: linux-kernel@vger.kernel.org, Yinghai Lu , Simon Horman , Magnus Damm , linux-sh@vger.kernel.org Subject: [PATCH 2/8] sh, irq: Remove irq_reserve_irq calling Date: Thu, 1 May 2014 16:18:16 -0700 Message-Id: <1398986302-30455-3-git-send-email-yinghai@kernel.org> X-Mailer: git-send-email 1.8.4.5 In-Reply-To: <1398986302-30455-1-git-send-email-yinghai@kernel.org> References: <1398986302-30455-1-git-send-email-yinghai@kernel.org> X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP in sh calling path: register_intc_controller ==> irq_create_identity_mapping/irq_create_strict_mappins ==>irq_alloc_desc: it will set bits on allocate_irq ==> intc_register_irq ==> irq_reserve_irq: set bits again so we can kill this irq_reserve_irq calling. Signed-off-by: Yinghai Lu Cc: Simon Horman Cc: Magnus Damm Cc: linux-sh@vger.kernel.org Acked-by: Simon Horman --- drivers/sh/intc/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c index 8f32a13..05118f92 100644 --- a/drivers/sh/intc/core.c +++ b/drivers/sh/intc/core.c @@ -81,11 +81,8 @@ static void __init intc_register_irq(struct intc_desc *desc, unsigned long flags; /* - * Register the IRQ position with the global IRQ map, then insert - * it in to the radix tree. + * insert it in to the radix tree. */ - irq_reserve_irq(irq); - raw_spin_lock_irqsave(&intc_big_lock, flags); radix_tree_insert(&d->tree, enum_id, intc_irq_xlate_get(irq)); raw_spin_unlock_irqrestore(&intc_big_lock, flags);