| Message ID | 1412848985-29353-2-git-send-email-ykaneko0929@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Kaneko-san, Abe-san, On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > From: Kouei Abe <kouei.abe.cp@renesas.com> Thanks for your patches! > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > --- > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++---- > include/dt-bindings/clock/r8a7790-clock.h | 1 + > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 2380fd5..27c038c 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > clock-output-names = > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1", > - "vsp1-du0", "vsp1-rt", "vsp1-sy"; > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0", > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy"; Why is this clock called "pvrsrvkm"? The datasheet calls this clock "3DG". > --- a/include/dt-bindings/clock/r8a7790-clock.h > +++ b/include/dt-bindings/clock/r8a7790-clock.h > +#define R8A7790_CLK_PVRSRVKM 12 Likewise. My comments also apply to the corresponding patch for r8a7791. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote: > Hi Kaneko-san, Abe-san, > > On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > > From: Kouei Abe <kouei.abe.cp@renesas.com> > > Thanks for your patches! > > > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > --- > > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++---- > > include/dt-bindings/clock/r8a7790-clock.h | 1 + > > 2 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > > index 2380fd5..27c038c 100644 > > --- a/arch/arm/boot/dts/r8a7790.dtsi > > +++ b/arch/arm/boot/dts/r8a7790.dtsi > > > clock-output-names = > > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1", > > - "vsp1-du0", "vsp1-rt", "vsp1-sy"; > > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0", > > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy"; > > Why is this clock called "pvrsrvkm"? > The datasheet calls this clock "3DG". Good question. I am of two minds on how to handle this: 1. Simply change the name to 3dg (simple) 2. Seek clarification from Abe-san and his team Currently I am leaning to 1 as following the data-sheet feels like the right thing to do. Does anyone have an opinion on this? > > --- a/include/dt-bindings/clock/r8a7790-clock.h > > +++ b/include/dt-bindings/clock/r8a7790-clock.h > > > +#define R8A7790_CLK_PVRSRVKM 12 > > Likewise. > > My comments also apply to the corresponding patch for r8a7791. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, On Fri, Oct 10, 2014 at 3:26 AM, Simon Horman <horms@verge.net.au> wrote: > On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote: >> Hi Kaneko-san, Abe-san, >> >> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> > From: Kouei Abe <kouei.abe.cp@renesas.com> >> >> Thanks for your patches! >> >> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com> >> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> >> > --- >> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++---- >> > include/dt-bindings/clock/r8a7790-clock.h | 1 + >> > 2 files changed, 6 insertions(+), 4 deletions(-) >> > >> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi >> > index 2380fd5..27c038c 100644 >> > --- a/arch/arm/boot/dts/r8a7790.dtsi >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi >> >> > clock-output-names = >> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1", >> > - "vsp1-du0", "vsp1-rt", "vsp1-sy"; >> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0", >> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy"; >> >> Why is this clock called "pvrsrvkm"? >> The datasheet calls this clock "3DG". > > Good question. > > I am of two minds on how to handle this: > > 1. Simply change the name to 3dg (simple) > 2. Seek clarification from Abe-san and his team > > Currently I am leaning to 1 as following the data-sheet feels like > the right thing to do. > > Does anyone have an opinion on this? We are following the data sheet names everywhere else so I don't see why this should be any exception. So my opinion is aligned with yours - simply go with 1. above. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Oct 20, 2014 at 02:53:37AM +0200, Magnus Damm wrote: > Hi Simon, > > On Fri, Oct 10, 2014 at 3:26 AM, Simon Horman <horms@verge.net.au> wrote: > > On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote: > >> Hi Kaneko-san, Abe-san, > >> > >> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > >> > From: Kouei Abe <kouei.abe.cp@renesas.com> > >> > >> Thanks for your patches! > >> > >> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com> > >> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > >> > --- > >> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++---- > >> > include/dt-bindings/clock/r8a7790-clock.h | 1 + > >> > 2 files changed, 6 insertions(+), 4 deletions(-) > >> > > >> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > >> > index 2380fd5..27c038c 100644 > >> > --- a/arch/arm/boot/dts/r8a7790.dtsi > >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi > >> > >> > clock-output-names = > >> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1", > >> > - "vsp1-du0", "vsp1-rt", "vsp1-sy"; > >> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0", > >> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy"; > >> > >> Why is this clock called "pvrsrvkm"? > >> The datasheet calls this clock "3DG". > > > > Good question. > > > > I am of two minds on how to handle this: > > > > 1. Simply change the name to 3dg (simple) > > 2. Seek clarification from Abe-san and his team > > > > Currently I am leaning to 1 as following the data-sheet feels like > > the right thing to do. > > > > Does anyone have an opinion on this? > > We are following the data sheet names everywhere else so I don't see > why this should be any exception. So my opinion is aligned with yours > - simply go with 1. above. Thanks. Kaneko-san has done so. And I have queued up the patches. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Uytterhoeven-san, Magnus-san, Simon-san, Kaneko-san, On Mon, 20 Oct 2014 02:53:37 +0200, Magnus Damm <magnus.damm@gmail.com> wrote: | Hi Simon, | | On Fri, Oct 10, 2014 at 3:26 AM, Simon Horman <horms@verge.net.au> wrote: | > On Thu, Oct 09, 2014 at 02:27:07PM +0200, Geert Uytterhoeven wrote: | >> Hi Kaneko-san, Abe-san, | >> | >> On Thu, Oct 9, 2014 at 12:03 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: | >> > From: Kouei Abe <kouei.abe.cp@renesas.com> | >> | >> Thanks for your patches! | >> | >> > Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com> | >> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> | >> > --- | >> > arch/arm/boot/dts/r8a7790.dtsi | 9 +++++---- | >> > include/dt-bindings/clock/r8a7790-clock.h | 1 + | >> > 2 files changed, 6 insertions(+), 4 deletions(-) | >> > | >> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi | >> > index 2380fd5..27c038c 100644 | >> > --- a/arch/arm/boot/dts/r8a7790.dtsi | >> > +++ b/arch/arm/boot/dts/r8a7790.dtsi | >> | >> > clock-output-names = | >> > - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1", | >> > - "vsp1-du0", "vsp1-rt", "vsp1-sy"; | >> > + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0", | >> > + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy"; | >> | >> Why is this clock called "pvrsrvkm"? | >> The datasheet calls this clock "3DG". | > | > Good question. | > | > I am of two minds on how to handle this: | > | > 1. Simply change the name to 3dg (simple) | > 2. Seek clarification from Abe-san and his team | > | > Currently I am leaning to 1 as following the data-sheet feels like | > the right thing to do. | > | > Does anyone have an opinion on this? | | We are following the data sheet names everywhere else so I don't see | why this should be any exception. So my opinion is aligned with yours | - simply go with 1. above. | | Cheers, | | / magnus I confirmed that "pvrsrvkm" is 3DG driver's name. So, I will agree "Simply change the name to 3dg (simple)" plan. Kouei Abe -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 2380fd5..27c038c 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -938,18 +938,19 @@ mstp1_clks: mstp1_clks@e6150134 { compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0 0xe6150134 0 4>, <0 0xe6150038 0 4>; - clocks = <&m2_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>, + clocks = <&m2_clk>, <&p_clk>, <&zg_clk>, <&p_clk>, <&p_clk>, <&rclk_clk>, <&cp_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>, <&zs_clk>; #clock-cells = <1>; renesas,clock-indices = < - R8A7790_CLK_JPU R8A7790_CLK_TMU1 R8A7790_CLK_TMU3 R8A7790_CLK_TMU2 + R8A7790_CLK_JPU R8A7790_CLK_TMU1 R8A7790_CLK_PVRSRVKM + R8A7790_CLK_TMU3 R8A7790_CLK_TMU2 R8A7790_CLK_CMT0 R8A7790_CLK_TMU0 R8A7790_CLK_VSP1_DU1 R8A7790_CLK_VSP1_DU0 R8A7790_CLK_VSP1_R R8A7790_CLK_VSP1_S >; clock-output-names = - "jpu", "tmu1", "tmu3", "tmu2", "cmt0", "tmu0", "vsp1-du1", - "vsp1-du0", "vsp1-rt", "vsp1-sy"; + "jpu", "tmu1", "pvrsrvkm", "tmu3", "tmu2", "cmt0", "tmu0", + "vsp1-du1", "vsp1-du0", "vsp1-rt", "vsp1-sy"; }; mstp2_clks: mstp2_clks@e6150138 { compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks"; diff --git a/include/dt-bindings/clock/r8a7790-clock.h b/include/dt-bindings/clock/r8a7790-clock.h index 8ea7ab0..2d2f668 100644 --- a/include/dt-bindings/clock/r8a7790-clock.h +++ b/include/dt-bindings/clock/r8a7790-clock.h @@ -28,6 +28,7 @@ /* MSTP1 */ #define R8A7790_CLK_JPU 6 #define R8A7790_CLK_TMU1 11 +#define R8A7790_CLK_PVRSRVKM 12 #define R8A7790_CLK_TMU3 21 #define R8A7790_CLK_TMU2 22 #define R8A7790_CLK_CMT0 24