clk: shmobile: Add r8a7793 support

Commit Message

Yoshihiro Kaneko Dec. 8, 2014, 10:42 a.m. UTC

From: Hisashi Nakamura <[e-mail]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Signed-off-by: Hisashi Nakamura <[e-mail]>
Signed-off-by: Yoshihiro Kaneko <[e-mail]>
---

This patch is based on renesas/devel.

 drivers/clk/shmobile/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven Dec. 8, 2014, 11:13 a.m. UTC | #1

Hi Kaneko-san,

On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <[e-mail]> wrote:
> From: Hisashi Nakamura <[e-mail]>
>
> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

> Signed-off-by: Hisashi Nakamura <[e-mail]>
> Signed-off-by: Yoshihiro Kaneko <[e-mail]>

Acked-by: Geert Uytterhoeven <[e-mail]>

Can you please also send a patch to update the binding documentation in
Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

Thanks again!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yoshihiro Kaneko Dec. 8, 2014, 11:53 a.m. UTC | #2

Hi Geert-san,

2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[e-mail]>:
> Hi Kaneko-san,
>
> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <[e-mail]> wrote:
>> From: Hisashi Nakamura <[e-mail]>
>>
>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.
>
> Thanks for your patch!
>
>> Signed-off-by: Hisashi Nakamura <[e-mail]>
>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
>
> Acked-by: Geert Uytterhoeven <[e-mail]>
>
> Can you please also send a patch to update the binding documentation in
> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

This patch updates Makefile only, not added dtsi for r8a7793.
Is the update of the document necessary?

Thanks,
Kaneko

>
> Thanks again!
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Geert Uytterhoeven Dec. 8, 2014, 1:30 p.m. UTC | #3

Hi Kaneko-san,

On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <[e-mail]> wrote:
> 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[e-mail]>:
>> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <[e-mail]> wrote:
>>> From: Hisashi Nakamura <[e-mail]>
>>>
>>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.
>>
>> Thanks for your patch!
>>
>>> Signed-off-by: Hisashi Nakamura <[e-mail]>
>>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
>>
>> Acked-by: Geert Uytterhoeven <[e-mail]>
>>
>> Can you please also send a patch to update the binding documentation in
>> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?
>
> This patch updates Makefile only, not added dtsi for r8a7793.
> Is the update of the document necessary?

Not at this moment. I was just trying to be proactive ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Simon Horman Dec. 9, 2014, 12:23 a.m. UTC | #4

On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote:
> Hi Kaneko-san,
> 
> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <[e-mail]> wrote:
> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[e-mail]>:
> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <[e-mail]> wrote:
> >>> From: Hisashi Nakamura <[e-mail]>
> >>>
> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.
> >>
> >> Thanks for your patch!
> >>
> >>> Signed-off-by: Hisashi Nakamura <[e-mail]>
> >>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
> >>
> >> Acked-by: Geert Uytterhoeven <[e-mail]>
> >>
> >> Can you please also send a patch to update the binding documentation in
> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?
> >
> > This patch updates Makefile only, not added dtsi for r8a7793.
> > Is the update of the document necessary?
> 
> Not at this moment. I was just trying to be proactive ;-)

Kaneko-san,

I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a
one line change. I can prepare a patch if you prefer not to.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yoshihiro Kaneko Dec. 9, 2014, 12:26 p.m. UTC | #5

Hi Simon-san,

2014-12-09 9:23 GMT+09:00 Simon Horman <[e-mail]>:
> On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote:
>> Hi Kaneko-san,
>>
>> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <[e-mail]> wrote:
>> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[e-mail]>:
>> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <[e-mail]> wrote:
>> >>> From: Hisashi Nakamura <[e-mail]>
>> >>>
>> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.
>> >>
>> >> Thanks for your patch!
>> >>
>> >>> Signed-off-by: Hisashi Nakamura <[e-mail]>
>> >>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
>> >>
>> >> Acked-by: Geert Uytterhoeven <[e-mail]>
>> >>
>> >> Can you please also send a patch to update the binding documentation in
>> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?
>> >
>> > This patch updates Makefile only, not added dtsi for r8a7793.
>> > Is the update of the document necessary?
>>
>> Not at this moment. I was just trying to be proactive ;-)
>
> Kaneko-san,
>
> I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a
> one line change. I can prepare a patch if you prefer not to.

Yes, I know that the update is very small.
But "renesas,r8a7793-cpg-clocks" which will be added to the documentation
was not found anywhere in the source tree. For example,
"renesas,r8a7794-cpg-clocks"
is found in arch/arm/boot/dts/r8a7794.dtsi.
Is r8a7793.dtsi not necessary to update the document?
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Simon Horman Dec. 10, 2014, 12:18 a.m. UTC | #6

On Tue, Dec 09, 2014 at 09:26:09PM +0900, Yoshihiro Kaneko wrote:
> Hi Simon-san,
> 
> 2014-12-09 9:23 GMT+09:00 Simon Horman <[e-mail]>:
> > On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote:
> >> Hi Kaneko-san,
> >>
> >> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <[e-mail]> wrote:
> >> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[e-mail]>:
> >> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <[e-mail]> wrote:
> >> >>> From: Hisashi Nakamura <[e-mail]>
> >> >>>
> >> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.
> >> >>
> >> >> Thanks for your patch!
> >> >>
> >> >>> Signed-off-by: Hisashi Nakamura <[e-mail]>
> >> >>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
> >> >>
> >> >> Acked-by: Geert Uytterhoeven <[e-mail]>
> >> >>
> >> >> Can you please also send a patch to update the binding documentation in
> >> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?
> >> >
> >> > This patch updates Makefile only, not added dtsi for r8a7793.
> >> > Is the update of the document necessary?
> >>
> >> Not at this moment. I was just trying to be proactive ;-)
> >
> > Kaneko-san,
> >
> > I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a
> > one line change. I can prepare a patch if you prefer not to.
> 
> Yes, I know that the update is very small.
> But "renesas,r8a7793-cpg-clocks" which will be added to the documentation
> was not found anywhere in the source tree. For example,
> "renesas,r8a7794-cpg-clocks"
> is found in arch/arm/boot/dts/r8a7794.dtsi.
> Is r8a7793.dtsi not necessary to update the document?

In theory (though not always in practice) bindings should
be documented before they are used. So unless I misunderstand things,
yes, I think renesas,rcar-gen2-cpg-clocks.txt should be updated
even though arch/arm/boot/dts/r8a7794.dtsi is (not yet) updated.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yoshihiro Kaneko Dec. 10, 2014, 11:25 a.m. UTC | #7

2014-12-10 9:18 GMT+09:00 Simon Horman <[e-mail]>:
> On Tue, Dec 09, 2014 at 09:26:09PM +0900, Yoshihiro Kaneko wrote:
>> Hi Simon-san,
>>
>> 2014-12-09 9:23 GMT+09:00 Simon Horman <[e-mail]>:
>> > On Mon, Dec 08, 2014 at 02:30:14PM +0100, Geert Uytterhoeven wrote:
>> >> Hi Kaneko-san,
>> >>
>> >> On Mon, Dec 8, 2014 at 12:53 PM, Yoshihiro Kaneko <[e-mail]> wrote:
>> >> > 2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[e-mail]>:
>> >> >> On Mon, Dec 8, 2014 at 11:42 AM, Yoshihiro Kaneko <[e-mail]> wrote:
>> >> >>> From: Hisashi Nakamura <[e-mail]>
>> >> >>>
>> >> >>> R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.
>> >> >>
>> >> >> Thanks for your patch!
>> >> >>
>> >> >>> Signed-off-by: Hisashi Nakamura <[e-mail]>
>> >> >>> Signed-off-by: Yoshihiro Kaneko <[e-mail]>
>> >> >>
>> >> >> Acked-by: Geert Uytterhoeven <[e-mail]>
>> >> >>
>> >> >> Can you please also send a patch to update the binding documentation in
>> >> >> Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?
>> >> >
>> >> > This patch updates Makefile only, not added dtsi for r8a7793.
>> >> > Is the update of the document necessary?
>> >>
>> >> Not at this moment. I was just trying to be proactive ;-)
>> >
>> > Kaneko-san,
>> >
>> > I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a
>> > one line change. I can prepare a patch if you prefer not to.
>>
>> Yes, I know that the update is very small.
>> But "renesas,r8a7793-cpg-clocks" which will be added to the documentation
>> was not found anywhere in the source tree. For example,
>> "renesas,r8a7794-cpg-clocks"
>> is found in arch/arm/boot/dts/r8a7794.dtsi.
>> Is r8a7793.dtsi not necessary to update the document?
>
> In theory (though not always in practice) bindings should
> be documented before they are used. So unless I misunderstand things,
> yes, I think renesas,rcar-gen2-cpg-clocks.txt should be updated
> even though arch/arm/boot/dts/r8a7794.dtsi is (not yet) updated.

I got it. I can prepare a patch which updates the binding document.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/clk/shmobile/Makefile b/drivers/clk/shmobile/Makefile
index 960bf22..3cc716d 100644
--- a/drivers/clk/shmobile/Makefile
+++ b/drivers/clk/shmobile/Makefile
@@ -4,6 +4,7 @@  obj-$(CONFIG_ARCH_R8A7740)		+= clk-r8a7740.o
 obj-$(CONFIG_ARCH_R8A7779)		+= clk-r8a7779.o
 obj-$(CONFIG_ARCH_R8A7790)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_R8A7791)		+= clk-rcar-gen2.o
+obj-$(CONFIG_ARCH_R8A7793)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_R8A7794)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_SHMOBILE_MULTI)	+= clk-div6.o
 obj-$(CONFIG_ARCH_SHMOBILE_MULTI)	+= clk-mstp.o