diff mbox

ARM: shmobile: Select CONFIG_REGULATOR in defconfig once again

Message ID 1422239176-978-1-git-send-email-horms+renesas@verge.net.au (mailing list archive)
State Accepted
Commit 30aca3c84bd79b48154908b6c1592347f4df3d53
Delegated to: Simon Horman
Headers show

Commit Message

Simon Horman Jan. 26, 2015, 2:26 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

eb4513482d1c4882e3633528ccc48d77581b7bb1
(ARM: shmobile: Enable kzm9g board in multiplatform defconfig)
dropped CONFIG_REGULATOR from shmobile_defconfig as it was
generated using a tree where CONFIG_REGULATOR is indirectly
selected by ARCH_SH73A0.

ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen
changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig
in that release. This causes at least SDHI to stop working on
R-Car Gen2 SoCs.

Reported-by: Magnus Damm <damm+renesas@opensource.se>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[horms: minimal patch targeted as a fix]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Kuninori Morimoto Jan. 26, 2015, 2:31 a.m. UTC | #1 
Hi Simon

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> eb4513482d1c4882e3633528ccc48d77581b7bb1
> (ARM: shmobile: Enable kzm9g board in multiplatform defconfig)
> dropped CONFIG_REGULATOR from shmobile_defconfig as it was
> generated using a tree where CONFIG_REGULATOR is indirectly
> selected by ARCH_SH73A0.
> 
> ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen
> changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig
> in that release. This causes at least SDHI to stop working on
> R-Car Gen2 SoCs.
> 
> Reported-by: Magnus Damm <damm+renesas@opensource.se>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> [horms: minimal patch targeted as a fix]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/configs/shmobile_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 4f9868d..b553e2c 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
>  CONFIG_DA9063_WATCHDOG=y
>  CONFIG_MFD_AS3711=y
>  CONFIG_MFD_DA9063=y
> +CONFIG_REGULATOR=y
>  CONFIG_REGULATOR_AS3711=y
>  CONFIG_REGULATOR_DA9210=y
>  CONFIG_REGULATOR_GPIO=y

Oh.. Thank you for your help
(I have sent other question mail)
It looks good :)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Jan. 26, 2015, 3:59 a.m. UTC | #2 
On Mon, Jan 26, 2015 at 02:31:55AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > eb4513482d1c4882e3633528ccc48d77581b7bb1
> > (ARM: shmobile: Enable kzm9g board in multiplatform defconfig)
> > dropped CONFIG_REGULATOR from shmobile_defconfig as it was
> > generated using a tree where CONFIG_REGULATOR is indirectly
> > selected by ARCH_SH73A0.
> > 
> > ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen
> > changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig
> > in that release. This causes at least SDHI to stop working on
> > R-Car Gen2 SoCs.
> > 
> > Reported-by: Magnus Damm <damm+renesas@opensource.se>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > [horms: minimal patch targeted as a fix]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >  arch/arm/configs/shmobile_defconfig | 1 +
> >  1 file changed, 1 insertion(+)

For the record, this patch is based on
renesas-next-20150122-v3.19-rc1.

> > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> > index 4f9868d..b553e2c 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
> >  CONFIG_DA9063_WATCHDOG=y
> >  CONFIG_MFD_AS3711=y
> >  CONFIG_MFD_DA9063=y
> > +CONFIG_REGULATOR=y
> >  CONFIG_REGULATOR_AS3711=y
> >  CONFIG_REGULATOR_DA9210=y
> >  CONFIG_REGULATOR_GPIO=y
> 
> Oh.. Thank you for your help
> (I have sent other question mail)
> It looks good :)

Thanks. I have tried to address your questions in an answer to your
other email. Can you confirm me know if the above patch is ok for you or not.
I'd like to get this one right :)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto Jan. 26, 2015, 4:07 a.m. UTC | #3 
Hi Simon

> > > eb4513482d1c4882e3633528ccc48d77581b7bb1
> > > (ARM: shmobile: Enable kzm9g board in multiplatform defconfig)
> > > dropped CONFIG_REGULATOR from shmobile_defconfig as it was
> > > generated using a tree where CONFIG_REGULATOR is indirectly
> > > selected by ARCH_SH73A0.
> > > 
> > > ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen
> > > changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig
> > > in that release. This causes at least SDHI to stop working on
> > > R-Car Gen2 SoCs.
> > > 
> > > Reported-by: Magnus Damm <damm+renesas@opensource.se>
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > [horms: minimal patch targeted as a fix]
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > ---
> > >  arch/arm/configs/shmobile_defconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> 
> For the record, this patch is based on
> renesas-next-20150122-v3.19-rc1.

Thank you

> > > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> > > index 4f9868d..b553e2c 100644
> > > --- a/arch/arm/configs/shmobile_defconfig
> > > +++ b/arch/arm/configs/shmobile_defconfig
> > > @@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
> > >  CONFIG_DA9063_WATCHDOG=y
> > >  CONFIG_MFD_AS3711=y
> > >  CONFIG_MFD_DA9063=y
> > > +CONFIG_REGULATOR=y
> > >  CONFIG_REGULATOR_AS3711=y
> > >  CONFIG_REGULATOR_DA9210=y
> > >  CONFIG_REGULATOR_GPIO=y
> > 
> > Oh.. Thank you for your help
> > (I have sent other question mail)
> > It looks good :)
> 
> Thanks. I have tried to address your questions in an answer to your
> other email. Can you confirm me know if the above patch is ok for you or not.
> I'd like to get this one right :)

It OK in my quick check
Thank you

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Jan. 26, 2015, 8:47 a.m. UTC | #4 
On Mon, Jan 26, 2015 at 04:07:18AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > > eb4513482d1c4882e3633528ccc48d77581b7bb1
> > > > (ARM: shmobile: Enable kzm9g board in multiplatform defconfig)
> > > > dropped CONFIG_REGULATOR from shmobile_defconfig as it was
> > > > generated using a tree where CONFIG_REGULATOR is indirectly
> > > > selected by ARCH_SH73A0.
> > > > 
> > > > ARCH_SH73A0 is not queued up for v3.20 and thus, baring unforeseen
> > > > changes, CONFIG_REGULATOR will not be selected by shmobile_defconfig
> > > > in that release. This causes at least SDHI to stop working on
> > > > R-Car Gen2 SoCs.
> > > > 
> > > > Reported-by: Magnus Damm <damm+renesas@opensource.se>
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > [horms: minimal patch targeted as a fix]
> > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > > ---
> > > >  arch/arm/configs/shmobile_defconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > 
> > For the record, this patch is based on
> > renesas-next-20150122-v3.19-rc1.
> 
> Thank you
> 
> > > > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> > > > index 4f9868d..b553e2c 100644
> > > > --- a/arch/arm/configs/shmobile_defconfig
> > > > +++ b/arch/arm/configs/shmobile_defconfig
> > > > @@ -118,6 +118,7 @@ CONFIG_WATCHDOG=y
> > > >  CONFIG_DA9063_WATCHDOG=y
> > > >  CONFIG_MFD_AS3711=y
> > > >  CONFIG_MFD_DA9063=y
> > > > +CONFIG_REGULATOR=y
> > > >  CONFIG_REGULATOR_AS3711=y
> > > >  CONFIG_REGULATOR_DA9210=y
> > > >  CONFIG_REGULATOR_GPIO=y
> > > 
> > > Oh.. Thank you for your help
> > > (I have sent other question mail)
> > > It looks good :)
> > 
> > Thanks. I have tried to address your questions in an answer to your
> > other email. Can you confirm me know if the above patch is ok for you or not.
> > I'd like to get this one right :)
> 
> It OK in my quick check
> Thank you

Thanks, I have queued this up as a fix for v3.20
and pushed it as part of renesas-next-20150126-v3.19-rc1.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 4f9868d..b553e2c 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -118,6 +118,7 @@  CONFIG_WATCHDOG=y
 CONFIG_DA9063_WATCHDOG=y
 CONFIG_MFD_AS3711=y
 CONFIG_MFD_DA9063=y
+CONFIG_REGULATOR=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_DA9210=y
 CONFIG_REGULATOR_GPIO=y