diff mbox

ARM: shmobile: ape6evm dts: Fix polarity of LEDs

Message ID 1424947589-8303-1-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit ca50ee8f6f7c25d3de7d5da4e7a164e21f08c828
Headers show

Commit Message

Geert Uytterhoeven Feb. 26, 2015, 10:46 a.m. UTC
While the LEDs on r8a73a4/ape6evm are tied to VSUPPLY, they're driven by
an N-channel MOSFET. Hence the GPIO signal should be active high.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a73a4-ape6evm.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Simon Horman Feb. 27, 2015, 1:49 a.m. UTC | #1
On Thu, Feb 26, 2015 at 11:46:29AM +0100, Geert Uytterhoeven wrote:
> While the LEDs on r8a73a4/ape6evm are tied to VSUPPLY, they're driven by
> an N-channel MOSFET. Hence the GPIO signal should be active high.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm/boot/dts/r8a73a4-ape6evm.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Thanks, I have queued this up.

> diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> index f9e81512201a2ec4..b355fafc32f188dc 100644
> --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> @@ -75,27 +75,27 @@
>  	leds {
>  		compatible = "gpio-leds";
>  		led1 {
> -			gpios = <&pfc 28 GPIO_ACTIVE_LOW>;
> +			gpios = <&pfc 28 GPIO_ACTIVE_HIGH>;
>  			label = "GNSS_EN";
>  		};
>  		led2 {
> -			gpios = <&pfc 126 GPIO_ACTIVE_LOW>;
> +			gpios = <&pfc 126 GPIO_ACTIVE_HIGH>;
>  			label = "NFC_NRST";
>  		};
>  		led3 {
> -			gpios = <&pfc 132 GPIO_ACTIVE_LOW>;
> +			gpios = <&pfc 132 GPIO_ACTIVE_HIGH>;
>  			label = "GNSS_NRST";
>  		};
>  		led4 {
> -			gpios = <&pfc 232 GPIO_ACTIVE_LOW>;
> +			gpios = <&pfc 232 GPIO_ACTIVE_HIGH>;
>  			label = "BT_WAKEUP";
>  		};
>  		led5 {
> -			gpios = <&pfc 250 GPIO_ACTIVE_LOW>;
> +			gpios = <&pfc 250 GPIO_ACTIVE_HIGH>;
>  			label = "STROBE";
>  		};
>  		led6 {
> -			gpios = <&pfc 288 GPIO_ACTIVE_LOW>;
> +			gpios = <&pfc 288 GPIO_ACTIVE_HIGH>;
>  			label = "BBRESETOUT";
>  		};
>  	};
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
index f9e81512201a2ec4..b355fafc32f188dc 100644
--- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
+++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
@@ -75,27 +75,27 @@ 
 	leds {
 		compatible = "gpio-leds";
 		led1 {
-			gpios = <&pfc 28 GPIO_ACTIVE_LOW>;
+			gpios = <&pfc 28 GPIO_ACTIVE_HIGH>;
 			label = "GNSS_EN";
 		};
 		led2 {
-			gpios = <&pfc 126 GPIO_ACTIVE_LOW>;
+			gpios = <&pfc 126 GPIO_ACTIVE_HIGH>;
 			label = "NFC_NRST";
 		};
 		led3 {
-			gpios = <&pfc 132 GPIO_ACTIVE_LOW>;
+			gpios = <&pfc 132 GPIO_ACTIVE_HIGH>;
 			label = "GNSS_NRST";
 		};
 		led4 {
-			gpios = <&pfc 232 GPIO_ACTIVE_LOW>;
+			gpios = <&pfc 232 GPIO_ACTIVE_HIGH>;
 			label = "BT_WAKEUP";
 		};
 		led5 {
-			gpios = <&pfc 250 GPIO_ACTIVE_LOW>;
+			gpios = <&pfc 250 GPIO_ACTIVE_HIGH>;
 			label = "STROBE";
 		};
 		led6 {
-			gpios = <&pfc 288 GPIO_ACTIVE_LOW>;
+			gpios = <&pfc 288 GPIO_ACTIVE_HIGH>;
 			label = "BBRESETOUT";
 		};
 	};