| Message ID | 1445847155-5468-2-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > This patch fixes the hcd private size to sutabile size. ^^^^^^^^ suitable > The previous code has "sizeof(struct xhci_hcd *)" in xhci_hc_driver > as hcd_priv_size and sizeof(struct xhci_hcd) in xhci_plat_overrides > or xhci_pci_overrides as extra_priv_size. However, the xhci driver > uses a "sizeof(struct xhcd_hcd)" memory space in each hcd > (main_hcd and shared_hcd) actually. Nothing against the patch itself, but you're describing what exactly you're fixing. Did you find a bug because of this or is this basically a cleanup ? Your subject says you're "fixing" hcd private size, but I don't how this could be fixing anything. Care to explain ?
Hi, > From: Felipe Balbi [mailto:balbi@ti.com] > Sent: Monday, October 26, 2015 11:27 PM > > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > > This patch fixes the hcd private size to sutabile size. > ^^^^^^^^ > suitable Oops, Thank you for the point. > > The previous code has "sizeof(struct xhci_hcd *)" in xhci_hc_driver > > as hcd_priv_size and sizeof(struct xhci_hcd) in xhci_plat_overrides > > or xhci_pci_overrides as extra_priv_size. However, the xhci driver > > uses a "sizeof(struct xhcd_hcd)" memory space in each hcd > > (main_hcd and shared_hcd) actually. > > Nothing against the patch itself, but you're describing what exactly > you're fixing. Did you find a bug because of this or is this basically a > cleanup ? Your subject says you're "fixing" hcd private size, but I > don't how this could be fixing anything. Care to explain ? My description is wrong. This is basically a cleanup. I don't find any bugs. So, I will fix this subject and description in v4. Best regards, Yoshihiro Shimoda > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: > Hi, > >> From: Felipe Balbi [mailto:balbi@ti.com] >> Sent: Monday, October 26, 2015 11:27 PM >> >> Hi, >> >> Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes: >> > This patch fixes the hcd private size to sutabile size. >> ^^^^^^^^ >> suitable > > Oops, Thank you for the point. > >> > The previous code has "sizeof(struct xhci_hcd *)" in xhci_hc_driver >> > as hcd_priv_size and sizeof(struct xhci_hcd) in xhci_plat_overrides >> > or xhci_pci_overrides as extra_priv_size. However, the xhci driver >> > uses a "sizeof(struct xhcd_hcd)" memory space in each hcd >> > (main_hcd and shared_hcd) actually. >> >> Nothing against the patch itself, but you're describing what exactly >> you're fixing. Did you find a bug because of this or is this basically a >> cleanup ? Your subject says you're "fixing" hcd private size, but I >> don't how this could be fixing anything. Care to explain ? > > My description is wrong. This is basically a cleanup. I don't find any bugs. > So, I will fix this subject and description in v4. thank you :-)
On 26.10.2015 10:12, Yoshihiro Shimoda wrote: > This patch fixes the hcd private size to sutabile size. > The previous code has "sizeof(struct xhci_hcd *)" in xhci_hc_driver > as hcd_priv_size and sizeof(struct xhci_hcd) in xhci_plat_overrides > or xhci_pci_overrides as extra_priv_size. However, the xhci driver > uses a "sizeof(struct xhcd_hcd)" memory space in each hcd > (main_hcd and shared_hcd) actually. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/usb/host/xhci-pci.c | 1 - > drivers/usb/host/xhci-plat.c | 1 - > drivers/usb/host/xhci.c | 2 +- > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index 17f6897..b51ac63 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -53,7 +53,6 @@ static struct hc_driver __read_mostly xhci_pci_hc_driver; > static int xhci_pci_setup(struct usb_hcd *hcd); > > static const struct xhci_driver_overrides xhci_pci_overrides __initconst = { > - .extra_priv_size = sizeof(struct xhci_hcd), > .reset = xhci_pci_setup, > }; > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index 05647e6..4699c1e 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -31,7 +31,6 @@ static int xhci_plat_setup(struct usb_hcd *hcd); > static int xhci_plat_start(struct usb_hcd *hcd); > > static const struct xhci_driver_overrides xhci_plat_overrides __initconst = { > - .extra_priv_size = sizeof(struct xhci_hcd), > .reset = xhci_plat_setup, > .start = xhci_plat_start, > }; > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 6e7dc6f..c295785 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -4942,7 +4942,7 @@ EXPORT_SYMBOL_GPL(xhci_gen_setup); > static const struct hc_driver xhci_hc_driver = { > .description = "xhci-hcd", > .product_desc = "xHCI Host Controller", > - .hcd_priv_size = sizeof(struct xhci_hcd *), > + .hcd_priv_size = sizeof(struct xhci_hcd), > > /* > * generic hardware linkage > Seems that when changing from storing a xhci_hcd pointer to storing the whole xhci_hcd structure in hcd->hcd_priv we accidentally left the extra sizeof(struct xhci_hcd *) in the .hcd_priv_size Also setting the .hcd_priv_size = sizeof(struct xhci_hcd) when creating struct hc_driver xhci_hc_driver, instead of in the .extra_priv_size seems like the correct way to do it. Thanks for the fixes -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 17f6897..b51ac63 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -53,7 +53,6 @@ static struct hc_driver __read_mostly xhci_pci_hc_driver; static int xhci_pci_setup(struct usb_hcd *hcd); static const struct xhci_driver_overrides xhci_pci_overrides __initconst = { - .extra_priv_size = sizeof(struct xhci_hcd), .reset = xhci_pci_setup, }; diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 05647e6..4699c1e 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -31,7 +31,6 @@ static int xhci_plat_setup(struct usb_hcd *hcd); static int xhci_plat_start(struct usb_hcd *hcd); static const struct xhci_driver_overrides xhci_plat_overrides __initconst = { - .extra_priv_size = sizeof(struct xhci_hcd), .reset = xhci_plat_setup, .start = xhci_plat_start, }; diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 6e7dc6f..c295785 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -4942,7 +4942,7 @@ EXPORT_SYMBOL_GPL(xhci_gen_setup); static const struct hc_driver xhci_hc_driver = { .description = "xhci-hcd", .product_desc = "xHCI Host Controller", - .hcd_priv_size = sizeof(struct xhci_hcd *), + .hcd_priv_size = sizeof(struct xhci_hcd), /* * generic hardware linkage
This patch fixes the hcd private size to sutabile size. The previous code has "sizeof(struct xhci_hcd *)" in xhci_hc_driver as hcd_priv_size and sizeof(struct xhci_hcd) in xhci_plat_overrides or xhci_pci_overrides as extra_priv_size. However, the xhci driver uses a "sizeof(struct xhcd_hcd)" memory space in each hcd (main_hcd and shared_hcd) actually. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/host/xhci-pci.c | 1 - drivers/usb/host/xhci-plat.c | 1 - drivers/usb/host/xhci.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-)