From patchwork Mon Nov 2 01:40:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 7532891 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6031FBEEA4 for ; Mon, 2 Nov 2015 01:40:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 83A3820562 for ; Mon, 2 Nov 2015 01:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0890B20573 for ; Mon, 2 Nov 2015 01:40:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751123AbbKBBkg (ORCPT ); Sun, 1 Nov 2015 20:40:36 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:51547 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbbKBBk1 (ORCPT ); Sun, 1 Nov 2015 20:40:27 -0500 Received: from reginn.isobedori.kobe.vergenet.net (p2250-ipbfp1101kobeminato.hyogo.ocn.ne.jp [122.22.210.250]) by kirsty.vergenet.net (Postfix) with ESMTPA id 29E0C25B79F; Mon, 2 Nov 2015 12:40:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1446428425; bh=N4Jsu4NAL1twbn1ixsQt/gG89VpB+xQED9rHwwXbS4A=; h=From:To:Cc:Subject:Date:From; b=kmfm3kuql0GRBGGoADWHYgLQpLT1TFE2IaDRo+cp+1odEoT0qZih6b22+U9tavikQ dCPO6oWPcTCG+5e7M+WEVcvHvhn4vF4d/DhiZO54noxWXPhoQODtLwLN5wxDLR0E2h a5aADfCZUtkEXC15oKsxzR0LUzeaJMvwdYB7dntE= Received: by reginn.isobedori.kobe.vergenet.net (Postfix, from userid 7100) id DBA2C9403CB; Mon, 2 Nov 2015 10:40:21 +0900 (JST) From: Simon Horman To: David Miller , netdev@vger.kernel.org, linux-sh@vger.kernel.org Cc: Magnus Damm Subject: [PATCH net-next] ravb: use pdev rather than ndev for error messages Date: Mon, 2 Nov 2015 10:40:17 +0900 Message-Id: <1446428417-10895-1-git-send-email-horms+renesas@verge.net.au> X-Mailer: git-send-email 2.1.4 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This corrects what appear to be typos, making the code consistent with itself, and allowing meaningful prefixes to be displayed with the errors in question. Before: (null): failed to initialize MDIO (null): Cannot allocate desc base address table (size 176 bytes) After: ravb e6800000.ethernet: failed to initialize MDIO ravb e6800000.ethernet: Cannot allocate desc base address table (size 176 bytes) Signed-off-by: Simon Horman --- Tested using an r8a7795/Salvatore-X on the topic/gen3-latest branch of Geert Uytterhoeven's renesas-drivers tree on kernel.org: 3f5a88be9fea ("[WIP] arm64: renesas: r8a7795: Convert to new CPG/MSSR bindings") --- drivers/net/ethernet/renesas/ravb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index af52c88b8b8f..2f345da1cc66 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1798,7 +1798,7 @@ static int ravb_probe(struct platform_device *pdev) priv->desc_bat = dma_alloc_coherent(ndev->dev.parent, priv->desc_bat_size, &priv->desc_bat_dma, GFP_KERNEL); if (!priv->desc_bat) { - dev_err(&ndev->dev, + dev_err(&pdev->dev, "Cannot allocate desc base address table (size %d bytes)\n", priv->desc_bat_size); error = -ENOMEM; @@ -1825,7 +1825,7 @@ static int ravb_probe(struct platform_device *pdev) /* MDIO bus init */ error = ravb_mdio_init(priv); if (error) { - dev_err(&ndev->dev, "failed to initialize MDIO\n"); + dev_err(&pdev->dev, "failed to initialize MDIO\n"); goto out_dma_free; }