Message ID | 1446485499-26733-2-git-send-email-phil.edworthy@renesas.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Geert Uytterhoeven |
Headers | show |
Hi Phil, On Mon, Nov 2, 2015 at 6:31 PM, Phil Edworthy <phil.edworthy@renesas.com> wrote: > --- a/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c > +++ b/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c > @@ -120,6 +120,8 @@ static const struct mssr_mod_clk r8a7795_mod_clks[] __initconst = { > { "sys-dmac1", 218, R8A7795_CLK_S3D1 }, > { "sys-dmac0", 219, R8A7795_CLK_S3D1 }, > { "scif2", 310, R8A7795_CLK_S3D4 }, > + { "pcie0", 318, R8A7795_CLK_S3D1 }, "pcie1" > + { "pcie1", 319, R8A7795_CLK_S3D1 }, "pcie0" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert, On 03 November 2015 07:49, Geert wrote: > On Mon, Nov 2, 2015 at 6:31 PM, Phil Edworthy <phil.edworthy@renesas.com> > wrote: > > --- a/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c > > +++ b/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c > > @@ -120,6 +120,8 @@ static const struct mssr_mod_clk r8a7795_mod_clks[] > __initconst = { > > { "sys-dmac1", 218, R8A7795_CLK_S3D1 }, > > { "sys-dmac0", 219, R8A7795_CLK_S3D1 }, > > { "scif2", 310, R8A7795_CLK_S3D4 }, > > + { "pcie0", 318, R8A7795_CLK_S3D1 }, > > "pcie1" > > > + { "pcie1", 319, R8A7795_CLK_S3D1 }, > > "pcie0" Thanks for finding this, though I am not sure who this patch should be sent to as the r8a7795 cpg mssr driver has not been accepted yet afaik. For the moment I've sent it to the sh-ml so that people can test PCIe. Thanks Phil
Hi Phil, On Tue, Nov 3, 2015 at 10:05 AM, Phil Edworthy <phil.edworthy@renesas.com> wrote: > On 03 November 2015 07:49, Geert wrote: >> On Mon, Nov 2, 2015 at 6:31 PM, Phil Edworthy <phil.edworthy@renesas.com> >> wrote: >> > --- a/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c >> > +++ b/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c >> > @@ -120,6 +120,8 @@ static const struct mssr_mod_clk r8a7795_mod_clks[] >> __initconst = { >> > { "sys-dmac1", 218, R8A7795_CLK_S3D1 }, >> > { "sys-dmac0", 219, R8A7795_CLK_S3D1 }, >> > { "scif2", 310, R8A7795_CLK_S3D4 }, >> > + { "pcie0", 318, R8A7795_CLK_S3D1 }, >> >> "pcie1" >> >> > + { "pcie1", 319, R8A7795_CLK_S3D1 }, >> >> "pcie0" > > Thanks for finding this, though I am not sure who this patch should be sent to > as the r8a7795 cpg mssr driver has not been accepted yet afaik. For the > moment I've sent it to the sh-ml so that people can test PCIe. If you don't mind, I could integrate it in v6 of the r8a7795 cpg mssr driver. Note that there are more additions to r8a7795_mod_clks[] in the pipeline. Once the driver has been accepted, these should go in through the clock maintainers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert, On 03 November 2015 09:27, Geert wrote: > On Tue, Nov 3, 2015 at 10:05 AM, Phil Edworthy > <phil.edworthy@renesas.com> wrote: > > On 03 November 2015 07:49, Geert wrote: > >> On Mon, Nov 2, 2015 at 6:31 PM, Phil Edworthy > <phil.edworthy@renesas.com> > >> wrote: > >> > --- a/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c > >> > +++ b/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c > >> > @@ -120,6 +120,8 @@ static const struct mssr_mod_clk r8a7795_mod_clks[] > >> __initconst = { > >> > { "sys-dmac1", 218, R8A7795_CLK_S3D1 }, > >> > { "sys-dmac0", 219, R8A7795_CLK_S3D1 }, > >> > { "scif2", 310, R8A7795_CLK_S3D4 }, > >> > + { "pcie0", 318, R8A7795_CLK_S3D1 }, > >> > >> "pcie1" > >> > >> > + { "pcie1", 319, R8A7795_CLK_S3D1 }, > >> > >> "pcie0" > > > > Thanks for finding this, though I am not sure who this patch should be sent to > > as the r8a7795 cpg mssr driver has not been accepted yet afaik. For the > > moment I've sent it to the sh-ml so that people can test PCIe. > > If you don't mind, I could integrate it in v6 of the r8a7795 cpg mssr driver. That would be simplest. > Note that there are more additions to r8a7795_mod_clks[] in the pipeline. > Once the driver has been accepted, these should go in through the clock > maintainers. Of course, no problem. Thanks Phil
diff --git a/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c b/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c index d9edded..1e67f32 100644 --- a/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c +++ b/drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c @@ -120,6 +120,8 @@ static const struct mssr_mod_clk r8a7795_mod_clks[] __initconst = { { "sys-dmac1", 218, R8A7795_CLK_S3D1 }, { "sys-dmac0", 219, R8A7795_CLK_S3D1 }, { "scif2", 310, R8A7795_CLK_S3D4 }, + { "pcie0", 318, R8A7795_CLK_S3D1 }, + { "pcie1", 319, R8A7795_CLK_S3D1 }, { "intc-ap", 408, R8A7795_CLK_S3D1 }, { "audmac0", 502, R8A7795_CLK_S3D4 }, { "audmac1", 501, R8A7795_CLK_S3D4 },
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com> --- drivers/clk/shmobile/clk-r8a7795-cpg-mssr.c | 2 ++ 1 file changed, 2 insertions(+)