diff mbox

[PATCH/RFC] ARM: shmobile: Introduce ARCH_RENESAS

Message ID 1446702397-24078-1-git-send-email-horms+renesas@verge.net.au (mailing list archive)
State RFC
Delegated to: Simon Horman
Headers show

Commit Message

Simon Horman Nov. 5, 2015, 5:46 a.m. UTC
The purpose of this patch is to start the process of replacing both
ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI with ARCH_RENESAS. The motivation
being that as time has moved on Renesas has become a name than shmobile for
the majority Renesas 32-bit ARM based SoCs. The name is, conveniently, also
applicable to (older) Renesas SH based SoCs and (newer) ARM64 based SoCs
although this patch only addresses 32-bit ARM.

It is envisaged that follow up work may address migrating both
SH SoCs and drivers from ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI to
ARCH_RENESAS.

Proposed support for the r8a7795 ARM64 based SoC already uses ARCH_RENESAS
which selects ARCH_SHMOBILE.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---
* ARM64 patch is
  "[PATCH v12 1/7] arm64: renesas: r8a7795: Add Renesas R8A7795 SoC support"
  http://www.spinics.net/lists/arm-kernel/msg455822.html
---
 arch/arm/configs/multi_v7_defconfig |  2 +-
 arch/arm/configs/shmobile_defconfig |  2 +-
 arch/arm/mach-shmobile/Kconfig      | 10 +++++++---
 3 files changed, 9 insertions(+), 5 deletions(-)

Comments

Arnd Bergmann Nov. 5, 2015, 8:43 a.m. UTC | #1
On Thursday 05 November 2015 14:46:37 Simon Horman wrote:
>  config PM_RCAR
>         bool
> @@ -29,10 +31,11 @@ config ARCH_RMOBILE
>         select SYS_SUPPORTS_SH_CMT
>         select SYS_SUPPORTS_SH_TMU
>  
> -menuconfig ARCH_SHMOBILE_MULTI
> +config ARCH_RENESAS
>         bool "Renesas ARM SoCs" if ARCH_MULTI_V7
>         depends on MMU
>         select ARCH_SHMOBILE
> +       select ARCH_SHMOBILE_MULTI
>         select HAVE_ARM_SCU if SMP
>         select HAVE_ARM_TWD if SMP
>         select ARM_GIC
> 

The patch looks mostly good to me, but please leave this as a
'menuconfig' rather than 'config'. I'd like to keep having one
Kconfig submenu for each mach-* directory, as most platforms
do today. We should really fix the ones that don't currently do
it like this.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Nov. 5, 2015, 11:17 a.m. UTC | #2
Hello.

On 11/5/2015 8:46 AM, Simon Horman wrote:

> The purpose of this patch is to start the process of replacing both
> ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI with ARCH_RENESAS. The motivation
> being that as time has moved on Renesas has become a name than shmobile for
> the majority Renesas 32-bit ARM based SoCs.

    Couldn't parse this sentence. :-)

> The name is, conveniently, also
> applicable to (older) Renesas SH based SoCs and (newer) ARM64 based SoCs
> although this patch only addresses 32-bit ARM.
>
> It is envisaged that follow up work may address migrating both
> SH SoCs and drivers from ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI to
> ARCH_RENESAS.
>
> Proposed support for the r8a7795 ARM64 based SoC already uses ARCH_RENESAS
> which selects ARCH_SHMOBILE.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Nov. 5, 2015, 12:09 p.m. UTC | #3
On Thu, Nov 05, 2015 at 09:43:31AM +0100, Arnd Bergmann wrote:
> On Thursday 05 November 2015 14:46:37 Simon Horman wrote:
> >  config PM_RCAR
> >         bool
> > @@ -29,10 +31,11 @@ config ARCH_RMOBILE
> >         select SYS_SUPPORTS_SH_CMT
> >         select SYS_SUPPORTS_SH_TMU
> >  
> > -menuconfig ARCH_SHMOBILE_MULTI
> > +config ARCH_RENESAS
> >         bool "Renesas ARM SoCs" if ARCH_MULTI_V7
> >         depends on MMU
> >         select ARCH_SHMOBILE
> > +       select ARCH_SHMOBILE_MULTI
> >         select HAVE_ARM_SCU if SMP
> >         select HAVE_ARM_TWD if SMP
> >         select ARM_GIC
> > 
> 
> The patch looks mostly good to me, but please leave this as a
> 'menuconfig' rather than 'config'. I'd like to keep having one
> Kconfig submenu for each mach-* directory, as most platforms
> do today. We should really fix the ones that don't currently do
> it like this.

Sure, will do.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Nov. 5, 2015, 12:10 p.m. UTC | #4
On Thu, Nov 05, 2015 at 02:17:31PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/5/2015 8:46 AM, Simon Horman wrote:
> 
> >The purpose of this patch is to start the process of replacing both
> >ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI with ARCH_RENESAS. The motivation
> >being that as time has moved on Renesas has become a name than shmobile for
> >the majority Renesas 32-bit ARM based SoCs.
> 
>    Couldn't parse this sentence. :-)

RENESAS seems to be a more appropriate name that SHMOBILE for the
majority of Renesas 32-bit ARM based SoCs.

> >The name is, conveniently, also
> >applicable to (older) Renesas SH based SoCs and (newer) ARM64 based SoCs
> >although this patch only addresses 32-bit ARM.
> >
> >It is envisaged that follow up work may address migrating both
> >SH SoCs and drivers from ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI to
> >ARCH_RENESAS.
> >
> >Proposed support for the r8a7795 ARM64 based SoC already uses ARCH_RENESAS
> >which selects ARCH_SHMOBILE.
> >
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> [...]
> 
> MBR, Sergei
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Nov. 5, 2015, 12:29 p.m. UTC | #5
On 11/5/2015 3:10 PM, Simon Horman wrote:

>>> The purpose of this patch is to start the process of replacing both
>>> ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI with ARCH_RENESAS. The motivation
>>> being that as time has moved on Renesas has become a name than shmobile for
>>> the majority Renesas 32-bit ARM based SoCs.
>>
>>     Couldn't parse this sentence. :-)
>
> RENESAS seems to be a more appropriate name that SHMOBILE for the

    s/that/than/. Otherwise parsable. :-)

> majority of Renesas 32-bit ARM based SoCs.
>
>>> The name is, conveniently, also
>>> applicable to (older) Renesas SH based SoCs and (newer) ARM64 based SoCs
>>> although this patch only addresses 32-bit ARM.
>>>
>>> It is envisaged that follow up work may address migrating both
>>> SH SoCs and drivers from ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI to
>>> ARCH_RENESAS.
>>>
>>> Proposed support for the r8a7795 ARM64 based SoC already uses ARCH_RENESAS
>>> which selects ARCH_SHMOBILE.
>>>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>
>> [...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven Nov. 5, 2015, 6:58 p.m. UTC | #6
On Thu, Nov 5, 2015 at 6:46 AM, Simon Horman <horms+renesas@verge.net.au> wrote:
> The purpose of this patch is to start the process of replacing both
> ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI with ARCH_RENESAS. The motivation
> being that as time has moved on Renesas has become a name than shmobile for
> the majority Renesas 32-bit ARM based SoCs. The name is, conveniently, also
> applicable to (older) Renesas SH based SoCs and (newer) ARM64 based SoCs
> although this patch only addresses 32-bit ARM.

Is this supposed to include H8/300 and m32r in the future?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Nov. 6, 2015, 1:41 a.m. UTC | #7
On Thu, Nov 05, 2015 at 07:58:46PM +0100, Geert Uytterhoeven wrote:
> On Thu, Nov 5, 2015 at 6:46 AM, Simon Horman <horms+renesas@verge.net.au> wrote:
> > The purpose of this patch is to start the process of replacing both
> > ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI with ARCH_RENESAS. The motivation
> > being that as time has moved on Renesas has become a name than shmobile for
> > the majority Renesas 32-bit ARM based SoCs. The name is, conveniently, also
> > applicable to (older) Renesas SH based SoCs and (newer) ARM64 based SoCs
> > although this patch only addresses 32-bit ARM.
> 
> Is this supposed to include H8/300 and m32r in the future?

Hi Geert,

my main aim is to replace ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI with
ARCH_RENESAS. I don't believe that would cover H8/300 and m32r,
though I am happy to stand corrected.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index a5c6ebf39b0a..dc4a216e2e41 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -73,7 +73,7 @@  CONFIG_MACH_SPEAR1340=y
 CONFIG_ARCH_STI=y
 CONFIG_ARCH_EXYNOS=y
 CONFIG_EXYNOS5420_MCPM=y
-CONFIG_ARCH_SHMOBILE_MULTI=y
+CONFIG_ARCH_RENESAS=y
 CONFIG_ARCH_EMEV2=y
 CONFIG_ARCH_R7S72100=y
 CONFIG_ARCH_R8A73A4=y
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 3aef019c0de7..cc8ece33a7e3 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -9,7 +9,7 @@  CONFIG_SYSCTL_SYSCALL=y
 CONFIG_EMBEDDED=y
 CONFIG_PERF_EVENTS=y
 CONFIG_SLAB=y
-CONFIG_ARCH_SHMOBILE_MULTI=y
+CONFIG_ARCH_RENESAS=y
 CONFIG_ARCH_EMEV2=y
 CONFIG_ARCH_R7S72100=y
 CONFIG_ARCH_R8A73A4=y
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index 88734a5e10ca..676e11d44e41 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -1,6 +1,8 @@ 
 config ARCH_SHMOBILE
 	bool
-	select ZONE_DMA if ARM_LPAE
+
+config ARCH_SHMOBILE_MULTI
+	bool
 
 config PM_RCAR
 	bool
@@ -29,10 +31,11 @@  config ARCH_RMOBILE
 	select SYS_SUPPORTS_SH_CMT
 	select SYS_SUPPORTS_SH_TMU
 
-menuconfig ARCH_SHMOBILE_MULTI
+config ARCH_RENESAS
 	bool "Renesas ARM SoCs" if ARCH_MULTI_V7
 	depends on MMU
 	select ARCH_SHMOBILE
+	select ARCH_SHMOBILE_MULTI
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
 	select ARM_GIC
@@ -40,8 +43,9 @@  menuconfig ARCH_SHMOBILE_MULTI
 	select NO_IOPORT_MAP
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
+	select ZONE_DMA if ARM_LPAE
 
-if ARCH_SHMOBILE_MULTI
+if ARCH_RENESAS
 
 #comment "Renesas ARM SoCs System Type"