| Message ID | 1447144506-20336-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 27fa0a6c55537f8d8656b9e59ae584b0b427232a |
| Headers | show |
On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote: > As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a > dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support > partitions in a special 'partitions' subnode"), having partitions as > direct subnodes of an mtd device is discouraged: > > spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions. I seem to see something else, perhaps I have a hardware problem? m25p80 spi0.0: unrecognized JEDEC id bytes: 01, 2, 20 > Hence move the SPI FLASH partitions to a "partitions" subnode. Thanks, I will queue this up. I assume we also need this for other boards with flash nodes in mainline: bockw, lager, porter, silk. I'm happy to prepare patches to do that if you want to pass. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> [snip] -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman <horms@verge.net.au> wrote: > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote: >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support >> partitions in a special 'partitions' subnode"), having partitions as >> direct subnodes of an mtd device is discouraged: >> >> spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions. > > I seem to see something else, perhaps I have a hardware problem? > > m25p80 spi0.0: unrecognized JEDEC id bytes: 01, 2, 20 That indeed means QSPI doesn't work. Is it reproducible? Is this on Koelsch? >> Hence move the SPI FLASH partitions to a "partitions" subnode. > > Thanks, I will queue this up. > > I assume we also need this for other boards with flash nodes > in mainline: bockw, lager, porter, silk. Indeed. I converted Koelsch only to see if it works, and as a reminder for the other boards. But as you added more deprecated usage, I sent out what I had. > I'm happy to prepare patches to do that if you want to pass. Feel free to convert the other boards if you have time. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 12, 2015 at 11:03:33AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman <horms@verge.net.au> wrote: > > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote: > >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a > >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support > >> partitions in a special 'partitions' subnode"), having partitions as > >> direct subnodes of an mtd device is discouraged: > >> > >> spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions. > > > > I seem to see something else, perhaps I have a hardware problem? > > > > m25p80 spi0.0: unrecognized JEDEC id bytes: 01, 2, 20 > > That indeed means QSPI doesn't work. Is it reproducible? > Is this on Koelsch? Yes. It appears to happy reliably in my Koelsch. > > >> Hence move the SPI FLASH partitions to a "partitions" subnode. > > > > Thanks, I will queue this up. > > > > I assume we also need this for other boards with flash nodes > > in mainline: bockw, lager, porter, silk. > > Indeed. I converted Koelsch only to see if it works, and as a reminder for > the other boards. But as you added more deprecated usage, I sent out what > I had. > > > I'm happy to prepare patches to do that if you want to pass. > > Feel free to convert the other boards if you have time. Thanks! Sure, will do. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, On Fri, Nov 13, 2015 at 1:28 AM, Simon Horman <horms@verge.net.au> wrote: > On Thu, Nov 12, 2015 at 11:03:33AM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman <horms@verge.net.au> wrote: >> > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote: >> >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a >> >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support >> >> partitions in a special 'partitions' subnode"), having partitions as >> >> direct subnodes of an mtd device is discouraged: >> >> >> >> spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions. >> > >> > I seem to see something else, perhaps I have a hardware problem? >> > >> > m25p80 spi0.0: unrecognized JEDEC id bytes: 01, 2, 20 >> >> That indeed means QSPI doesn't work. Is it reproducible? >> Is this on Koelsch? > > Yes. It appears to happy reliably in my Koelsch. Which tree / config? I've just tried renesas-devel-20151113-v4.3 and topic/gen3-latest with shmobile_defconfig, and the QSPI flash was detected correctly on both (the former failed to parse partitions, as the code for the partitions subnode is not yet in v4.3). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 13, 2015 at 08:56:18AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Nov 13, 2015 at 1:28 AM, Simon Horman <horms@verge.net.au> wrote: > > On Thu, Nov 12, 2015 at 11:03:33AM +0100, Geert Uytterhoeven wrote: > >> On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman <horms@verge.net.au> wrote: > >> > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote: > >> >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a > >> >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support > >> >> partitions in a special 'partitions' subnode"), having partitions as > >> >> direct subnodes of an mtd device is discouraged: > >> >> > >> >> spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions. > >> > > >> > I seem to see something else, perhaps I have a hardware problem? > >> > > >> > m25p80 spi0.0: unrecognized JEDEC id bytes: 01, 2, 20 > >> > >> That indeed means QSPI doesn't work. Is it reproducible? > >> Is this on Koelsch? > > > > Yes. It appears to happy reliably in my Koelsch. > > Which tree / config? > > I've just tried renesas-devel-20151113-v4.3 and topic/gen3-latest with > shmobile_defconfig, and the QSPI flash was detected correctly on both (the > former failed to parse partitions, as the code for the partitions subnode is > not yet in v4.3). * I am able to reproduce the "unrecognized JDEC id" problem on my Koelsch board using renesas-devel-20151113-v4.3 with shmobile_defconfig. * I also noticed the partitions problem (on the gose board). Perhaps I should have held off on applying the patches in question. But the appears to be resolved now that the branch with the patch in question has been rebased on top of v4.4-rc1. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index f63338ba3599ebc0..2cbd5e330c032533 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -490,8 +490,6 @@ status = "okay"; flash: flash@0 { - #address-cells = <1>; - #size-cells = <1>; compatible = "spansion,s25fl512s", "jedec,spi-nor"; reg = <0>; spi-max-frequency = <30000000>; @@ -501,19 +499,24 @@ spi-cpol; m25p,fast-read; - partition@0 { - label = "loader"; - reg = <0x00000000 0x00080000>; - read-only; - }; - partition@80000 { - label = "user"; - reg = <0x00080000 0x00580000>; - read-only; - }; - partition@600000 { - label = "flash"; - reg = <0x00600000 0x03a00000>; + partitions { + #address-cells = <1>; + #size-cells = <1>; + + partition@0 { + label = "loader"; + reg = <0x00000000 0x00080000>; + read-only; + }; + partition@80000 { + label = "user"; + reg = <0x00080000 0x00580000>; + read-only; + }; + partition@600000 { + label = "flash"; + reg = <0x00600000 0x03a00000>; + }; }; }; };
As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support partitions in a special 'partitions' subnode"), having partitions as direct subnodes of an mtd device is discouraged: spi0.0: 'partitions' subnode not found on /spi@e6b10000/flash@0. Trying to parse direct subnodes as partitions. Hence move the SPI FLASH partitions to a "partitions" subnode. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/boot/dts/r8a7791-koelsch.dts | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-)