diff mbox

[3/3] ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE

Message ID 1452537674-20006-4-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit 406663ed61c8ad2b792824af1c1bc0e4faa711c6
Delegated to: Simon Horman
Headers show

Commit Message

Geert Uytterhoeven Jan. 11, 2016, 6:41 p.m. UTC
Do not disable branch prediction, as this has a big performance impact.

After re-enabling branch prediction, __loop_delay() runs 16 (Cortex A15)
or 11 (Cortex A9) times faster than before.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This used to be enabled in:

  - ag5evm_defconfig (sh73a0)
  - ape6evm_defconfig (r8a73a4)
  - armadillo800eva_defconfig (r8a7740)
  - koelsch_defconfig (r8a7791)
  - kota2_defconfig (sh73a0)

Was there ever a good reason for that?
---
 arch/arm/configs/shmobile_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Horman Jan. 18, 2016, 1:48 a.m. UTC | #1
On Mon, Jan 11, 2016 at 07:41:14PM +0100, Geert Uytterhoeven wrote:
> Do not disable branch prediction, as this has a big performance impact.
> 
> After re-enabling branch prediction, __loop_delay() runs 16 (Cortex A15)
> or 11 (Cortex A9) times faster than before.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This used to be enabled in:
> 
>   - ag5evm_defconfig (sh73a0)
>   - ape6evm_defconfig (r8a73a4)
>   - armadillo800eva_defconfig (r8a7740)
>   - koelsch_defconfig (r8a7791)
>   - kota2_defconfig (sh73a0)
> 
> Was there ever a good reason for that?

If that was a concious decision then I believe it was made before my time.
I'm going ahead and queuing up this change for v4.6.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 969738324a5d5f81..5208b5caacd1a4e2 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -20,7 +20,6 @@  CONFIG_ARCH_R8A7791=y
 CONFIG_ARCH_R8A7793=y
 CONFIG_ARCH_R8A7794=y
 CONFIG_ARCH_SH73A0=y
-CONFIG_CPU_BPREDICT_DISABLE=y
 CONFIG_PL310_ERRATA_588369=y
 CONFIG_ARM_ERRATA_754322=y
 CONFIG_PCI=y