From patchwork Fri Jan 15 00:09:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 8036801 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 031489F1C0 for ; Fri, 15 Jan 2016 00:15:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2EF3E20515 for ; Fri, 15 Jan 2016 00:15:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48B4C20502 for ; Fri, 15 Jan 2016 00:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755534AbcAOAPh (ORCPT ); Thu, 14 Jan 2016 19:15:37 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:34703 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755319AbcAOAPf (ORCPT ); Thu, 14 Jan 2016 19:15:35 -0500 Received: by mail-lf0-f47.google.com with SMTP id 17so71087804lfz.1 for ; Thu, 14 Jan 2016 16:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Xj1x6vBVFzempKin1kx71ct2HvdT4rSKsS1tMIF8tns=; b=c7STHxnTQy5VlRWvsmJGgD9UPiajdTWzyB3vKflH+rtS0ZhomONs7XDMXOi2rzMzTH /ysuejOU1nBVG9T/mkwwDL+XSE8RCTFzBFolGxnFPBNokU+kxMyKypGgkUaOlMIKqwd+ EYJA6I8LC5niA5H0f62PkPlZIPYolAyRyK9tw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Xj1x6vBVFzempKin1kx71ct2HvdT4rSKsS1tMIF8tns=; b=dzPZTCN1Go4u4X9yilTkg5ZrBMXiKdlLM9Brp7GyDjHI+f5kVhkQMkYXpwc2Xe836d jU5P2MA1jvH+4K15CNVugTUSBMseOHfk2wtM8JZWMfTasbPo7QBY11q1QBcy5KhwjD/H Rr4Jl+ydzzny+Susq3TI9g1I2QpVtY4z6LE/0l1uMSKH9qOcTiJjeKKlB1RuG+DsZWZY bFGufHPkF6BqZ2h/iho7Lm+sxOR0xkwqttgr/UEPbH2QyBBh2zUkrI6TIrP9wxm8HZqU OWF+N3SyZvLotChLkRUPvxA2vKcig3WpUDHAHIr1eOEkkRRD1Z/fmgNyKbrgWBSAOaBJ HCaA== X-Gm-Message-State: ALoCoQnhgpcR1TAtOor+00NXJlUAp5CrxXwtb1MD+0ZYTjKnGumZsqtA2+y9J0Rvb6b1ttyULKaOt5PaAUirBxyUBVIJRU7a4Q== X-Received: by 10.25.137.136 with SMTP id l130mr1942428lfd.158.1452816933407; Thu, 14 Jan 2016 16:15:33 -0800 (PST) Received: from localhost (c-932171d5.07-21-73746f28.cust.bredbandsbolaget.se. [213.113.33.147]) by smtp.gmail.com with ESMTPSA id h187sm1072841lfg.18.2016.01.14.16.15.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jan 2016 16:15:32 -0800 (PST) From: Anders Roxell To: mchehab@osg.samsung.com, laurent.pinchart@ideasonboard.com Cc: linux-media@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Anders Roxell Subject: [PATCH] drivers/media: vsp1_video: fix compile error Date: Fri, 15 Jan 2016 01:09:43 +0100 Message-Id: <1452816583-11036-1-git-send-email-anders.roxell@linaro.org> X-Mailer: git-send-email 2.1.4 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This was found with the -RT patch enabled, but the fix should apply to non-RT also. Compilation error without this fix: ../drivers/media/platform/vsp1/vsp1_video.c: In function 'vsp1_pipeline_stopped': ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected expression before 'do' spin_unlock_irqrestore(&pipe->irqlock, flags); ^ Signed-off-by: Anders Roxell Reviewed-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline *pipe) bool stopped; spin_lock_irqsave(&pipe->irqlock, flags); - stopped = pipe->state == VSP1_PIPELINE_STOPPED, + stopped = pipe->state == VSP1_PIPELINE_STOPPED; spin_unlock_irqrestore(&pipe->irqlock, flags); return stopped;