diff mbox

[RFC,07/12] sh, rwsem: provide __down_write_killable

Message ID 1454444369-2146-8-git-send-email-mhocko@kernel.org (mailing list archive)
State Superseded
Headers show

Commit Message

Michal Hocko Feb. 2, 2016, 8:19 p.m. UTC 
From: Michal Hocko <mhocko@suse.com>

which is uses the same fast path as __down_write except it falls back to
rwsem_down_write_failed_killable slow path and return -EINTR if killed.

Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/sh/include/asm/rwsem.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Sergei Shtylyov Feb. 3, 2016, 11:19 a.m. UTC | #1 
Hello.

On 2/2/2016 11:19 PM, Michal Hocko wrote:

> From: Michal Hocko <mhocko@suse.com>
>
> which is uses the same fast path as __down_write except it falls back to

    s/is//. Same typo (?) in the other patches...

> rwsem_down_write_failed_killable slow path and return -EINTR if killed.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michal Hocko Feb. 3, 2016, 12:11 p.m. UTC | #2 
On Wed 03-02-16 14:19:05, Sergei Shtylyov wrote:
> Hello.
> 
> On 2/2/2016 11:19 PM, Michal Hocko wrote:
> 
> >From: Michal Hocko <mhocko@suse.com>
> >
> >which is uses the same fast path as __down_write except it falls back to
> 
>    s/is//. Same typo (?) in the other patches...

Thanks will fix that.

> 
> >rwsem_down_write_failed_killable slow path and return -EINTR if killed.
> >
> >Signed-off-by: Michal Hocko <mhocko@suse.com>
> 
> [...]
> 
> MBR, Sergei
>
diff mbox

Patch

diff --git a/arch/sh/include/asm/rwsem.h b/arch/sh/include/asm/rwsem.h
index f6c951c7a875..8a457b83d2a5 100644
--- a/arch/sh/include/asm/rwsem.h
+++ b/arch/sh/include/asm/rwsem.h
@@ -54,6 +54,19 @@  static inline void __down_write(struct rw_semaphore *sem)
 		rwsem_down_write_failed(sem);
 }
 
+static inline int __down_write_killable(struct rw_semaphore *sem)
+{
+	int tmp;
+
+	tmp = atomic_add_return(RWSEM_ACTIVE_WRITE_BIAS,
+				(atomic_t *)(&sem->count));
+	if (tmp != RWSEM_ACTIVE_WRITE_BIAS)
+		if (IS_ERR(rwsem_down_write_failed_killable(sem)))
+			return -EINTR;
+
+	return 0;
+}
+
 static inline int __down_write_trylock(struct rw_semaphore *sem)
 {
 	int tmp;