| Message ID | 1608366.HtA9yBksdO@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
On Sat, Jan 31, 2015 at 01:52:16AM +0300, Sergei Shtylyov wrote: > Add the initial device tree for the R8A7794 SoC based SILK low cost board. > SCIF2 serial port support is included, so that the serial console can work. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon > Horman's 'renesas.git' repo. > > arch/arm/boot/dts/Makefile | 1 > arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > Index: renesas/arch/arm/boot/dts/Makefile > =================================================================== > --- renesas.orig/arch/arm/boot/dts/Makefile > +++ renesas/arch/arm/boot/dts/Makefile > @@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme > r8a7791-koelsch.dtb \ > r8a7791-porter.dtb \ > r8a7794-alt.dtb \ > + r8a7794-silk.dtb \ > sh73a0-kzm9g.dtb > dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \ > socfpga_arria10_socdk.dtb \ > Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts > =================================================================== > --- /dev/null > +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts > @@ -0,0 +1,41 @@ > +/* > + * Device Tree Source for the SILK board > + * > + * Copyright (C) 2014 Renesas Electronics Corporation > + * Copyright (C) 2014-2015 Renesas Solutions Corp. > + * Copyright (C) 2014-2015 Cogent Embedded, Inc. > + * > + * This file is licensed under the terms of the GNU General Public License > + * version 2. This program is licensed "as is" without any warranty of any > + * kind, whether express or implied. > + */ > + > +/dts-v1/; > +#include "r8a7794.dtsi" > + > +/ { > + model = "SILK"; > + compatible = "renesas,silk", "renesas,r8a7794"; > + > + aliases { > + serial0 = &scif2; > + }; > + > + chosen { > + bootargs = "console=ttySC0,38400 ignore_loglevel"; Please remove console= for consistency with other boards based on Renesas SoCs. > + stdout-path = &scif2; > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0 0x40000000 0 0x40000000>; > + }; > +}; > + > +&extal_clk { > + clock-frequency = <20000000>; > +}; > + > +&scif2 { > + status = "okay"; > +}; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 1/31/2015 7:21 AM, Simon Horman wrote: >> Add the initial device tree for the R8A7794 SoC based SILK low cost board. >> SCIF2 serial port support is included, so that the serial console can work. >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> --- >> This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon >> Horman's 'renesas.git' repo. >> arch/arm/boot/dts/Makefile | 1 >> arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ >> 2 files changed, 42 insertions(+) [...] >> Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts >> =================================================================== >> --- /dev/null >> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts >> @@ -0,0 +1,41 @@ >> +/* >> + * Device Tree Source for the SILK board >> + * >> + * Copyright (C) 2014 Renesas Electronics Corporation >> + * Copyright (C) 2014-2015 Renesas Solutions Corp. >> + * Copyright (C) 2014-2015 Cogent Embedded, Inc. >> + * >> + * This file is licensed under the terms of the GNU General Public License >> + * version 2. This program is licensed "as is" without any warranty of any >> + * kind, whether express or implied. >> + */ >> + >> +/dts-v1/; >> +#include "r8a7794.dtsi" >> + >> +/ { >> + model = "SILK"; >> + compatible = "renesas,silk", "renesas,r8a7794"; >> + >> + aliases { >> + serial0 = &scif2; >> + }; >> + >> + chosen { >> + bootargs = "console=ttySC0,38400 ignore_loglevel"; > Please remove console= for consistency with other boards > based on Renesas SoCs. I can't, there will be no console at all. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sergei, On Sat, Jan 31, 2015 at 09:27:05PM +0300, Sergei Shtylyov wrote: > Hello. > > On 1/31/2015 7:21 AM, Simon Horman wrote: > > >>Add the initial device tree for the R8A7794 SoC based SILK low cost board. > >>SCIF2 serial port support is included, so that the serial console can work. > > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >>--- > >>This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon > >>Horman's 'renesas.git' repo. > > >> arch/arm/boot/dts/Makefile | 1 > >> arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ > >> 2 files changed, 42 insertions(+) > > [...] > >>Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts > >>=================================================================== > >>--- /dev/null > >>+++ renesas/arch/arm/boot/dts/r8a7794-silk.dts > >>@@ -0,0 +1,41 @@ > >>+/* > >>+ * Device Tree Source for the SILK board > >>+ * > >>+ * Copyright (C) 2014 Renesas Electronics Corporation > >>+ * Copyright (C) 2014-2015 Renesas Solutions Corp. > >>+ * Copyright (C) 2014-2015 Cogent Embedded, Inc. > >>+ * > >>+ * This file is licensed under the terms of the GNU General Public License > >>+ * version 2. This program is licensed "as is" without any warranty of any > >>+ * kind, whether express or implied. > >>+ */ > >>+ > >>+/dts-v1/; > >>+#include "r8a7794.dtsi" > >>+ > >>+/ { > >>+ model = "SILK"; > >>+ compatible = "renesas,silk", "renesas,r8a7794"; > >>+ > >>+ aliases { > >>+ serial0 = &scif2; > >>+ }; > >>+ > >>+ chosen { > >>+ bootargs = "console=ttySC0,38400 ignore_loglevel"; > > >Please remove console= for consistency with other boards > >based on Renesas SoCs. > > I can't, there will be no console at all. Its not clear to me why that should be the case when you also have: stdout-path = &scif2; Is this a baud issue? If so is it possible to set uboot to 115200 bps? This would be consistent with the way other boards are handled in mainline. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 02, 2015 at 12:19:12AM +0000, Simon Horman wrote: > Hi Sergei, > > On Sat, Jan 31, 2015 at 09:27:05PM +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 1/31/2015 7:21 AM, Simon Horman wrote: > > > > >>Add the initial device tree for the R8A7794 SoC based SILK low cost board. > > >>SCIF2 serial port support is included, so that the serial console can work. > > > > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > > >>--- > > >>This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon > > >>Horman's 'renesas.git' repo. > > > > >> arch/arm/boot/dts/Makefile | 1 > > >> arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ > > >> 2 files changed, 42 insertions(+) > > > > [...] > > >>Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts > > >>=================================================================== > > >>--- /dev/null > > >>+++ renesas/arch/arm/boot/dts/r8a7794-silk.dts > > >>@@ -0,0 +1,41 @@ > > >>+/* > > >>+ * Device Tree Source for the SILK board > > >>+ * > > >>+ * Copyright (C) 2014 Renesas Electronics Corporation > > >>+ * Copyright (C) 2014-2015 Renesas Solutions Corp. > > >>+ * Copyright (C) 2014-2015 Cogent Embedded, Inc. > > >>+ * > > >>+ * This file is licensed under the terms of the GNU General Public License > > >>+ * version 2. This program is licensed "as is" without any warranty of any > > >>+ * kind, whether express or implied. > > >>+ */ > > >>+ > > >>+/dts-v1/; > > >>+#include "r8a7794.dtsi" > > >>+ > > >>+/ { > > >>+ model = "SILK"; > > >>+ compatible = "renesas,silk", "renesas,r8a7794"; > > >>+ > > >>+ aliases { > > >>+ serial0 = &scif2; > > >>+ }; > > >>+ > > >>+ chosen { > > >>+ bootargs = "console=ttySC0,38400 ignore_loglevel"; > > > > >Please remove console= for consistency with other boards > > >based on Renesas SoCs. > > > > I can't, there will be no console at all. > > Its not clear to me why that should be the case when you also have: > > stdout-path = &scif2; > > Is this a baud issue? If so is it possible to set uboot to 115200 bps? > This would be consistent with the way other boards are handled in mainline. If it's not possible to update the bootloader, the other option is to use the console parametuers in stdout-path, e.g. stdout-path = "serial0:38400n8"; That way all the console stuff should get set up as expected without a command line being required. As far as I am aware, an explicit command line should then override this if necessary. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 30, 2015 at 10:52:16PM +0000, Sergei Shtylyov wrote: > Add the initial device tree for the R8A7794 SoC based SILK low cost board. > SCIF2 serial port support is included, so that the serial console can work. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon > Horman's 'renesas.git' repo. > > arch/arm/boot/dts/Makefile | 1 > arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > Index: renesas/arch/arm/boot/dts/Makefile > =================================================================== > --- renesas.orig/arch/arm/boot/dts/Makefile > +++ renesas/arch/arm/boot/dts/Makefile > @@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme > r8a7791-koelsch.dtb \ > r8a7791-porter.dtb \ > r8a7794-alt.dtb \ > + r8a7794-silk.dtb \ > sh73a0-kzm9g.dtb > dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \ > socfpga_arria10_socdk.dtb \ > Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts > =================================================================== > --- /dev/null > +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts > @@ -0,0 +1,41 @@ > +/* > + * Device Tree Source for the SILK board > + * > + * Copyright (C) 2014 Renesas Electronics Corporation > + * Copyright (C) 2014-2015 Renesas Solutions Corp. > + * Copyright (C) 2014-2015 Cogent Embedded, Inc. > + * > + * This file is licensed under the terms of the GNU General Public License > + * version 2. This program is licensed "as is" without any warranty of any > + * kind, whether express or implied. > + */ > + > +/dts-v1/; > +#include "r8a7794.dtsi" > + > +/ { > + model = "SILK"; Shouldn't that have a "Renesas" prefix or something like that? It's unlikely that there will be another board called "SILK", but it does make it hard for someone to get an idea of what the board is from the model string alone. Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 01/31/2015 01:52 AM, Sergei Shtylyov wrote: > Add the initial device tree for the R8A7794 SoC based SILK low cost board. > SCIF2 serial port support is included, so that the serial console can work. > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > --- > This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon > Horman's 'renesas.git' repo. > > arch/arm/boot/dts/Makefile | 1 > arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > Index: renesas/arch/arm/boot/dts/Makefile > =================================================================== > --- renesas.orig/arch/arm/boot/dts/Makefile > +++ renesas/arch/arm/boot/dts/Makefile > @@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme > r8a7791-koelsch.dtb \ > r8a7791-porter.dtb \ Oops, the patch was additionally against the Henninger->Porter rename patch. I will fix that. > r8a7794-alt.dtb \ > + r8a7794-silk.dtb \ > sh73a0-kzm9g.dtb WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 02/02/2015 02:05 PM, Mark Rutland wrote: >> Add the initial device tree for the R8A7794 SoC based SILK low cost board. >> SCIF2 serial port support is included, so that the serial console can work. >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> [...] >> Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts >> =================================================================== >> --- /dev/null >> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts >> @@ -0,0 +1,41 @@ >> +/* >> + * Device Tree Source for the SILK board >> + * >> + * Copyright (C) 2014 Renesas Electronics Corporation >> + * Copyright (C) 2014-2015 Renesas Solutions Corp. >> + * Copyright (C) 2014-2015 Cogent Embedded, Inc. >> + * >> + * This file is licensed under the terms of the GNU General Public License >> + * version 2. This program is licensed "as is" without any warranty of any >> + * kind, whether express or implied. >> + */ >> + >> +/dts-v1/; >> +#include "r8a7794.dtsi" >> + >> +/ { >> + model = "SILK"; > Shouldn't that have a "Renesas" prefix or something like that? Historically. no SH-Mobile .dts has used the vendor name in the "model" prop. I defer the decision to Simon but I think we should be at least consistent. > It's unlikely that there will be another board called "SILK", but it > does make it hard for someone to get an idea of what the board is from > the model string alone. Tend to agree here. > Mark. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 02, 2015 at 11:57:50PM +0300, Sergei Shtylyov wrote: > Hello. > > On 02/02/2015 02:05 PM, Mark Rutland wrote: > > >>Add the initial device tree for the R8A7794 SoC based SILK low cost board. > >>SCIF2 serial port support is included, so that the serial console can work. > > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > [...] > > >>Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts > >>=================================================================== > >>--- /dev/null > >>+++ renesas/arch/arm/boot/dts/r8a7794-silk.dts > >>@@ -0,0 +1,41 @@ > >>+/* > >>+ * Device Tree Source for the SILK board > >>+ * > >>+ * Copyright (C) 2014 Renesas Electronics Corporation > >>+ * Copyright (C) 2014-2015 Renesas Solutions Corp. > >>+ * Copyright (C) 2014-2015 Cogent Embedded, Inc. > >>+ * > >>+ * This file is licensed under the terms of the GNU General Public License > >>+ * version 2. This program is licensed "as is" without any warranty of any > >>+ * kind, whether express or implied. > >>+ */ > >>+ > >>+/dts-v1/; > >>+#include "r8a7794.dtsi" > >>+ > >>+/ { > >>+ model = "SILK"; > > >Shouldn't that have a "Renesas" prefix or something like that? > > Historically. no SH-Mobile .dts has used the vendor name in the "model" > prop. I defer the decision to Simon but I think we should be at least > consistent. They are also my thoughts (except the bit about deferring to myself). If there is a good motivation for a Renesas prefix then that is fine by me. But in that case it seems that it would be appropriate to update the existing renesas boards too. The only thing that stood out to me about "SILK" was that unlike other renesas boards names in .dtsi files it is all-capitals. Its not a bit deal but as we are on the topic: is that intentional? > >It's unlikely that there will be another board called "SILK", but it > >does make it hard for someone to get an idea of what the board is from > >the model string alone. > > Tend to agree here. > > >Mark. > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 3, 2015 at 1:36 AM, Simon Horman <horms@verge.net.au> wrote: > The only thing that stood out to me about "SILK" was that unlike > other renesas boards names in .dtsi files it is all-capitals. > Its not a bit deal but as we are on the topic: is that intentional? Seems like we can use some consistency: $ git grep -w model -- $(git grep -l renesas, -- arch/arm/boot/dts) arch/arm/boot/dts/emev2-kzm9d.dts: model = "EMEV2 KZM9D Board"; arch/arm/boot/dts/r7s72100-genmai.dts: model = "Genmai"; arch/arm/boot/dts/r8a73a4-ape6evm.dts: model = "APE6EVM"; arch/arm/boot/dts/r8a7740-armadillo800eva.dts: model = "armadillo 800 eva"; arch/arm/boot/dts/r8a7778-bockw-reference.dts: model = "bockw"; arch/arm/boot/dts/r8a7778-bockw.dts: model = "bockw"; arch/arm/boot/dts/r8a7779-marzen.dts: model = "marzen"; arch/arm/boot/dts/r8a7790-lager.dts: model = "Lager"; arch/arm/boot/dts/r8a7791-henninger.dts: model = "Henninger"; arch/arm/boot/dts/r8a7791-koelsch.dts: model = "Koelsch"; arch/arm/boot/dts/r8a7794-alt.dts: model = "Alt"; arch/arm/boot/dts/sh73a0-kzm9g.dts: model = "KZM-A9-GT"; $ ePAPR says: "The recommended format is: “manufacturer,model”, where manufacturer is a string describing the name of the manufacturer (such as a stock ticker symbol), and model specifies the model number. Example: model = “fsl,MPC8349EMITX”;" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 2/3/2015 3:36 AM, Simon Horman wrote: >>>> Add the initial device tree for the R8A7794 SoC based SILK low cost board. >>>> SCIF2 serial port support is included, so that the serial console can work. >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> [...] >>>> Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts >>>> =================================================================== >>>> --- /dev/null >>>> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts >>>> @@ -0,0 +1,41 @@ >>>> +/* >>>> + * Device Tree Source for the SILK board >>>> + * >>>> + * Copyright (C) 2014 Renesas Electronics Corporation >>>> + * Copyright (C) 2014-2015 Renesas Solutions Corp. >>>> + * Copyright (C) 2014-2015 Cogent Embedded, Inc. >>>> + * >>>> + * This file is licensed under the terms of the GNU General Public License >>>> + * version 2. This program is licensed "as is" without any warranty of any >>>> + * kind, whether express or implied. >>>> + */ >>>> + >>>> +/dts-v1/; >>>> +#include "r8a7794.dtsi" >>>> + >>>> +/ { >>>> + model = "SILK"; >>> Shouldn't that have a "Renesas" prefix or something like that? >> Historically. no SH-Mobile .dts has used the vendor name in the "model" >> prop. I defer the decision to Simon but I think we should be at least >> consistent. > They are also my thoughts (except the bit about deferring to myself). > If there is a good motivation for a Renesas prefix then that is fine by me. > But in that case it seems that it would be appropriate to update > the existing renesas boards too. > The only thing that stood out to me about "SILK" was that unlike > other renesas boards names in .dtsi files it is all-capitals. > Its not a bit deal but as we are on the topic: is that intentional? Yes, it is all uppercase. See e.g. http://www.elinux.org/R-Car/Boards/SILK. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 03, 2015 at 10:53:01AM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 3, 2015 at 1:36 AM, Simon Horman <horms@verge.net.au> wrote: > > The only thing that stood out to me about "SILK" was that unlike > > other renesas boards names in .dtsi files it is all-capitals. > > Its not a bit deal but as we are on the topic: is that intentional? > > Seems like we can use some consistency: > > $ git grep -w model -- $(git grep -l renesas, -- arch/arm/boot/dts) > arch/arm/boot/dts/emev2-kzm9d.dts: model = "EMEV2 KZM9D Board"; > arch/arm/boot/dts/r7s72100-genmai.dts: model = "Genmai"; > arch/arm/boot/dts/r8a73a4-ape6evm.dts: model = "APE6EVM"; > arch/arm/boot/dts/r8a7740-armadillo800eva.dts: model = "armadillo 800 eva"; > arch/arm/boot/dts/r8a7778-bockw-reference.dts: model = "bockw"; > arch/arm/boot/dts/r8a7778-bockw.dts: model = "bockw"; > arch/arm/boot/dts/r8a7779-marzen.dts: model = "marzen"; > arch/arm/boot/dts/r8a7790-lager.dts: model = "Lager"; > arch/arm/boot/dts/r8a7791-henninger.dts: model = "Henninger"; > arch/arm/boot/dts/r8a7791-koelsch.dts: model = "Koelsch"; > arch/arm/boot/dts/r8a7794-alt.dts: model = "Alt"; > arch/arm/boot/dts/sh73a0-kzm9g.dts: model = "KZM-A9-GT"; > $ > > ePAPR says: > > "The recommended format is: “manufacturer,model”, where manufacturer is a > string describing the name of the manufacturer (such as a stock ticker symbol), > and model specifies the model number. > > Example: > model = “fsl,MPC8349EMITX”;" Agree we could use some consistency but before we start cooking up names do we expect this to have any effect on compatibility for users? -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/02/2015 03:19 AM, Simon Horman wrote: >>>> Add the initial device tree for the R8A7794 SoC based SILK low cost board. >>>> SCIF2 serial port support is included, so that the serial console can work. >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> --- >>>> This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon >>>> Horman's 'renesas.git' repo. >>>> arch/arm/boot/dts/Makefile | 1 >>>> arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ >>>> 2 files changed, 42 insertions(+) >> [...] >>>> Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts >>>> =================================================================== >>>> --- /dev/null >>>> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts >>>> @@ -0,0 +1,41 @@ >>>> +/* >>>> + * Device Tree Source for the SILK board >>>> + * >>>> + * Copyright (C) 2014 Renesas Electronics Corporation >>>> + * Copyright (C) 2014-2015 Renesas Solutions Corp. >>>> + * Copyright (C) 2014-2015 Cogent Embedded, Inc. >>>> + * >>>> + * This file is licensed under the terms of the GNU General Public License >>>> + * version 2. This program is licensed "as is" without any warranty of any >>>> + * kind, whether express or implied. >>>> + */ >>>> + >>>> +/dts-v1/; >>>> +#include "r8a7794.dtsi" >>>> + >>>> +/ { >>>> + model = "SILK"; >>>> + compatible = "renesas,silk", "renesas,r8a7794"; >>>> + >>>> + aliases { >>>> + serial0 = &scif2; >>>> + }; >>>> + >>>> + chosen { >>>> + bootargs = "console=ttySC0,38400 ignore_loglevel"; >>> Please remove console= for consistency with other boards >>> based on Renesas SoCs. >> I can't, there will be no console at all. > Its not clear to me why that should be the case when you also have: > stdout-path = &scif2; > Is this a baud issue? Don't think so, I would have seen at least some garbage on the console. There was nothing. I'm still not sure what the problem was... > If so is it possible to set uboot to 115200 bps? Possible with the new board. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: renesas/arch/arm/boot/dts/Makefile =================================================================== --- renesas.orig/arch/arm/boot/dts/Makefile +++ renesas/arch/arm/boot/dts/Makefile @@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme r8a7791-koelsch.dtb \ r8a7791-porter.dtb \ r8a7794-alt.dtb \ + r8a7794-silk.dtb \ sh73a0-kzm9g.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \ socfpga_arria10_socdk.dtb \ Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts =================================================================== --- /dev/null +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts @@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7794.dtsi" + +/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794"; + + aliases { + serial0 = &scif2; + }; + + chosen { + bootargs = "console=ttySC0,38400 ignore_loglevel"; + stdout-path = &scif2; + }; + + memory@40000000 { + device_type = "memory"; + reg = <0 0x40000000 0 0x40000000>; + }; +}; + +&extal_clk { + clock-frequency = <20000000>; +}; + +&scif2 { + status = "okay"; +};
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo. arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html