From patchwork Fri Aug 28 13:55:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 7091891 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 923E19F1C2 for ; Fri, 28 Aug 2015 13:55:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C735C207F7 for ; Fri, 28 Aug 2015 13:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5849205F7 for ; Fri, 28 Aug 2015 13:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbbH1Nzl (ORCPT ); Fri, 28 Aug 2015 09:55:41 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:36160 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbbH1NzN (ORCPT ); Fri, 28 Aug 2015 09:55:13 -0400 Received: by labnh1 with SMTP id nh1so8233614lab.3 for ; Fri, 28 Aug 2015 06:55:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=iI0hv22CSWcPRHjqROrfp4TqXV7tgRs4P4Nz9tbO3Vg=; b=E7cIfvSOcEwoV8ZAqGrVLFOHoUio2j+1LvVqgZwCdm25fg/ad4vp/phnCzEwBNuqwn f35XXaxryNc19yDF9q2vkj1zcYC4U7cTUV8su+THplCftdGevOAPNbCckmkiVKJWXzFj SSC9WH4VrJ0ZT3M/FNssaJLQeFqD/KYVkNXgFKZidJkHCpc7/2TuxXSlty1pJKyn6MxH Xw1g6+3p/Vm7P+XS4RaBPEx3M4ZHPRbu0EI76KN9RDeSRaaxsvWRnVgZIl9bog1OI1M4 1nb6nObNqA4kG+GAg3Pa/Nx3QLbUJPlKlcHXxc6fugUrYPgUF3v/wdbor035F22sUVZt XFLQ== X-Gm-Message-State: ALoCoQn5r8I662gbYC/z/NdtwmAPAJbNclNl3oPCW+aL+8aDhHxy41srbW9Gl0VMnvFQxHHuXtlY X-Received: by 10.112.172.201 with SMTP id be9mr4836450lbc.39.1440770112151; Fri, 28 Aug 2015 06:55:12 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp18-194.pppoe.mtu-net.ru. [81.195.18.194]) by smtp.gmail.com with ESMTPSA id f10sm1432039lae.23.2015.08.28.06.55.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Aug 2015 06:55:11 -0700 (PDT) From: Sergei Shtylyov To: netdev@vger.kernel.org Cc: linux-sh@vger.kernel.org, horms@verge.net.au Subject: [PATCH 1/2] ravb: propagate platform_get_irq() error upstream Date: Fri, 28 Aug 2015 16:55:10 +0300 Message-ID: <1625516.DmSERANoIv@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.9 (Linux/4.1.5-100.fc21.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <9944836.IRPmWk4iN8@wasted.cogentembedded.com> References: <9944836.IRPmWk4iN8@wasted.cogentembedded.com> MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver overrides the error returned by platform_get_irq() with -ENODEV which e.g. precludes the deferred probing from working. Propagate the real error code to the driver core instead. Signed-off-by: Sergei Shtylyov Acked-by: Geert Uytterhoeven --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: net/drivers/net/ethernet/renesas/ravb_main.c =================================================================== --- net.orig/drivers/net/ethernet/renesas/ravb_main.c +++ net/drivers/net/ethernet/renesas/ravb_main.c @@ -1643,7 +1643,7 @@ static int ravb_probe(struct platform_de ndev->dma = -1; irq = platform_get_irq(pdev, 0); if (irq < 0) { - error = -ENODEV; + error = irq; goto out_release; } ndev->irq = irq;