From patchwork Fri Dec 12 19:53:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 5485401 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 52F98BEEA8 for ; Fri, 12 Dec 2014 19:53:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 81CE7201F2 for ; Fri, 12 Dec 2014 19:53:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0F36201EF for ; Fri, 12 Dec 2014 19:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965511AbaLLTxY (ORCPT ); Fri, 12 Dec 2014 14:53:24 -0500 Received: from mail-lb0-f172.google.com ([209.85.217.172]:41515 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933985AbaLLTxW (ORCPT ); Fri, 12 Dec 2014 14:53:22 -0500 Received: by mail-lb0-f172.google.com with SMTP id u10so6542033lbd.3 for ; Fri, 12 Dec 2014 11:53:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:mime-version:content-transfer-encoding:content-type; bh=0zZfeUp5q7cyJgeCqZoameRx5gDwhQbYQ/Q+aq/B8jQ=; b=OCjxM/ryFUaNlmkiZa8hq7ysr60/VrbzQ9bfts+bCNK1UEMqGeZAHoClAfZ0r/LEZH ESw6cSlslLNzexYr4Uq/yCdGCNp9WB2ywr5v+ZqLggoB5xETvytRriUhP2Ao04Xh2FBy LLdxg24v9Zwpu+BbFz7Y1Tj4i4KXimEKB6Q/1/wqz72MJc64jdzk01ed6YiBv7h8DAb4 7z2LiR0YlHfq0Hn5OGPxqKJHQRt1R2x/2Nahr4YubDvDhbDZXlToDbYpFyr0HY5BbG51 P+/tMhdDzk68aSBUjduILzuLtl4cCC9P/FxxP9Q6gKYPqWUIRjWoAlJzY0I7v7vBYi1x 4tNg== X-Gm-Message-State: ALoCoQnCutsRyrLyWxt6rRPwGW+1lwpZlTZFTJXhMMUCVS1ot5+15+Z7DBJDdX5QGxrjdSON0OdQ X-Received: by 10.112.150.136 with SMTP id ui8mr17423972lbb.60.1418414000867; Fri, 12 Dec 2014 11:53:20 -0800 (PST) Received: from wasted.cogentembedded.com (ppp18-99.pppoe.mtu-net.ru. [81.195.18.99]) by mx.google.com with ESMTPSA id ku11sm642226lac.32.2014.12.12.11.53.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Dec 2014 11:53:20 -0800 (PST) From: Sergei Shtylyov To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, balbi@ti.com Cc: linux-sh@vger.kernel.org Subject: [PATCH] renesas_usbhs: kill dead code in usbhs_probe() Date: Fri, 12 Dec 2014 22:53:18 +0300 Message-ID: <1712999.cba28NOnAE@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.3 (Linux/3.17.4-200.fc20.x86_64; KDE/4.14.3; x86_64; ; ) MIME-Version: 1.0 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP usbhsc_drvcllbck_notify_hotplug() always returns 0, so it's rather pointless to store and check its result for being < 0. Signed-off-by: Sergei Shtylyov --- This patch is against the 'next' branch of Felipe Balbi's 'usb.git' repo. drivers/usb/renesas_usbhs/common.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: usb/drivers/usb/renesas_usbhs/common.c =================================================================== --- usb.orig/drivers/usb/renesas_usbhs/common.c +++ usb/drivers/usb/renesas_usbhs/common.c @@ -632,16 +632,12 @@ static int usbhs_probe(struct platform_d /* * manual call notify_hotplug for cold plug */ - ret = usbhsc_drvcllbck_notify_hotplug(pdev); - if (ret < 0) - goto probe_end_call_remove; + usbhsc_drvcllbck_notify_hotplug(pdev); dev_info(&pdev->dev, "probed\n"); return ret; -probe_end_call_remove: - usbhs_platform_call(priv, hardware_exit, pdev); probe_end_mod_exit: usbhs_mod_remove(priv); probe_end_fifo_exit: