| Message ID | 1959578.PFsrHiTtYY@amdc1032 (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 40fca03cae59cfd9b87142ca327abb8a4d386908 |
| Headers | show |
On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote: > __initdata tag should be placed between the variable name and equal > sign for the variable to be placed in the intended .init.data section. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > v2: > - use __initdata as it is OK to do it > > arch/arm/mach-shmobile/board-ape6evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644 > --- a/arch/arm/mach-shmobile/board-ape6evm.c > +++ b/arch/arm/mach-shmobile/board-ape6evm.c > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = { > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"), > }; > > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = { > .buttons = gpio_buttons, > .nbuttons = ARRAY_SIZE(gpio_buttons), > };
On Mon, Sep 30, 2013 at 08:31:05PM +0200, Laurent Pinchart wrote: > On Monday 30 September 2013 17:34:36 Bartlomiej Zolnierkiewicz wrote: > > __initdata tag should be placed between the variable name and equal > > sign for the variable to be placed in the intended .init.data section. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks, I will queue this up. > > > --- > > v2: > > - use __initdata as it is OK to do it > > > > arch/arm/mach-shmobile/board-ape6evm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c > > b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644 > > --- a/arch/arm/mach-shmobile/board-ape6evm.c > > +++ b/arch/arm/mach-shmobile/board-ape6evm.c > > @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = { > > GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"), > > }; > > > > -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { > > +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = { > > .buttons = gpio_buttons, > > .nbuttons = ARRAY_SIZE(gpio_buttons), > > }; > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c index 7627385..8954f55 100644 --- a/arch/arm/mach-shmobile/board-ape6evm.c +++ b/arch/arm/mach-shmobile/board-ape6evm.c @@ -86,7 +86,7 @@ static struct gpio_keys_button gpio_buttons[] = { GPIO_KEY(KEY_VOLUMEDOWN, 329, "S21"), }; -static struct __initdata gpio_keys_platform_data ape6evm_keys_pdata = { +static struct gpio_keys_platform_data ape6evm_keys_pdata __initdata = { .buttons = gpio_buttons, .nbuttons = ARRAY_SIZE(gpio_buttons), };