From patchwork Mon Aug 20 03:13:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Mundt X-Patchwork-Id: 1345571 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 11F88DF25A for ; Mon, 20 Aug 2012 03:14:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824Ab2HTDOF (ORCPT ); Sun, 19 Aug 2012 23:14:05 -0400 Received: from linux-sh.org ([111.68.239.195]:38611 "EHLO linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492Ab2HTDOE (ORCPT ); Sun, 19 Aug 2012 23:14:04 -0400 Received: from linux-sh.org (localhost.localdomain [127.0.0.1]) by linux-sh.org (8.14.5/8.14.4) with ESMTP id q7K3DrCj032669; Mon, 20 Aug 2012 12:13:53 +0900 Received: (from pmundt@localhost) by linux-sh.org (8.14.5/8.14.4/Submit) id q7K3Drlr032667; Mon, 20 Aug 2012 12:13:53 +0900 X-Authentication-Warning: linux-sh.org: pmundt set sender to lethal@linux-sh.org using -f Date: Mon, 20 Aug 2012 12:13:52 +0900 From: Paul Mundt To: Kuninori Morimoto Cc: Tetsuyuki Kobayashi , Magnus , linux-sh@vger.kernel.org, Kuninori Morimoto Subject: Re: kzm9g boot fail (was Re: irqdomain breaks ap4 boot) Message-ID: <20120820031352.GC25767@linux-sh.org> References: <878vdxd3mq.wl%kuninori.morimoto.gx@renesas.com> <20120803050039.GA1614@linux-sh.org> <20120809042844.GF1614@linux-sh.org> <87hasc3bv5.wl%kuninori.morimoto.gx@renesas.com> <874nobqntv.wl%kuninori.morimoto.gx@renesas.com> <20120810123804.GK1614@linux-sh.org> <502DDC97.5080501@kmckk.co.jp> <87wr0us6tg.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87wr0us6tg.wl%kuninori.morimoto.gx@renesas.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Sun, Aug 19, 2012 at 06:14:41PM -0700, Kuninori Morimoto wrote: > > Hi Paul > > Thank you for your patch > > > > diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c > > > index 32c26d7..8f32a13 100644 > > > --- a/drivers/sh/intc/core.c > > > +++ b/drivers/sh/intc/core.c > > > @@ -355,7 +355,7 @@ int __init register_intc_controller(struct intc_desc *desc) > > > if (unlikely(res)) { > > > if (res == -EEXIST) { > > > res = irq_domain_associate(d->domain, > > > - irq, irq); > > > + irq2, irq2); > > > if (unlikely(res)) { > > > pr_err("domain association " > > > "failure\n"); > > > > I tried this patch but there is still the same error. > > I checked quickly by debugger, and I found the failing > > irq_domain_associate() is not called here (line 357) but the one at line > > 328. > > But, I got same result. > > This WARNING is indicating > > intc: domain association failure > > So, as kobayashi-san said, > it has happend on previous irq_domain_associate(), not here. > Can you post a boot log with the pr_debug() output in the irqdomain code enabled? You may need to add ignore_loglevel to your kernel command line. If that doesn't produce any further clues I'll have to find one of these boards to see what's going on. --- -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 49a7772..3b39c0e 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -1,5 +1,7 @@ #define pr_fmt(fmt) "irq: " fmt +#define DEBUG + #include #include #include