From patchwork Fri Feb 1 10:58:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 2079121 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 7CF1FDFE75 for ; Fri, 1 Feb 2013 10:58:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755331Ab3BAK66 (ORCPT ); Fri, 1 Feb 2013 05:58:58 -0500 Received: from service87.mimecast.com ([91.220.42.44]:58985 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069Ab3BAK6y convert rfc822-to-8bit (ORCPT ); Fri, 1 Feb 2013 05:58:54 -0500 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 01 Feb 2013 10:58:52 +0000 Received: from e106331-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Fri, 1 Feb 2013 10:58:49 +0000 Date: Fri, 1 Feb 2013 10:58:49 +0000 From: Mark Rutland To: Simon Horman Cc: Simon Horman , "linux-sh@vger.kernel.org" , Magnus Damm , "linux-arm-kernel@lists.infradead.org" , Grant Likely , Rob Herring Subject: Re: [PATCH 2/4] ARM: mach-shmobile: r8a7779: Allow initialisation of GIC by DT Message-ID: <20130201105849.GB21191@e106331-lin.cambridge.arm.com> References: <1359597051-32700-1-git-send-email-horms+renesas@verge.net.au> <1359597051-32700-3-git-send-email-horms+renesas@verge.net.au> <20130131123213.GB7235@e106331-lin.cambridge.arm.com> <20130201001119.GO10312@verge.net.au> <20130201003410.GA30007@verge.net.au> MIME-Version: 1.0 In-Reply-To: <20130201003410.GA30007@verge.net.au> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginalArrivalTime: 01 Feb 2013 10:58:49.0927 (UTC) FILETIME=[1DA66D70:01CE006B] X-MC-Unique: 113020110585205601 Content-Disposition: inline Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Fri, Feb 01, 2013 at 12:34:10AM +0000, Simon Horman wrote: > On Fri, Feb 01, 2013 at 09:11:19AM +0900, Simon Horman wrote: > > On Thu, Jan 31, 2013 at 12:32:13PM +0000, Mark Rutland wrote: > > > Hi Simon, > > > > > > On Thu, Jan 31, 2013 at 01:50:49AM +0000, Simon Horman wrote: > > > > This allows the GIC interrupt controller of the r8a7779 SoC to be > > > > initialised using a flattened device tree blob. > > > > > > > > Signed-off-by: Simon Horman > > > > --- > > > > arch/arm/boot/dts/r8a7779.dtsi | 40 ++++++++++++++++++++++++++ > > > > arch/arm/mach-shmobile/include/mach/common.h | 1 + > > > > arch/arm/mach-shmobile/intc-r8a7779.c | 27 +++++++++++++---- > > > > 3 files changed, 62 insertions(+), 6 deletions(-) > > > > create mode 100644 arch/arm/boot/dts/r8a7779.dtsi > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi > > > > new file mode 100644 > > > > index 0000000..eadc12e > > > > --- /dev/null > > > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > > > @@ -0,0 +1,40 @@ > > > > +/* > > > > + * Device Tree Source for Renesas r8a7740 > > > > + * > > > > + * Copyright (C) 2013 Renesas Solutions Corp. > > > > + * Copyright (C) 2013 Simon Horman > > > > + * > > > > + * This file is licensed under the terms of the GNU General Public License > > > > + * version 2. This program is licensed "as is" without any warranty of any > > > > + * kind, whether express or implied. > > > > + */ > > > > + > > > > +/include/ "skeleton.dtsi" > > > > + > > > > +/ { > > > > + compatible = "renesas,r8a7779"; > > > > + > > > > + cpus { > > > > + cpu@0 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + cpu@1 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + cpu@2 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + cpu@3 { > > > > + compatible = "arm,cortex-a9"; > > > > + }; > > > > + }; > > > > > > Sorry to sound like a broken record, but it'd be good to see reg and > > > device_type set here. > > > > Sure, will do. > > > > > > + > > > > + gic: interrupt-controller@f0001000 { > > > > + compatible = "arm,cortex-a9-gic"; > > > > + #interrupt-cells = <3>; > > > > + #address-cells = <1>; > > > > > > Why is #address-cells needed here (and without #size-cells)? I see it's in the > > > binding document example, but I can't figure out why. > > > > Its here because I copied the example. > > I will see about removing it from here. Rob, Grant, do either of you know if there's a reason for this that we've missed? The gic doesn't have any direct children, and this doesn't seem to be some decvicetree interrupt-controller magic. If this is superfluous, how about the patch below? I took a quick look at arch/arm/boot/dts/. Some gic nodes don't have #address-cells, some have it but not #size-cells, and some have both. These should probably be cleaned up too. [...] Thanks, Mark. ---->8---- From dc734edb8040513785429c11e40a420870dc55a4 Mon Sep 17 00:00:00 2001 From: Mark Rutland Date: Fri, 1 Feb 2013 10:18:05 +0000 Subject: [PATCH] Docs: gic: remove #address-cells from example The gic has no child nodes, and so doesn't need #address-cells. Having the property defined in the example only serves as a source of confusion. Signed-off-by: Mark Rutland --- Documentation/devicetree/bindings/arm/gic.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/gic.txt b/Documentation/devicetree/bindings/arm/gic.txt index 62eb8df..45b99ab 100644 --- a/Documentation/devicetree/bindings/arm/gic.txt +++ b/Documentation/devicetree/bindings/arm/gic.txt @@ -54,7 +54,6 @@ Example: intc: interrupt-controller@fff11000 { compatible = "arm,cortex-a9-gic"; #interrupt-cells = <3>; - #address-cells = <1>; interrupt-controller; reg = <0xfff11000 0x1000>, <0xfff10100 0x100>;