From patchwork Tue Apr 9 22:36:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 2418171 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id DC29C3FC71 for ; Tue, 9 Apr 2013 22:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765335Ab3DIWhy (ORCPT ); Tue, 9 Apr 2013 18:37:54 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:37290 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299Ab3DIWhx (ORCPT ); Tue, 9 Apr 2013 18:37:53 -0400 Received: by mail-lb0-f182.google.com with SMTP id z13so7383925lbh.27 for ; Tue, 09 Apr 2013 15:37:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:to:subject:from:organization:date:mime-version :content-type:content-transfer-encoding:message-id :x-gm-message-state; bh=q6EnlDqlOQZ6EirYE1+gtoL4c+HqWll6KiP9riXV+oc=; b=GcUEG55cnfP4X27ETvFZ+lXd+Gr+j14XUA5PV+hnSEuL3bywbp89tsDTgds5yEX+jg wtsJT553+/i9RWAQty4zDWtvIxgUGQOSJRXWmQdEk++VO0m6N64ZkxlS561f3np6+Skq ST7rO8VhTpFJpwVJ6e5vf9NqLw6T+qRvCYMbzXh/RWBMpDSSO0gl47Q/4q7mxSHowuqn /5rNb4TUZnYiUec0VoQS4gJ6MOdkkkWvv13gKgvf1x1a8fz2K1LsVNK994cwoUpJaQqL ivMihldmjzFJUc5zItQgpT2WXkg1vnqlY0GYHlBoDD2vYcAYoJBM/WfkB1v5+P/s4K6/ Orsw== X-Received: by 10.152.125.239 with SMTP id mt15mr15056358lab.26.1365547071515; Tue, 09 Apr 2013 15:37:51 -0700 (PDT) Received: from wasted.dev.rtsoft.ru (ppp91-79-87-206.pppoe.mtu-net.ru. [91.79.87.206]) by mx.google.com with ESMTPS id c7sm13096064lbe.6.2013.04.09.15.37.49 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 09 Apr 2013 15:37:50 -0700 (PDT) To: horms@verge.net.au, magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, balbi@ti.com Subject: [PATCH v3 6/9] rcar-phy: correct base address From: Sergei Shtylyov Organization: Cogent Embedded Date: Wed, 10 Apr 2013 02:36:50 +0400 MIME-Version: 1.0 Message-Id: <201304100236.50822.sergei.shtylyov@cogentembedded.com> X-Gm-Message-State: ALoCoQn1Xu5zvojKkqu06K/Ag44YBzaaeNuqHL/DhLabi747bLjRMdxboJUFLVDozdFu1gAsW4ek Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org The memory region that is used by the driver overlaps EHCI and OHCI register regions for absolutely no reason now -- fix it by adding offset of 0x800 to the base address, changing the register #define's accordingly. This has extra positive effect that we now can use devm_ioremap_resource()... Note that the driver and the SoC code have to be in one patch to keep the code bisectable... The patch has been tested on the Marzen board. Signed-off-by: Sergei Shtylyov Acked-by: Kuninori Morimoto Acked-by: Simon Horman Acked-by: Felipe Balbi --- Changes since version 2: - refreshed atop of the prior patches; - added a note about testing to the changelog; - added ACKs from Simon Horman and Kuninori Morimoto. Changes since the original posting: - added a note about bisectability to the changelog. arch/arm/mach-shmobile/setup-r8a7779.c | 2 +- drivers/usb/phy/rcar-phy.c | 28 ++++++++++------------------ 2 files changed, 11 insertions(+), 19 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: renesas/arch/arm/mach-shmobile/setup-r8a7779.c =================================================================== --- renesas.orig/arch/arm/mach-shmobile/setup-r8a7779.c +++ renesas/arch/arm/mach-shmobile/setup-r8a7779.c @@ -402,7 +402,7 @@ static struct platform_device sata_devic /* USB PHY */ static struct resource usb_phy_resources[] = { [0] = { - .start = 0xffe70000, + .start = 0xffe70800, .end = 0xffe70900 - 1, .flags = IORESOURCE_MEM, }, Index: renesas/drivers/usb/phy/rcar-phy.c =================================================================== --- renesas.orig/drivers/usb/phy/rcar-phy.c +++ renesas/drivers/usb/phy/rcar-phy.c @@ -16,13 +16,13 @@ #include #include -/* USBH common register */ -#define USBPCTRL0 0x0800 -#define USBPCTRL1 0x0804 -#define USBST 0x0808 -#define USBEH0 0x080C -#define USBOH0 0x081C -#define USBCTL0 0x0858 +/* REGS block */ +#define USBPCTRL0 0x00 +#define USBPCTRL1 0x04 +#define USBST 0x08 +#define USBEH0 0x0C +#define USBOH0 0x1C +#define USBCTL0 0x58 /* USBPCTRL1 */ #define PHY_RST (1 << 2) @@ -139,17 +139,9 @@ static int rcar_usb_phy_probe(struct pla return -EINVAL; } - /* - * CAUTION - * - * Because this phy address is also mapped under OHCI/EHCI address area, - * this driver can't use devm_request_and_ioremap(dev, res) here - */ - reg0 = devm_ioremap_nocache(dev, res0->start, resource_size(res0)); - if (!reg0) { - dev_err(dev, "ioremap error\n"); - return -ENOMEM; - } + reg0 = devm_ioremap_resource(dev, res0); + if (IS_ERR(reg0)) + return PTR_ERR(reg0); priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) {