From patchwork Thu Dec 19 22:41:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 3384471 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4DDF0C0D4A for ; Thu, 19 Dec 2013 21:41:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 49F4320115 for ; Thu, 19 Dec 2013 21:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54F9A200F7 for ; Thu, 19 Dec 2013 21:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756601Ab3LSVlG (ORCPT ); Thu, 19 Dec 2013 16:41:06 -0500 Received: from mail-lb0-f176.google.com ([209.85.217.176]:38889 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756314Ab3LSVlF (ORCPT ); Thu, 19 Dec 2013 16:41:05 -0500 Received: by mail-lb0-f176.google.com with SMTP id l4so720507lbv.7 for ; Thu, 19 Dec 2013 13:41:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=NDAjuOePxyaFtxs6EftftV95nGnpsjVhxFxruAaZu7w=; b=UklkCSHlwsvmZEbBIFunvaFNuvOWmjYeVGj34M7gRa3k72D/o6RWv7GLM2W8oquOAd jLGa1Zg0yWSjiqcp+jZlfz3In4NIeP0X2pS3EVeJVDrnwH3qBLWiapeJXgmumlFS3+Bz xyFQdJKpsEx3YVwxbhWg1ZhLs4MhOjUWgvwl721xIJ9Gvu4G9IkdEiRYXE16bHUeQ/vT L3aullxq7J5XpyuCUipm4gowZXptKab9umP/HOxRHp8vVT4t+cEGuUfbMxBaiJhgd0jp v+/7FScCe/6V7rcTxtg5RNzsXq14bo8AGyo3631y0PK+W/OKt0BJF0q66L9zkThNH7jz Pg6w== X-Gm-Message-State: ALoCoQkfk5HIjXZsTFllLo+S0moGBYWok4uk4YkoXHcBGp4eVt5CHHTuH1OeCjI8Du5LwYKymGsX X-Received: by 10.152.180.66 with SMTP id dm2mr5709lac.88.1387489263360; Thu, 19 Dec 2013 13:41:03 -0800 (PST) Received: from wasted.dev.rtsoft.ru (ppp91-76-87-169.pppoe.mtu-net.ru. [91.76.87.169]) by mx.google.com with ESMTPSA id r10sm4116777lag.7.2013.12.19.13.41.02 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 19 Dec 2013 13:41:02 -0800 (PST) From: Sergei Shtylyov Organization: Cogent Embedded To: netdev@vger.kernel.org Subject: [PATCH 2/2] sh_eth: do not reset PHY needlessly Date: Fri, 20 Dec 2013 01:41:12 +0300 User-Agent: KMail/1.13.5 (Linux/2.6.32.26-175.fc12.i686.PAE; KDE/4.4.5; i686; ; ) Cc: linux-sh@vger.kernel.org References: <201312200138.09307.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201312200138.09307.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Message-Id: <201312200141.12586.sergei.shtylyov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no need anymore to call phy_init_hw() to reset/resume the PHY from the driver, as the call chain in phylib already has reached it, and so reset/resumed the PHY (even resuming it twice). This duplicate reset is not only needless, it e.g. clears the PHY's interrupt enables just setup by phylib and so prevents the expected IRQs from the PHY. Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 5 ----- 1 file changed, 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: net-next/drivers/net/ethernet/renesas/sh_eth.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c +++ net-next/drivers/net/ethernet/renesas/sh_eth.c @@ -1703,11 +1703,6 @@ static int sh_eth_phy_start(struct net_d if (ret) return ret; - /* reset phy - this also wakes it from PDOWN */ - ret = phy_init_hw(mdp->phydev); - if (ret) - return ret; - phy_start(mdp->phydev); return 0;