From patchwork Sat Feb 22 01:29:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 3700721 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F0917BF13A for ; Sat, 22 Feb 2014 00:29:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2F75E2017D for ; Sat, 22 Feb 2014 00:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21AE420145 for ; Sat, 22 Feb 2014 00:29:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbaBVA3K (ORCPT ); Fri, 21 Feb 2014 19:29:10 -0500 Received: from mail-la0-f49.google.com ([209.85.215.49]:54218 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753395AbaBVA3K (ORCPT ); Fri, 21 Feb 2014 19:29:10 -0500 Received: by mail-la0-f49.google.com with SMTP id y1so2911047lam.22 for ; Fri, 21 Feb 2014 16:29:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:cc:from:organization:date :mime-version:content-type:content-transfer-encoding:message-id; bh=Ma1f6ZdV3FbbZ++OcKsF3Ws8lsqR3HAyZPxZybyu+NI=; b=B2leGiSthbGasN85SOZxSmmmcVK5noJfolmtizAVVS8hCIvDQGv9ZPnVvZwdX9A/0U PaoGXstZePZMVx2sFujPSZD2Ys5PmLmXEmApZpJuFzuDwxjyPf0hmXm6yMUJIiMJEHh6 Mc5sdx6Z9/6jmeEpFUbc8mgOdf2IuZ49JFHr8xjmFWznJuuxARiod+Dbq3XSGLArFK7h YM7rtdiR+ROUOfkADqFvwNwPQuLaeaw/30dPXjggfY6wq7Aq27Xj6USmkuFmu43LXtMF gYYrz71QGHUEbANeeid4jwn7rW2K+5/eKuzk3paXwWlMh6vi0brT18eB2+JP56HQQJcs q70A== X-Gm-Message-State: ALoCoQm9eSAuiBWoJaBHD6hAURq9eE0Kq7VR7g0i7+TFjcX2aOB7zpV1ov82kZ5wlfIEGHas/on7 X-Received: by 10.152.88.82 with SMTP id be18mr5729137lab.3.1393028948312; Fri, 21 Feb 2014 16:29:08 -0800 (PST) Received: from wasted.cogentembedded.com (ppp83-237-61-192.pppoe.mtu-net.ru. [83.237.61.192]) by mx.google.com with ESMTPSA id h7sm9401968lbj.1.2014.02.21.16.29.07 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 21 Feb 2014 16:29:07 -0800 (PST) To: balbi@ti.com, linux-usb@vger.kernel.org Subject: [PATCH] phy-rcar-gen2-usb: always use 'dev' variable in probe() method Cc: gregkh@linuxfoundation.org, linux-sh@vger.kernel.org, valentine.barshak@cogentembedded.com From: Sergei Shtylyov Organization: Cogent Embedded Date: Sat, 22 Feb 2014 04:29:15 +0300 MIME-Version: 1.0 Message-Id: <201402220429.15888.sergei.shtylyov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The probe() method has the 'dev' local variable declared and used but strangely not in all cases where it should be... Signed-off-by: Sergei Shtylyov --- This patch is against the 'next' branch of Felipe Balbi's 'usb.git' repo. drivers/usb/phy/phy-rcar-gen2-usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: usb/drivers/usb/phy/phy-rcar-gen2-usb.c =================================================================== --- usb.orig/drivers/usb/phy/phy-rcar-gen2-usb.c +++ usb/drivers/usb/phy/phy-rcar-gen2-usb.c @@ -177,15 +177,15 @@ static int rcar_gen2_usb_phy_probe(struc struct clk *clk; int retval; - pdata = dev_get_platdata(&pdev->dev); + pdata = dev_get_platdata(dev); if (!pdata) { dev_err(dev, "No platform data\n"); return -EINVAL; } - clk = devm_clk_get(&pdev->dev, "usbhs"); + clk = devm_clk_get(dev, "usbhs"); if (IS_ERR(clk)) { - dev_err(&pdev->dev, "Can't get the clock\n"); + dev_err(dev, "Can't get the clock\n"); return PTR_ERR(clk); }