From patchwork Wed Apr 9 21:32:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 3957681 Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6475DBFF02 for ; Wed, 9 Apr 2014 21:32:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7CA472063F for ; Wed, 9 Apr 2014 21:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CE5620592 for ; Wed, 9 Apr 2014 21:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934389AbaDIVcd (ORCPT ); Wed, 9 Apr 2014 17:32:33 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:64957 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934378AbaDIVcc (ORCPT ); Wed, 9 Apr 2014 17:32:32 -0400 Received: by mail-la0-f44.google.com with SMTP id c6so1661594lan.3 for ; Wed, 09 Apr 2014 14:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:cc:from:organization:date :mime-version:content-type:content-transfer-encoding:message-id; bh=QKob79A6vVbNsuVpdUcUPZBCmFm09kk19O4f9GmH+08=; b=OuKxnQgQuNAyLW0+B9lwqjo2vyzaNqqyM2iE4bRKkrKvWJOoC8bSUMiW/U/CzQcwCx 8jKpVCMFfl+pQbYjzKN2yUei4T8zbiq7TxAikeJ7mjT5hK/Rccg/+xiU0ofzENGeOney AHbG4+NuRQ1zbSE/adsr3AJQDDHmUkW7A26tO9TcOJ2G54uRArOw4WXlEpJ1QpuZ0PtI vF/tO1QF0hzfg89JRFJXxtcG/BBxo1AJA8Q/Wv7jzyz7dWfkWgSPCkEIlq00UnUFHE+0 4W6hnNdLkx05zV8YoiCPqVlNFQs1DhM39/cshp4K5y0njsjLZvNp4ZR6Sbv1o0zvrjDX R48g== X-Gm-Message-State: ALoCoQnbr60NRBPR0JuRPEqubEXJUDp/80swAbQqKOOlOcgbs8SR6OlE3uLYfzFjzGdV03OfYmA0 X-Received: by 10.152.1.8 with SMTP id 8mr9106358lai.1.1397079151284; Wed, 09 Apr 2014 14:32:31 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp85-140-143-17.pppoe.mtu-net.ru. [85.140.143.17]) by mx.google.com with ESMTPSA id q8sm1741151lbr.3.2014.04.09.14.32.30 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 09 Apr 2014 14:32:30 -0700 (PDT) To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Subject: [PATCH v2] usb: hcd: add generic PHY support Cc: linux-sh@vger.kernel.org, magnus.damm@gmail.com From: Sergei Shtylyov Organization: Cogent Embedded Date: Thu, 10 Apr 2014 01:32:38 +0400 MIME-Version: 1.0 Message-Id: <201404100132.39469.sergei.shtylyov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add the generic PHY support, analogous to the USB PHY support. Intended it to be used with the PCI EHCI/OHCI drivers and the xHCI platform driver. Signed-off-by: Sergei Shtylyov --- This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. Changes in version 2: - renamed the new 'phy' field of 'struct usb_phy' to 'gen_phy'; - resolved rejects due to removal of the first patch in the series. drivers/usb/core/hcd.c | 42 ++++++++++++++++++++++++++++++++++++++++-- include/linux/usb/hcd.h | 3 ++- 2 files changed, 42 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: usb/drivers/usb/core/hcd.c =================================================================== --- usb.orig/drivers/usb/core/hcd.c +++ usb/drivers/usb/core/hcd.c @@ -42,6 +42,7 @@ #include #include +#include #include #include #include @@ -2623,6 +2624,29 @@ int usb_add_hcd(struct usb_hcd *hcd, } } + if (IS_ENABLED(CONFIG_GENERIC_PHY)) { + struct phy *phy = phy_get(hcd->self.controller, "usb"); + + if (IS_ERR(phy)) { + retval = PTR_ERR(phy); + if (retval == -EPROBE_DEFER) + goto err_phy; + } else { + retval = phy_init(phy); + if (retval) { + phy_put(phy); + goto err_phy; + } + retval = phy_power_on(phy); + if (retval) { + phy_exit(phy); + phy_put(phy); + goto err_phy; + } + hcd->gen_phy = phy; + } + } + dev_info(hcd->self.controller, "%s\n", hcd->product_desc); /* Keep old behaviour if authorized_default is not in [0, 1]. */ @@ -2638,7 +2662,7 @@ int usb_add_hcd(struct usb_hcd *hcd, */ if ((retval = hcd_buffer_create(hcd)) != 0) { dev_dbg(hcd->self.controller, "pool alloc failed\n"); - goto err_remove_phy; + goto err_create_buf; } if ((retval = usb_register_bus(&hcd->self)) < 0) @@ -2763,7 +2787,14 @@ err_allocate_root_hub: usb_deregister_bus(&hcd->self); err_register_bus: hcd_buffer_destroy(hcd); -err_remove_phy: +err_create_buf: + if (IS_ENABLED(CONFIG_GENERIC_PHY) && hcd->gen_phy) { + phy_power_off(hcd->gen_phy); + phy_exit(hcd->gen_phy); + phy_put(hcd->gen_phy); + hcd->gen_phy = NULL; + } +err_phy: if (hcd->remove_phy && hcd->phy) { usb_phy_shutdown(hcd->phy); usb_put_phy(hcd->phy); @@ -2841,6 +2872,13 @@ void usb_remove_hcd(struct usb_hcd *hcd) usb_put_dev(hcd->self.root_hub); usb_deregister_bus(&hcd->self); hcd_buffer_destroy(hcd); + + if (IS_ENABLED(CONFIG_GENERIC_PHY) && hcd->gen_phy) { + phy_power_off(hcd->gen_phy); + phy_exit(hcd->gen_phy); + phy_put(hcd->gen_phy); + hcd->gen_phy = NULL; + } if (hcd->remove_phy && hcd->phy) { usb_phy_shutdown(hcd->phy); usb_put_phy(hcd->phy); Index: usb/include/linux/usb/hcd.h =================================================================== --- usb.orig/include/linux/usb/hcd.h +++ usb/include/linux/usb/hcd.h @@ -106,7 +106,8 @@ struct usb_hcd { * OTG and some Host controllers need software interaction with phys; * other external phys should be software-transparent */ - struct usb_phy *phy; + struct usb_phy *phy; + struct phy *gen_phy; /* Flags that need to be manipulated atomically because they can * change while the host controller is running. Always use