From patchwork Wed Jul 15 01:16:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 6790891 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 838819F2E8 for ; Wed, 15 Jul 2015 01:16:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A810C206AC for ; Wed, 15 Jul 2015 01:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91C5C20698 for ; Wed, 15 Jul 2015 01:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbbGOBQO (ORCPT ); Tue, 14 Jul 2015 21:16:14 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:57395 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719AbbGOBQO (ORCPT ); Tue, 14 Jul 2015 21:16:14 -0400 Received: from ayumi.isobedori.kobe.vergenet.net (p7166-ipbfp1503kobeminato.hyogo.ocn.ne.jp [114.153.234.166]) by kirsty.vergenet.net (Postfix) with ESMTPSA id 4DF3325B73F; Wed, 15 Jul 2015 11:16:12 +1000 (AEST) Received: by ayumi.isobedori.kobe.vergenet.net (Postfix, from userid 7100) id E0BCAEDEAA3; Wed, 15 Jul 2015 10:16:10 +0900 (JST) Date: Wed, 15 Jul 2015 10:16:10 +0900 From: Simon Horman To: Magnus Damm Cc: linux-sh@vger.kernel.org, laurent.pinchart+renesas@ideasonboard.com, geert+renesas@glider.be Subject: Re: [PATCH v3 00/04] ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 Message-ID: <20150715011610.GB19024@verge.net.au> References: <20150713061450.25534.96315.sendpatchset@little-apple> <20150715002501.GF30642@verge.net.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150715002501.GF30642@verge.net.au> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Magnus, On Wed, Jul 15, 2015 at 09:25:01AM +0900, Simon Horman wrote: > Hi Magnus, > > On Mon, Jul 13, 2015 at 03:14:50PM +0900, Magnus Damm wrote: > > ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3 > > > > [PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops > > [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code > > [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig > > [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file > > > > This series is simply resending the remaining r8a7779 multiplatform > > cleanup patches. The code has not changed since V2: > > > > [PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2 > > > > With these patches applied the r8a7779 SoC gets DT-only multiplatform > > support and old C board code for multiplatform gets removed. > > > > The legacy r8a7779 Marzen code is not touched by this series, but > > with these patches applied basic r8a7779 multiplatform SoC support > > is done and only a few I/O devices are legacy-only. > > Thanks, I have queued these up. > > Please send a follow-up patch to address Geert's observation that > CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig. Unfortunately I have noticed a problem with patch 02/04, and in particular the following portion of it: trouble as the fixed regulator is used by many devices on many boards. I wonder if the best way forwards would be to simply enable REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably multi_v7_defconfig too). --- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -89,13 +89,6 @@ config ARCH_SH73A0 select ARCH_RMOBILE select RENESAS_INTC_IRQPIN -comment "Renesas ARM SoCs Board Type" - -config MACH_MARZEN - bool "MARZEN board" - depends on ARCH_R8A7779 - select REGULATOR_FIXED_VOLTAGE if REGULATOR - It appears that with the above applied REGULATOR_FIXED_VOLTAGE is no longer set after make shmobile_defconfig which causes all sorts of