From patchwork Tue Jul 21 02:31:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 6831951 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 303C1C05AC for ; Tue, 21 Jul 2015 02:31:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 184D6206B6 for ; Tue, 21 Jul 2015 02:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AF49206B2 for ; Tue, 21 Jul 2015 02:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbbGUCbT (ORCPT ); Mon, 20 Jul 2015 22:31:19 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34702 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753292AbbGUCbS (ORCPT ); Mon, 20 Jul 2015 22:31:18 -0400 Received: by pacan13 with SMTP id an13so111760692pac.1 for ; Mon, 20 Jul 2015 19:31:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=BZPY2q0xwb7HlkXS5qphX8JJNOrmXrz0r7sMpLh1ZUI=; b=S68Sj7e2UyzwJWbQOr6NsvYIetLbC+bXMUcal+TkKrzrWDoC0OvnzYcwtzmkX9VUCd 3jQ69S1au7nji7B7ZDUHdAArX8C0OTy5rFnQ8AnVJ1wC87vc+hks0mp0L4Kg9M+Ly5h1 My9TGLRD8NU6xEO4Ni5ZvbrFmjq7gO9xg+DpXxndidQ+pJ6JGmbO52A+DBjxy/15dO8k xpFCEIzW/1daR6VyBNVK5IcugcYAOCaJRrPfxE6GwBZdAmJpfGbHdrKXLXT1kTeJ9mH+ LM5Kldo70O2H9E9OD5UJyPrzY5XL3wOeyggvq+AsfaBydneKdIzNri1wsRoeDRpzV18e /6Qw== X-Gm-Message-State: ALoCoQlRY3qgJ9r30Jw9vtka4/UfizjJZLKET7mxET9G5tZ7irWooWc3BcpOchVtStJhaE+NZNl2 X-Received: by 10.66.119.105 with SMTP id kt9mr67996580pab.86.1437445878350; Mon, 20 Jul 2015 19:31:18 -0700 (PDT) Received: from localhost ([122.171.186.190]) by smtp.gmail.com with ESMTPSA id ca13sm1621215pac.25.2015.07.20.19.31.17 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 20 Jul 2015 19:31:17 -0700 (PDT) Date: Tue, 21 Jul 2015 08:01:14 +0530 From: Viresh Kumar To: Guenter Roeck Cc: Daniel Lezcano , Laurent Pinchart , Linux-sh list , "linux-kernel@vger.kernel.org" Subject: Re: Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' Message-ID: <20150721023114.GD4994@linux> References: <55AD6314.2050000@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <55AD6314.2050000@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 20-07-15, 14:07, Guenter Roeck wrote: > Hi, > > Commit 991a7f4970ed1 ("clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface") > in -next causes the following traceback. This is seen with qemu runs for the sh target. > > ------------[ cut here ]------------ > WARNING: at drivers/clocksource/sh_tmu.c:202 > Modules linked in: Can you please try this: Tested-by: Geert Uytterhoeven diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c index 43c98143f79a..469e776ec17a 100644 --- a/drivers/clocksource/sh_tmu.c +++ b/drivers/clocksource/sh_tmu.c @@ -362,7 +362,8 @@ static int sh_tmu_clock_event_shutdown(struct clock_event_device *ced) { struct sh_tmu_channel *ch = ced_to_sh_tmu(ced); - sh_tmu_disable(ch); + if (clockevent_state_oneshot(ced) || clockevent_state_periodic(ced)) + sh_tmu_disable(ch); return 0; }