From patchwork Fri Aug 28 00:38:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 7088901 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 64061BEEC1 for ; Fri, 28 Aug 2015 00:39:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9078720A07 for ; Fri, 28 Aug 2015 00:39:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7210A20A05 for ; Fri, 28 Aug 2015 00:39:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751313AbbH1Ai5 (ORCPT ); Thu, 27 Aug 2015 20:38:57 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:36587 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbbH1Aiz (ORCPT ); Thu, 27 Aug 2015 20:38:55 -0400 Received: from reginn.isobedori.kobe.vergenet.net (p7129-ipbfp904kobeminato.hyogo.ocn.ne.jp [118.10.130.129]) by kirsty.vergenet.net (Postfix) with ESMTPA id C68F125B73F; Fri, 28 Aug 2015 10:38:52 +1000 (AEST) Received: by reginn.isobedori.kobe.vergenet.net (Postfix, from userid 7100) id 03BD794021F; Fri, 28 Aug 2015 09:38:52 +0900 (JST) Date: Fri, 28 Aug 2015 09:38:52 +0900 From: Simon Horman To: Geert Uytterhoeven Cc: Linux-sh list , Yoshihiro Shimoda , Magnus Damm , Ulrich Hecht , Sergei Shtylyov Subject: Re: [PATCH/RFC 02/10] arm64: defconfig: Enable GPIO of Renesas R-Car Gen3 SoC Message-ID: <20150828003851.GB7357@verge.net.au> References: <1440667450-3513-1-git-send-email-horms+renesas@verge.net.au> <1440667450-3513-3-git-send-email-horms+renesas@verge.net.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Aug 27, 2015 at 12:52:13PM +0200, Geert Uytterhoeven wrote: > On Thu, Aug 27, 2015 at 11:24 AM, Simon Horman > wrote: > > From: Takeshi Kihara > > > > Enable GPIO for Renesas R-Car Gen3 SoC via the following options: > > - GPIO_SYSFS > > - GPIO_RCAR > > - LEDS_GPIO > > > > Signed-off-by: Takeshi Kihara > > [horms: updated changelog] > > Signed-off-by: Simon Horman > > --- > > arch/arm64/configs/defconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index a2ddca9c632b..e7b638eb5059 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -124,7 +124,9 @@ CONFIG_VIRTIO_CONSOLE=y > > CONFIG_SPI=y > > CONFIG_SPI_PL022=y > > CONFIG_PINCTRL_MSM8916=y > > +CONFIG_GPIO_SYSFS=y > > Do we really need GPIO_SYSFS? Almost certainly not. Looking over the patch again this morning I think we also do not need LEDS_GPIO as the leds do not appear to be enabled at this time. I have revised the local version of this patch to only enable GPIO_RCAR. My assumption is that Ulrich will take over this (albeit trivial) patch. For reference this is what I tested just now: From: Takeshi Kihara Subject: [PATCH/RFC v1.1] arm64: defconfig: Enable GPIO of Renesas R-Car Gen3 SoC Enable GPIO_RCAR which is necessary and sufficient to enable GPIO for the Renesas R-Car Gen3 r8a7775 SoC Signed-off-by: Takeshi Kihara [horms: only enable GPIO_RCAR] Signed-off-by: Simon Horman --- v0 [Takeshi Kihara] v1 [Simon Horman] * Reworded patch subject v1.1 [Simon Horman] * As suggested by Geert Uytterhoeven - Do not enable GPIO_SYSFS as it does not appear to be strictly related * Dropped enabling LEDS_GPIO as this does not appear to be used at this time * Updated changelog --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index a2ddca9c632b..b7f7c5403884 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -125,6 +125,7 @@ CONFIG_SPI=y CONFIG_SPI_PL022=y CONFIG_PINCTRL_MSM8916=y CONFIG_GPIO_PL061=y +CONFIG_GPIO_RCAR=y CONFIG_GPIO_XGENE=y CONFIG_POWER_RESET_XGENE=y CONFIG_POWER_RESET_SYSCON=y