From patchwork Mon Sep 7 16:33:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 7137341 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Original-To: patchwork-linux-sh@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 00905BEEC1 for ; Mon, 7 Sep 2015 16:29:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 20AB320610 for ; Mon, 7 Sep 2015 16:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C09E2060B for ; Mon, 7 Sep 2015 16:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbbIGQ3F (ORCPT ); Mon, 7 Sep 2015 12:29:05 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33756 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbbIGQ3E (ORCPT ); Mon, 7 Sep 2015 12:29:04 -0400 Received: by pacex6 with SMTP id ex6so100527293pac.0; Mon, 07 Sep 2015 09:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:date:message-id:in-reply-to:references:subject; bh=1PM5Kwrus58edMEXZAhze+uCgo2jrwTLaL+kjfr/NxM=; b=fNUie7G+UaFzn1lwk9I9XzKpMEGqPymz0O02Z7Mrj3nt5ZdGRswAd3I510wlijgyEJ ZcRux1ZhKnO7b1FEb7j8eOUfoobHbWIX6/cHTVFLuv0l3SCmVhfhK2y3lAqWrjujBmL4 T4dsC3IvdvpnsCC5M9olj2DnHj4ew3wgLniL2g0TCbGHhIP5tspCEiUCuMNOUxffldAJ VEz8CCT+TXksGMktgzyH07GQ02tUaVBxpK29EJ2bxhdBl/WCUHLvCV3LX1rmTI6sz7NU ZHvulFFCYW1hI98o1y7K4jr3euddNAHuS7jzC5d19R29Cq0yBNjji9+c6Hp19iFHi/4k cZFA== X-Received: by 10.68.226.134 with SMTP id rs6mr47623808pbc.11.1441643343831; Mon, 07 Sep 2015 09:29:03 -0700 (PDT) Received: from [127.0.0.1] (s214090.ppp.asahi-net.or.jp. [220.157.214.90]) by smtp.gmail.com with ESMTPSA id ts1sm301460pbc.74.2015.09.07.09.29.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Sep 2015 09:29:02 -0700 (PDT) From: Magnus Damm To: linux-clk@vger.kernel.org Cc: kuninori.morimoto.gx@renesas.com, linux-sh@vger.kernel.org, mturquette@baylibre.com, gaku.inami.xw@bp.renesas.com, sboyd@codeaurora.org, horms@verge.net.au, geert@linux-m68k.org, laurent.pinchart@ideasonboard.com, Magnus Damm Date: Tue, 08 Sep 2015 01:33:25 +0900 Message-Id: <20150907163325.475.66286.sendpatchset@little-apple> In-Reply-To: <20150907163252.475.18281.sendpatchset@little-apple> References: <20150907163252.475.18281.sendpatchset@little-apple> Subject: [PATCH v7 03/05] clk: shmobile: Make MSTP clock-output-names optional Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Magnus Damm This patch updates the MSTP driver to make the "clock-output-names" DT property optional instead of mandatory. In case the DT property is omitted then the function clk_register_clkdev() is skipped. The default for new SoCs is to not use "clock-output-names". Signed-off-by: Magnus Damm --- Changes since V6: - None Changes since V5: - Simplified code using const char *allocated_name - thanks Geert! Changes since V4: - None Changes since V3: - Added support for multiple MSTP bits. =) drivers/clk/shmobile/clk-mstp.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 0001/drivers/clk/shmobile/clk-mstp.c +++ work/drivers/clk/shmobile/clk-mstp.c 2015-09-02 11:52:02.182366518 +0900 @@ -193,26 +193,26 @@ static void __init cpg_mstp_clocks_init( for (i = 0; i < MSTP_MAX_CLOCKS; ++i) { const char *parent_name; const char *name; + const char *allocated_name = NULL; u32 clkidx; int ret; - /* Skip clocks with no name. */ - ret = of_property_read_string_index(np, "clock-output-names", - i, &name); - if (ret < 0 || strlen(name) == 0) - continue; - parent_name = of_clk_get_parent_name(np, i); ret = of_property_read_u32_index(np, idxname, i, &clkidx); if (parent_name == NULL || ret < 0) break; if (clkidx >= MSTP_MAX_CLOCKS) { - pr_err("%s: invalid clock %s %s index %u)\n", - __func__, np->name, name, clkidx); + pr_err("%s: invalid clock %s index %u)\n", + __func__, np->name, clkidx); continue; } + if (of_property_read_string_index(np, "clock-output-names", + i, &name) < 0) + allocated_name = name = kasprintf(GFP_KERNEL, "%s.%u", + np->name, clkidx); + clks[clkidx] = cpg_mstp_clock_register(name, parent_name, clkidx, group); if (!IS_ERR(clks[clkidx])) { @@ -225,12 +225,18 @@ static void __init cpg_mstp_clocks_init( * * FIXME: Remove this when all devices that require a * clock will be instantiated from DT. + * + * We currently register clkdev only when the DT + * property clock-output-names is present. */ - clk_register_clkdev(clks[clkidx], name, NULL); + if (!allocated_name) + clk_register_clkdev(clks[clkidx], name, NULL); } else { pr_err("%s: failed to register %s %s clock (%ld)\n", __func__, np->name, name, PTR_ERR(clks[clkidx])); } + + kfree(allocated_name); } of_clk_add_provider(np, of_clk_src_onecell_get, &group->data);