diff mbox

sh64: fix __NR_fgetxattr

Message ID 20151209031655.GA22704@altlinux.org (mailing list archive)
State Awaiting Upstream
Delegated to: Simon Horman
Headers show

Commit Message

Dmitry V. Levin Dec. 9, 2015, 3:16 a.m. UTC
According to arch/sh/kernel/syscalls_64.S and common sense,
__NR_fgetxattr has to be defined to 259, but it doesn't.
Instead, it's defined to 269, which is of course used
by another syscall, __NR_sched_setaffinity in this case.

This bug was found by strace test suite.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: stable@vger.kernel.org
---
 arch/sh/include/uapi/asm/unistd_64.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Dec. 9, 2015, 8:24 a.m. UTC | #1
CC akpm

On Wed, Dec 9, 2015 at 4:16 AM, Dmitry V. Levin <ldv@altlinux.org> wrote:
> According to arch/sh/kernel/syscalls_64.S and common sense,
> __NR_fgetxattr has to be defined to 259, but it doesn't.
> Instead, it's defined to 269, which is of course used
> by another syscall, __NR_sched_setaffinity in this case.
>
> This bug was found by strace test suite.
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Cc: stable@vger.kernel.org

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

> ---
>  arch/sh/include/uapi/asm/unistd_64.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/include/uapi/asm/unistd_64.h b/arch/sh/include/uapi/asm/unistd_64.h
> index e6820c8..47ebd5b 100644
> --- a/arch/sh/include/uapi/asm/unistd_64.h
> +++ b/arch/sh/include/uapi/asm/unistd_64.h
> @@ -278,7 +278,7 @@
>  #define __NR_fsetxattr         256
>  #define __NR_getxattr          257
>  #define __NR_lgetxattr         258
> -#define __NR_fgetxattr         269
> +#define __NR_fgetxattr         259
>  #define __NR_listxattr         260
>  #define __NR_llistxattr                261
>  #define __NR_flistxattr                262

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/sh/include/uapi/asm/unistd_64.h b/arch/sh/include/uapi/asm/unistd_64.h
index e6820c8..47ebd5b 100644
--- a/arch/sh/include/uapi/asm/unistd_64.h
+++ b/arch/sh/include/uapi/asm/unistd_64.h
@@ -278,7 +278,7 @@ 
 #define __NR_fsetxattr		256
 #define __NR_getxattr		257
 #define __NR_lgetxattr		258
-#define __NR_fgetxattr		269
+#define __NR_fgetxattr		259
 #define __NR_listxattr		260
 #define __NR_llistxattr		261
 #define __NR_flistxattr		262