From patchwork Tue Aug 2 10:35:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9260151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CEC7460865 for ; Tue, 2 Aug 2016 18:38:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C153628304 for ; Tue, 2 Aug 2016 18:38:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AFB36284F9; Tue, 2 Aug 2016 18:38:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4374E28304 for ; Tue, 2 Aug 2016 18:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757389AbcHBShd (ORCPT ); Tue, 2 Aug 2016 14:37:33 -0400 Received: from mga03.intel.com ([134.134.136.65]:12624 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754417AbcHBLNH (ORCPT ); Tue, 2 Aug 2016 07:13:07 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 02 Aug 2016 04:13:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,459,1464678000"; d="scan'208";a="1028243531" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by orsmga002.jf.intel.com with ESMTP; 02 Aug 2016 04:13:04 -0700 From: Baole Ni To: ysato@users.sourceforge.jp, dalias@libc.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, phacht@linux.vnet.ibm.com, keescook@chromium.org Subject: [PATCH 0027/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:35:26 +0800 Message-Id: <20160802103526.15569-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- arch/sh/mm/alignment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/mm/alignment.c b/arch/sh/mm/alignment.c index ec2b253..6cb05b2 100644 --- a/arch/sh/mm/alignment.c +++ b/arch/sh/mm/alignment.c @@ -29,7 +29,7 @@ static int se_usermode = UM_WARN | UM_FIXUP; /* 0: no warning 1: print a warning message, disabled by default */ static int se_kernmode_warn; -core_param(alignment, se_usermode, int, 0600); +core_param(alignment, se_usermode, int, S_IRUSR | S_IWUSR); void inc_unaligned_byte_access(void) {