| Message ID | 20170103230639.19660-12-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Laurent, On Wed, Jan 4, 2017 at 12:06 AM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > According to the datasheets, the sh7760 SIM and sh7723 SCIFA instances > don't implement the REIE bit. Don't set it in platform data. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > arch/sh/kernel/cpu/sh4/setup-sh7760.c | 1 - > arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/arch/sh/kernel/cpu/sh4/setup-sh7760.c b/arch/sh/kernel/cpu/sh4/setup-sh7760.c > index 6dbcbf1621aa..e51fe1734e13 100644 > --- a/arch/sh/kernel/cpu/sh4/setup-sh7760.c > +++ b/arch/sh/kernel/cpu/sh4/setup-sh7760.c > @@ -200,7 +200,6 @@ static struct platform_device scif2_device = { > }; > > static struct plat_sci_port scif3_platform_data = { > - .scscr = SCSCR_REIE, Note that this bit does have a function (WAIT_IE --- Enables wait error interrupt (SIMERI) requests), so this may impact behavior. > /* > * This is actually a SIM card module serial port, based on an SCI with > * additional registers. The sh-sci driver doesn't support the SIM port Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sh/kernel/cpu/sh4/setup-sh7760.c b/arch/sh/kernel/cpu/sh4/setup-sh7760.c index 6dbcbf1621aa..e51fe1734e13 100644 --- a/arch/sh/kernel/cpu/sh4/setup-sh7760.c +++ b/arch/sh/kernel/cpu/sh4/setup-sh7760.c @@ -200,7 +200,6 @@ static struct platform_device scif2_device = { }; static struct plat_sci_port scif3_platform_data = { - .scscr = SCSCR_REIE, /* * This is actually a SIM card module serial port, based on an SCI with * additional registers. The sh-sci driver doesn't support the SIM port diff --git a/arch/sh/kernel/cpu/sh4a/setup-sh7723.c b/arch/sh/kernel/cpu/sh4a/setup-sh7723.c index 6c5cb234aa33..1c1b3c469831 100644 --- a/arch/sh/kernel/cpu/sh4a/setup-sh7723.c +++ b/arch/sh/kernel/cpu/sh4a/setup-sh7723.c @@ -86,7 +86,6 @@ static struct platform_device scif2_device = { }; static struct plat_sci_port scif3_platform_data = { - .scscr = SCSCR_REIE, .sampling_rate = 8, .type = PORT_SCIFA, }; @@ -107,7 +106,6 @@ static struct platform_device scif3_device = { }; static struct plat_sci_port scif4_platform_data = { - .scscr = SCSCR_REIE, .sampling_rate = 8, .type = PORT_SCIFA, }; @@ -128,7 +126,6 @@ static struct platform_device scif4_device = { }; static struct plat_sci_port scif5_platform_data = { - .scscr = SCSCR_REIE, .sampling_rate = 8, .type = PORT_SCIFA, };
According to the datasheets, the sh7760 SIM and sh7723 SCIFA instances don't implement the REIE bit. Don't set it in platform data. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/sh/kernel/cpu/sh4/setup-sh7760.c | 1 - arch/sh/kernel/cpu/sh4a/setup-sh7723.c | 3 --- 2 files changed, 4 deletions(-)