From patchwork Fri Jun 30 00:54:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 9818221 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D98A6602B1 for ; Fri, 30 Jun 2017 00:54:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5D392851A for ; Fri, 30 Jun 2017 00:54:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A61DB2851F; Fri, 30 Jun 2017 00:54:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0485C2851A for ; Fri, 30 Jun 2017 00:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751683AbdF3AyZ (ORCPT ); Thu, 29 Jun 2017 20:54:25 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:46138 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbdF3AyU (ORCPT ); Thu, 29 Jun 2017 20:54:20 -0400 Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id E3BB08365F; Fri, 30 Jun 2017 12:54:17 +1200 (NZST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail; t=1498784057; bh=FYRVbIhn4qMiKbSmkpAwS0W2FpV/mZRe8mzkLnRQkzI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=e0sewRgvPsMndRhh5fvz5ueTR/VLZ2j6H9cb17UAF7/ypHJq705L5OLrRRc/OpyBO Hjq5rz8DhmK/RndzUhPO5bdmFnn63A4unOxydO5X7TxJQkOMLBwUrCV0BDL86spsPn WgToOeDPEd/g+jzXDGtzdPtjWxTwqimi80UYpukw= Received: from smtp (Not Verified[10.32.16.33]) by mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 7, 9061) id ; Fri, 30 Jun 2017 12:54:17 +1200 Received: from chrisp-dl.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by smtp (Postfix) with ESMTP id 947B813F098; Fri, 30 Jun 2017 12:54:21 +1200 (NZST) Received: by chrisp-dl.atlnz.lc (Postfix, from userid 1030) id 9EB411E1D80; Fri, 30 Jun 2017 12:54:16 +1200 (NZST) From: Chris Packham To: wsa@the-dreams.de, andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org Cc: ysato@users.sourceforge.jp, linux-sh@vger.kernel.org, Chris Packham , linux-kernel@vger.kernel.org Subject: [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus Date: Fri, 30 Jun 2017 12:54:05 +1200 Message-Id: <20170630005408.23968-4-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz> References: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rather than returning -ENODEV if i2c_pca_add_numbered_bus() fails, propagate the error to aid debugging. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-pca-platform.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c index daccef6865e8..853a2abedb05 100644 --- a/drivers/i2c/busses/i2c-pca-platform.c +++ b/drivers/i2c/busses/i2c-pca-platform.c @@ -232,9 +232,9 @@ static int i2c_pca_pf_probe(struct platform_device *pdev) return ret; } - if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) { - return -ENODEV; - } + ret = i2c_pca_add_numbered_bus(&i2c->adap); + if (ret) + return ret; platform_set_drvdata(pdev, i2c);