From patchwork Mon Dec 11 12:50:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 10104959 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4BCF4602B3 for ; Mon, 11 Dec 2017 12:53:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20CDC29586 for ; Mon, 11 Dec 2017 12:53:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14AF029588; Mon, 11 Dec 2017 12:53:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8D98529586 for ; Mon, 11 Dec 2017 12:53:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbdLKMw7 (ORCPT ); Mon, 11 Dec 2017 07:52:59 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34069 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842AbdLKMwz (ORCPT ); Mon, 11 Dec 2017 07:52:55 -0500 Received: by mail-pf0-f194.google.com with SMTP id a90so11476568pfk.1; Mon, 11 Dec 2017 04:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Xh1KAgZHKULK6oMTEezZ1r/o9WbIur36MMyO4hjj1UE=; b=IyFHR8RqQ/LjlmPgYfDfGiiMag86jq0jwmYf4iTVRmiBqpbyadRnh3wWn9ZR0xxCVU VWFZ5cVDUU22RVUpirJb/EBTYVduYP/G3CwmR2lwdAz9S497loHvCE9CA51PVI2Pm9l4 Z8D6RrvewJdSv9gt8ZXXIzTaRZiiT9BIfGdUPj3751O96a0jnk612KD2yfLMpZpugU5e xLFOlvGbf5fFO2cyvjLS7pqAg0tPqGi1tMUzSfDmiTXfYn3F/jKBthhUztgVzKFGAjXg IYePIP6igEsttgNCAOpZqC97t9enInzbLZallEOLbqZ/CoT1ZJ91uZQS/3Viv4KaEKCv 1J2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Xh1KAgZHKULK6oMTEezZ1r/o9WbIur36MMyO4hjj1UE=; b=qfPUknI2PobBuCRDWrdB9gmyMjeBdDYfCDrKpTDo/4FNhPj/lFJIrgZhvL241PAABq 0LGe+SkYDmqeAiMS/wJCUgnFyYFVuceNbQ6a8qtYZ12bTcjHuxNf1+vsB7FAC/oyZcDD cWCfSldcBZ/e/baMrreNUBrVyY9G477nYEZM7sE0ZKKwPiG0a9LvqM2pl2D0kW1lCuSZ mpudvfUDlU1q/3KAZqFRWAwnAExlLe6lVaAITEDkx7HBXw1CTedJaL7MM4rEuoouRNcc t9YtHfqsG64uqj3w13k+qJL+pmshwDw3r2WQMU4fOwNLUeAz/8ZvUgFynl9fGOwgOe8L PC8w== X-Gm-Message-State: AKGB3mJHwZBQMIZwY0M2X7HGMpdA6RHtxnCW3mXvC0wmWlEH4r1/Owjz 15h7+Xpx1+4Y8vZCjIXN06Q= X-Google-Smtp-Source: ACJfBotjpjiPB8S+c2E8jvJKg+4Hpg11D9rbueGu3p/WZAgVh3E+ENbQDU6+X853+kdnNA9yckJw1g== X-Received: by 10.84.168.226 with SMTP id f89mr303572plb.176.1512996774484; Mon, 11 Dec 2017 04:52:54 -0800 (PST) Received: from localhost.localdomain ([110.70.53.61]) by smtp.gmail.com with ESMTPSA id j13sm23374380pff.131.2017.12.11.04.52.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 04:52:53 -0800 (PST) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky To: Andrew Morton , Russell King , Catalin Marinas , Mark Salter , Tony Luck , David Howells , Yoshinori Sato , Guan Xuetao , Borislav Petkov , Greg Kroah-Hartman , Thomas Gleixner , Peter Zijlstra , Vineet Gupta , Fengguang Wu Cc: Steven Rostedt , Petr Mladek , LKML , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-ia64@vger.kernel.org, linux-am33-list@redhat.com, linux-sh@vger.kernel.org, linux-edac@vger.kernel.org, x86@kernel.org, linux-snps-arc@lists.infradead.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: [PATCH 11/13] irq debug: do not use print_symbol() Date: Mon, 11 Dec 2017 21:50:23 +0900 Message-Id: <20171211125025.2270-12-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> References: <20171211125025.2270-1-sergey.senozhatsky@gmail.com> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP print_symbol() uses extra stack space to sprintf() symbol information and then to feed that buffer to printk() char buffer[KSYM_SYMBOL_LEN]; sprint_symbol(buffer, address); printk(fmt, buffer); Replace print_symbol() with a direct printk("%pS") call. Signed-off-by: Sergey Senozhatsky Cc: Thomas Gleixner --- kernel/irq/debug.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h index 17f05ef8f575..5766e15c1160 100644 --- a/kernel/irq/debug.h +++ b/kernel/irq/debug.h @@ -3,8 +3,6 @@ * Debugging printout: */ -#include - #define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f) #define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f) /* FIXME */ @@ -15,13 +13,13 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); printk("->handle_irq(): %p, ", desc->handle_irq); - print_symbol("%s\n", (unsigned long)desc->handle_irq); + pr_cont("%pS\n", desc->handle_irq); printk("->irq_data.chip(): %p, ", desc->irq_data.chip); - print_symbol("%s\n", (unsigned long)desc->irq_data.chip); + pr_cont("%pS\n", desc->irq_data.chip); printk("->action(): %p\n", desc->action); if (desc->action) { printk("->action->handler(): %p, ", desc->action->handler); - print_symbol("%s\n", (unsigned long)desc->action->handler); + pr_cont("%pS\n", desc->action->handler); } ___P(IRQ_LEVEL);